Skip to contentSkip to conversation

powerpc/5200: fix building GPT driver without sysfs

PATCH In review Alexander Beregalov 2 participants 2 messages Mar 16, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/5200: fix building GPT driver without sysfs

arch/powerpc/platforms/52xx/mpc52xx_gpt.c: In function 'mpc52xx_gpt_create_attribs':
arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: error: parameter name omitted arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: warning: 'return' with a value, in function returning void

---

 arch/powerpc/platforms/52xx/mpc52xx_gpt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +1 -1
index cb038dc..ef81cce 100644
@@ -370,7 +370,7 @@ static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt)
 }
 
 #else /* defined(CONFIG_SYSFS) */
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *) { return 0; }
+static inline void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt) {}
 #endif /* defined(CONFIG_SYSFS) */
 
 /* ---------------------------------------------------------------------
#1 lore raw
Quoted 5 lines · Alexander Beregalov

arch/powerpc/platforms/52xx/mpc52xx_gpt.c: In function 'mpc52xx_gpt_create_attribs':
arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: error: parameter name omitted arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: warning: 'return' with a value, in function returning void

A patch has already been queued in the next branch of
git://git.secretlab.ca/git/linux-2.6-mpc52xx which removes the sysfs code from this driver entirely. Ben just hasn't pulled it into his -next branch yet.

g.

Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.