Skip to contentSkip to conversation

sunrpc: fix build breakage

PATCH In review Alexander Beregalov 3 participants 3 messages Mar 16, 2009 – Mar 18, 2009 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunrpc: fix build breakage

net/sunrpc/clnt.c: In function 'call_bind_status':
net/sunrpc/clnt.c:994: error: 'struct rpc_task' has no member named 'tk_pid'
net/sunrpc/clnt.c: In function 'call_connect_status':
net/sunrpc/clnt.c:1051: error: 'struct rpc_task' has no member named 'tk_pid'

rpc_task has tk_pid if RPC_DEBUG is defined.

---

 net/sunrpc/clnt.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
net/sunrpc/clnt.c +2 -2
index efd0c7b..68cb91a 100644
@@ -990,7 +990,7 @@ call_bind_status(struct rpc_task *task)
 		return;
 	default:
 		if (net_ratelimit())
-			printk("RPC: %5u unrecognized rpcbind error (%d)\n",
+			dprintk("RPC: %5u unrecognized rpcbind error (%d)\n",
 					task->tk_pid, -task->tk_status);
 	}
 
@@ -1047,7 +1047,7 @@ call_connect_status(struct rpc_task *task)
 		break;
 	default:
 		if (net_ratelimit())
-			printk("RPC: %5u unrecognized connect error (%d)\n",
+			dprintk("RPC: %5u unrecognized connect error (%d)\n",
 					task->tk_pid, status);
 		rpc_exit(task, -EIO);
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 29 lines · Alexander Beregalov

net/sunrpc/clnt.c: In function 'call_bind_status':
net/sunrpc/clnt.c:994: error: 'struct rpc_task' has no member named 'tk_pid'
net/sunrpc/clnt.c: In function 'call_connect_status':
net/sunrpc/clnt.c:1051: error: 'struct rpc_task' has no member named 'tk_pid'

rpc_task has tk_pid if RPC_DEBUG is defined.

---

 net/sunrpc/clnt.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
net/sunrpc/clnt.c +1 -1
index efd0c7b..68cb91a 100644
@@ -990,7 +990,7 @@ call_bind_status(struct rpc_task *task)
 		return;
 	default:
 		if (net_ratelimit())
-			printk("RPC: %5u unrecognized rpcbind error (%d)\n",
+			dprintk("RPC: %5u unrecognized rpcbind error (%d)\n",
 					task->tk_pid, -task->tk_status);
 	}
 

net/sunrpc/clnt.c call_connect_status(struct rpc_task *task) · line 1053

Quoted 8 lines
net/sunrpc/clnt.c +1 -1
@@ -1047,7 +1047,7 @@ call_connect_status(struct rpc_task *task)
 		break;
 	default:
 		if (net_ratelimit())
-			printk("RPC: %5u unrecognized connect error (%d)\n",
+			dprintk("RPC: %5u unrecognized connect error (%d)\n",
 					task->tk_pid, status);
 		rpc_exit(task, -EIO);
 	}

No, that's not right. The intention is to always report errors that are fatal and are due to unforeseen circumstances. Your patch means that those reports are suppressed entirely when RPC_DEBUG is undefined.

Trond

Signature · 6 lines
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
www.netapp.com

A message that is not in the archive (sent off-list or not yet received): 1237208680.7229.14.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org

#3 lore raw
Quoted 29 lines · On Mon, 16 Mar 2009 09:04:40 -0400 Trond Myklebust wrote:
Quoted 28 lines · Alexander Beregalov

net/sunrpc/clnt.c: In function 'call_bind_status':
net/sunrpc/clnt.c:994: error: 'struct rpc_task' has no member named 'tk_pid'
net/sunrpc/clnt.c: In function 'call_connect_status':
net/sunrpc/clnt.c:1051: error: 'struct rpc_task' has no member named 'tk_pid'

rpc_task has tk_pid if RPC_DEBUG is defined.

---

 net/sunrpc/clnt.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
net/sunrpc/clnt.c +1 -1
index efd0c7b..68cb91a 100644
@@ -990,7 +990,7 @@ call_bind_status(struct rpc_task *task)
 		return;
 	default:
 		if (net_ratelimit())
-			printk("RPC: %5u unrecognized rpcbind error (%d)\n",
+			dprintk("RPC: %5u unrecognized rpcbind error (%d)\n",
 					task->tk_pid, -task->tk_status);
 	}
 
Quoted 13 lines

net/sunrpc/clnt.c call_connect_status(struct rpc_task *task) · line 1053

Quoted 9 lines
net/sunrpc/clnt.c +1 -1
@@ -1047,7 +1047,7 @@ call_connect_status(struct rpc_task *task)
 		break;
 	default:
 		if (net_ratelimit())
-			printk("RPC: %5u unrecognized connect error (%d)\n",
+			dprintk("RPC: %5u unrecognized connect error (%d)\n",
 					task->tk_pid, status);
 		rpc_exit(task, -EIO);
 	}

No, that's not right. The intention is to always report errors that are fatal and are due to unforeseen circumstances. Your patch means that those reports are suppressed entirely when RPC_DEBUG is undefined.

nevertheless, the build breakage is still around in linux-next 20090318...

---
~Randy