Skip to contentSkip to conversation

be2net: replenish when posting to rx-queue is starved in out of mem conditions

PATCH In review Sathya Perla 3 participants 4 messages Mar 19, 2009 – Mar 20, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 be2net: replenish when posting to rx-queue is starved in out of mem conditions

Hi, this is a patch to replenish the rx-queue when it is in a starved state (due to out-of-mem conditions)

thanks,
-Sathya
P.S: Pls ignore the "company confidential" warning at the end of the patch emails.

---
 drivers/net/benet/be.h      |    1 +
 drivers/net/benet/be_main.c |   50 +++++++++++++++++++++++++------------------
 2 files changed, 30 insertions(+), 21 deletions(-)
drivers/net/benet/be.h +1 -0
index 63d593d..f327be5 100644
@@ -194,6 +194,7 @@ struct be_adapter {
 	struct be_eq_obj rx_eq;
 	struct be_rx_obj rx_obj;
 	u32 big_page_size;	/* Compounded page size shared by rx wrbs */
+	bool rx_post_starved;	/* Zero rx frags have been posted to BE */
 
 	struct vlan_group *vlan_grp;
 	u16 num_vlans;
drivers/net/benet/be_main.c +29 -21

69 lines not on this page · raw message

Signature · 12 lines
1.5.6.3





___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.
maintainer
#1 lore raw

From: Sathya Perla <[email protected]>
Date: Thu, 19 Mar 2009 14:43:01 +0530

Quoted 7 lines

Hi, this is a patch to replenish the rx-queue when it is in a starved state (due to out-of-mem conditions)

thanks,
-Sathya
P.S: Pls ignore the "company confidential" warning at the end of the patch emails.

Next you'll be sending us "P.P.S: Please ignore the P.S".

Saying this "ignore the confidential warning" just makes it even more painful, it's yet another thing to "ignore". Are there some legal ramifications for you saying this? I bet not, so what's the point? The legalise still applies and it still consumes space in our inboxes.

It's extremely impolite, at the very best.

Quoted 1 line

I'll apply your patches, but use gmail or something if you can't make this annoying company confidential crap just go away, thanks.

#2 lore raw
Quoted 4 lines · David Miller

I'll apply your patches, but use gmail or something if you can't make this annoying company confidential crap just go away, thanks.

Sorry about this; I'm re-posting the patch below:

---
 drivers/net/benet/be.h      |    1 +
 drivers/net/benet/be_main.c |   50 +++++++++++++++++++++++++------------------
 2 files changed, 30 insertions(+), 21 deletions(-)
drivers/net/benet/be.h +1 -0
index 63d593d..f327be5 100644
@@ -194,6 +194,7 @@ struct be_adapter {
 	struct be_eq_obj rx_eq;
 	struct be_rx_obj rx_obj;
 	u32 big_page_size;	/* Compounded page size shared by rx wrbs */
+	bool rx_post_starved;	/* Zero rx frags have been posted to BE */
 
 	struct vlan_group *vlan_grp;
 	u16 num_vlans;
drivers/net/benet/be_main.c +29 -21

69 lines not on this page · raw message

Signature · 1 line
1.5.6.3
maintainer
#3 lore raw

From: Sathya Perla <[email protected]>
Date: Fri, 20 Mar 2009 15:49:25 +0530

Quoted 7 lines · David Miller
Quoted 4 lines

I'll apply your patches, but use gmail or something if you can't make this annoying company confidential crap just go away, thanks.

Sorry about this; I'm re-posting the patch below:

I said "I'll apply your patches" as in, I've applied these already but "in the future could you please..."

You didn't need to resubmit these.