Skip to contentSkip to conversation

powerpc/cpm2: fix building fs_enet driver as a module.

PATCH Applied Grant Likely 2 participants 2 messages Mar 19, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/cpm2: fix building fs_enet driver as a module.

From: Grant Likely <[email protected]>

Building the fs_enet driver as a modules fails because it cannot access the global cpm2_immr symbol.

---

Hey Ben and Kumar,

Just found this while testing some unrelated changes. Technically this is a bug fix that should go into 2.6.29, but it looks like an old problem and probably nobody is getting bitten by it. I don't think the world is going to end if it misses the 2.6.29 release.

g.

 arch/powerpc/sysdev/cpm2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/powerpc/sysdev/cpm2.c +1 -0
index f1c3395..021480e 100644
@@ -52,6 +52,7 @@ cpm_cpm2_t __iomem *cpmp; /* Pointer to comm processor space */
  * the communication processor devices.
  */
 cpm2_map_t __iomem *cpm2_immr;
+EXPORT_SYMBOL(cpm2_immr);
 
 #define CPM_MAP_SIZE	(0x40000)	/* 256k - the PQ3 reserve this amount
 					   of space for CPM as it is larger
Applied
#1 lore raw
Quoted 15 lines · Grant Likely

From: Grant Likely <[email protected]>

Building the fs_enet driver as a modules fails because it cannot access the global cpm2_immr symbol.

---

Hey Ben and Kumar,

Just found this while testing some unrelated changes. Technically this is a bug fix that should go into 2.6.29, but it looks like an old problem and probably nobody is getting bitten by it. I don't think the world is going to end if it misses the 2.6.29 release.

Quoted 4 lines

g.

arch/powerpc/sysdev/cpm2.c | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)

applied to next. (I agree this isn't worth .29 at this point, if anyone cares they can lobby for it in .29.1)

- k