OMAP2/3: GPIO: do not attempt to wake-enable GPIO bank IRQ
Subsystems (2)
PATCH v2 1/1 OMAP2/3: GPIO: do not attempt to wake-enable GPIO bank IRQ
The GPIO IRQ enable/disable path attempts to also enable IRQ wake support for the parent GPIO bank IRQ as well. However, since there is no 'set_wake' hook for the bank IRQs, these calls will always fail. Also, since the enable will fail on the suspend path, the disable on the resume path will trigger unbalanced enable/disable warnings.
This was discovered in the suspend/resume path on OMAP3/Beagle using the gpio-keys driver which disables/re-enables GPIO IRQ wakeups in the suspend/resume path.
---
This patch was sent on 28 jan 2009 as:
[PATCH omap-fixes] OMAP2/3: GPIO: remove recursion in IRQ wakeup path
This version simply updates the description to better describe the problem and solution.
arch/arm/plat-omap/gpio.c | 14 ++++---------- 1 files changed, 4 insertions(+), 10 deletions(-)
arch/arm/plat-omap/gpio.c +4 -10
@@ -837,13 +837,10 @@ static int _set_gpio_wakeup(struct gpio_bank *bank, int gpio, int enable)case METHOD_MPUIO :case METHOD_GPIO_1610 :spin_lock_irqsave (&bank->lock, flags); -if (enable) { +if (enable) bank->suspend_wakeup |= (1 << gpio); -enable_irq_wake (bank->irq); - }else { -disable_irq_wake (bank->irq); +else bank->suspend_wakeup &= ~(1 << gpio); - }spin_unlock_irqrestore (&bank->lock, flags);return 0 ;#endif
@@ -856,13 +853,10 @@ static int _set_gpio_wakeup(struct gpio_bank *bank, int gpio, int enable) return -EINVAL; }spin_lock_irqsave (&bank->lock, flags); -if (enable) { +if (enable) bank->suspend_wakeup |= (1 << gpio); -enable_irq_wake (bank->irq); - }else { -disable_irq_wake (bank->irq); +else bank->suspend_wakeup &= ~(1 << gpio); - }spin_unlock_irqrestore (&bank->lock, flags);return 0 ;#endif
Signature · 1 line
1.6.1.2
PATCH v2 1/1 OMAP2/3: GPIO: do not attempt to wake-enable
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Commit: 2ac496a208895c925aec1774a873b5b096b2d3f0
PatchWorks
http://patchwork.kernel.org/patch/10719/
Re: [APPLIED] [PATCH omap-fixes v2] OMAP2/3: GPIO: do not attempt to wake-enable
Quoted 10 lines · Tony Lindgren
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.Commit:
2ac496a208895c925aec1774a873b5b096b2d3f0PatchWorks
http://patchwork.kernel.org/patch/10719/
Tony,
$SUBJECT on this commit seems to have been a bit mangled leaving a not very clear commit log/history.
Kevin
Re: [APPLIED] [PATCH omap-fixes v2] OMAP2/3: GPIO: do not attempt to wake-enable
Quoted 10 lines · Kevin Hilman
Quoted 8 lines · Tony Lindgren
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.Commit:
2ac496a208895c925aec1774a873b5b096b2d3f0PatchWorks
http://patchwork.kernel.org/patch/10719/
Quoted 7 lines
Quoted 2 lines
Tony,
$SUBJECT on this commit seems to have been a bit mangled leaving a not very clear commit log/history.
Heh looks like bad html parsing :) I'll revert and re-apply.
Tony
Re: [APPLIED] [PATCH omap-fixes v2] OMAP2/3: GPIO: do not attempt to wake-enable
Quoted 14 lines · Tony Lindgren
Quoted 13 lines · Kevin Hilman
Quoted 10 lines · Tony Lindgren
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.Commit:
2ac496a208895c925aec1774a873b5b096b2d3f0PatchWorks
http://patchwork.kernel.org/patch/10719/
Quoted 6 lines
Quoted 4 lines
Tony,
$SUBJECT on this commit seems to have been a bit mangled leaving a not very clear commit log/history.
Heh looks like bad html parsing :) I'll revert and re-apply.
why do you even try to parse the html ?? patchworks hold it in mbox format:
http://patchwork.kernel.org/patch/10719/mbox/
Signature · 1 line
balbi
Re: [APPLIED] [PATCH omap-fixes v2] OMAP2/3: GPIO: do not attempt to wake-enable
In reply to Tony LindgrenQuoted 14 lines · Tony Lindgren
Quoted 13 lines · Kevin Hilman
Quoted 10 lines · Tony Lindgren
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.Commit:
2ac496a208895c925aec1774a873b5b096b2d3f0PatchWorks
http://patchwork.kernel.org/patch/10719/
Quoted 6 lines
Quoted 4 lines
Tony,
$SUBJECT on this commit seems to have been a bit mangled leaving a not very clear commit log/history.
Heh looks like bad html parsing :) I'll revert and re-apply.
Seems like a bug in pwclient..
$ pwclient get 10719
Shows the subject in the patch as:
Subject: [omap-fixes,
v2] OMAP2/3: GPIO: do not attempt to wake-enable GPIO bank IRQ
Tony
Re: [APPLIED] [PATCH omap-fixes v2] OMAP2/3: GPIO: do not attempt to wake-enable
Quoted 8 lines · Tony Lindgren
Seems like a bug in pwclient..
$ pwclient get 10719Shows the subject in the patch as:
Subject: [omap-fixes,
v2] OMAP2/3: GPIO: do not attempt to wake-enable GPIO bank IRQ
$ curl http://patchwork.kernel.org/patch/10719/mbox | git am -s
would do the trick :-p
Signature · 1 line
balbi