libata: ahci enclosure save new led state
PATCH 1/1 libata: ahci enclosure save new led state
ahci_transmit_led_message saves off the led_state with a value that includes the port number OR'd in, this incorrect value maybe reported back in ahci_led_store.
For instance, if you turn off all the leds for port 1 and cat the value back it will report 1 instead of 0.
# echo 0 > /sys/class/scsi_host/host1/em_message # cat /sys/class/scsi_host/host1/em_message 1
Signed-off-by David Milburn <[email protected]>
--- drivers/ata/ahci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ata/ahci.c +1 -1
@@ -1348,7 +1348,7 @@ static ssize_t ahci_transmit_led_message(struct ata_port *ap, u32 state,writel (message[1 ], mmio + hpriv->em_loc+4 );/* save off new led state for port/slot */ - emp->led_state = message[1 ]; + emp->led_state = state;/* * tell hardware to transmit the message
Jeff Garzik
AppliedQuoted 9 lines · David Milburn
ahci_transmit_led_messagesaves off theled_statewith a value that includes the port number OR'd in, this incorrect value maybe reported back inahci_led_store.For instance, if you turn off all the leds for port 1 and cat the value back it will report 1 instead of 0.
Quoted 8 lines
# echo 0 > /sys/class/scsi_host/host1/em_message # cat /sys/class/scsi_host/host1/em_message 1Signed-off-by David Milburn <[email protected]>--- drivers/ata/ahci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
applied