Skip to contentSkip to conversation

net: sh_eth: Remove sh_eth_reset() from halt function

PATCH New Nobuhiro Iwamatsu 3 participants 4 messages Mar 18, 2009 – Mar 20, 2009 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: sh_eth: Remove sh_eth_reset() from halt function

sh_eth_reset is function to reset Ether IP.
The MAC address is stored in IP, but it is initialized by this function. OS (e.g. Linux Kernel) can not use this device when initialized. This revises this problem.

---
 drivers/net/sh_eth.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/sh_eth.c +0 -2
index ebe8588..bee3f02 100644
@@ -639,8 +639,6 @@ err:
 void sh_eth_halt(struct eth_device *dev)
 {
 	struct sh_eth_dev *eth = dev->priv;
-
-	sh_eth_reset(eth);
 	sh_eth_stop(eth);
 }
 
Signature · 1 line
1.6.2
#1 lore raw

PATCH 1/1 net: sh_eth: Remove sh_eth_reset() from halt function

Hi,

Sorry,
Please take this patch in 2009.03 not 2008.03.

Best regards,
Nobuhiro

Quoted 30 lines · On Wed, 18 Mar 2009 12:27:04 +0900 Nobuhiro Iwamatsu…

sh_eth_reset is function to reset Ether IP.
The MAC address is stored in IP, but it is initialized by this function. OS (e.g. Linux Kernel) can not use this device when initialized. This revises this problem.

---
 drivers/net/sh_eth.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/sh_eth.c +0 -2
index ebe8588..bee3f02 100644
@@ -639,8 +639,6 @@ err:
 void sh_eth_halt(struct eth_device *dev)
 {
 	struct sh_eth_dev *eth = dev->priv;
-
-	sh_eth_reset(eth);
 	sh_eth_stop(eth);
 }
 
Signature · 5 lines
1.6.2
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 5 lines
Nobuhiro Iwamatsu
	hemamu at t-base.ne.jp
	iwamatsu at debian.or.jp

	GPG ID : 3170EBE9
#2 lore raw

PATCH 1/1 net: sh_eth: Remove sh_eth_reset() from halt function

Dear Nobuhiro Iwamatsu,

Quoted 3 lines · In message <[email protected]> you wrote:

Sorry,
Please take this patch in 2009.03 not 2008.03.

Done, thanks for pointing out.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three things I always forget. Names, faces -  the  third  I
can't remember.                                         - Italo Svevo
#3 lore raw

PATCH 1/1 net: sh_eth: Remove sh_eth_reset() from halt function

In reply to Nobuhiro Iwamatsu

Dear Nobuhiro Iwamatsu,

Quoted 9 lines · In message <[email protected]> you wrote:

sh_eth_reset is function to reset Ether IP.
The MAC address is stored in IP, but it is initialized by this function. OS (e.g. Linux Kernel) can not use this device when initialized. This revises this problem.

---
 drivers/net/sh_eth.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 9 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Can you imagine how life could be improved if we could do away with
jealousy, greed, hate ..."
"It can also be improved by eliminating love, tenderness, sentiment
-- the other side of the coin"
	-- Dr. Roger Corby and Kirk, "What are Little Girls Made Of?",
	   stardate 2712.4