Skip to contentSkip to conversation

axes conversion for hp compaq 8710w for HP_ACCEL linux kernel module (fwd)

PATCH Pavel Machek 2 participants 3 messages Mar 21, 2009 – Mar 31, 2009

lore
Share & tools
lore
#0 lore raw

Hi!

It seems like Luca has one more whitelist entry...
Pavel

Subject: axes conversion for hp compaq 8710w for HP_ACCEL linux kernel module
From: Luca Cappa <[email protected]>

Hello,

I have a laptop HP Compaq 8710W, I compiled into my kernel the LIS3LV02DL and HP_ACCEL module drivers. While loading it cannot recognize the laptop
model, so i am sending the necessary information to update the database of Axes Orientations.

Quoted 2 lines

When the laptop is horizontal the position reported is about 0 for X and Y and a positive value for Z

Yes, it is about 0,0,1000, the actual reading says: (-17,-26,1018);

Quoted 1 line

If the left side is elevated, X increases (becomes positive)

Yes, X goes toward to positive 1000.

Quoted 1 line

If the front side (where the touchpad is) is elevated, Y decreases (becomes negative)

No, Y goes toward to positive 1000.

Quoted 1 line

If the laptop is put upside-down, Z becomes negative

Yes, the laptop on a table Z gives 1000, and if upsidedown the Z reads -1000.

So in few words the Y axis is inverted, I paste here below the very simple patch to configure properly the axis conversion. The patch is against the file hp_accel.c of 2.6.29-rc8, i.e. the one shown here:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/hwmon/hp_accel.c;h=29c83b5b96974bb88cbeb67d896ba46ee71469f2;hb=HEAD

Greetings,
Luca

hp_accel.c renamed from home/luca/Desktop/hp_accel.c +1 -0
@@ -201,6 +201,7 @@
 			PRODUCT_NAME, "HP Pavilion dv5",
 			BOARD_NAME, "3600",
 			y_inverted),
+    AXIS_DMI_MATCH("HP8710", "HP Compaq 8710", y_inverted),
 	{ NULL, }
 /* Laptop models witho
 

----- End forwarded message -----

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 1 line · On Sun, 22 Mar 2009 00:08:19 +0100 Pavel Machek <[email protected]> wrote:

Hi!

hi to you too.

Quoted 43 lines

It seems like Luca has one more whitelist entry...
Pavel

Subject: axes conversion for hp compaq 8710w for HP_ACCEL linux kernel module
From: Luca Cappa <[email protected]>

Hello,

I have a laptop HP Compaq 8710W, I compiled into my kernel the LIS3LV02DL and HP_ACCEL module drivers. While loading it cannot recognize the laptop
model, so i am sending the necessary information to update the database of Axes Orientations.

Quoted 2 lines

When the laptop is horizontal the position reported is about 0 for X and Y and a positive value for Z

Yes, it is about 0,0,1000, the actual reading says: (-17,-26,1018);

Quoted 1 line

If the left side is elevated, X increases (becomes positive)

Yes, X goes toward to positive 1000.

Quoted 1 line

If the front side (where the touchpad is) is elevated, Y decreases (becomes negative)

No, Y goes toward to positive 1000.

Quoted 1 line

If the laptop is put upside-down, Z becomes negative

Yes, the laptop on a table Z gives 1000, and if upsidedown the Z reads -1000.

So in few words the Y axis is inverted, I paste here below the very simple patch to configure properly the axis conversion. The patch is against the file hp_accel.c of 2.6.29-rc8, i.e. the one shown here:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/hwmon/hp_accel.c;h=29c83b5b96974bb88cbeb67d896ba46ee71469f2;hb=HEAD

Greetings,
Luca

hp_accel.c line 206

Quoted 6 lines
hp_accel.c renamed from home/luca/Desktop/hp_accel.c +1 -0
@@ -201,6 +201,7 @@
 			PRODUCT_NAME, "HP Pavilion dv5",
 			BOARD_NAME, "3600",
 			y_inverted),
+    AXIS_DMI_MATCH("HP8710", "HP Compaq 8710", y_inverted),
 	{ NULL, }
 /* Laptop models witho

- changelog is a mess
- originator wasn't cc'ed
- originator's signed-off-by: is missing
- your signed-off-by: is missing
- patch isn't in `patch -p1' form
- patch is whitespace-mangled

I fixed some of that up. It'd be nice to get some Signed-off-by:s, please.

#2 lore raw
Quoted 22 lines
Quoted 8 lines

Greetings,
Luca

hp_accel.c line 206

Quoted 6 lines
hp_accel.c renamed from home/luca/Desktop/hp_accel.c +1 -0
@@ -201,6 +201,7 @@
 			PRODUCT_NAME, "HP Pavilion dv5",
 			BOARD_NAME, "3600",
 			y_inverted),
+    AXIS_DMI_MATCH("HP8710", "HP Compaq 8710", y_inverted),
 	{ NULL, }
 /* Laptop models witho

- changelog is a mess
- originator wasn't cc'ed
- originator's signed-off-by: is missing
- your signed-off-by: is missing
- patch isn't in `patch -p1' form
- patch is whitespace-mangled

Quoted 2 lines

I fixed some of that up. It'd be nice to get some Signed-off-by:s, please.

Sorry about the mess you had to clean up.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html