dm9000 locking bugfix
Subsystems (2)
PATCH 1/1 dm9000 locking bugfix
From: David Brownell <[email protected]>
This fixes a locking bug in the dm9000 driver. It calls request_irq() without setting IRQF_DISABLED ... which is correct for handlers that support IRQ sharing, since that behavior is not guaranteed for shared IRQs. However, its IRQ handler then wrongly assumes that IRQs are blocked. So the fix just uses the right spinlock primitives in the IRQ handler.
NOTE: this is a classic example of the type of bug which lockdep currently masks by forcibly setting IRQF_DISABLED on IRQ handlers that did not request that flag.
---
The annoying "watchdog timeouts" seem unrelated to this. But on at least one problem, enabling lockdep makes them go away ... good fun, eh?
drivers/net/dm9000.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/dm9000.c +4 -2
@@ -930,13 +930,15 @@ static irqreturn_t dm9000_interrupt(intstruct net_device *dev = dev_id;board_info_t *db =netdev_priv (dev);int int_status; +unsigned long flags;u8 reg_save;dm9000_dbg (db,3 ,"entering %s\n" , __func__);/* A real interrupt coming */ -spin_lock (&db->lock); +/* holders of db->lock must always block IRQs */ +spin_lock_irqsave (&db->lock, flags);/* Save previous register address */ reg_save =readb (db->io_addr);
@@ -972,7 +974,7 @@ static irqreturn_t dm9000_interrupt(int/* Restore previous register address */ writeb (reg_save, db->io_addr); -spin_unlock (&db->lock); +spin_unlock_irqrestore (&db->lock, flags);return IRQ_HANDLED ; }
From: David Brownell <[email protected]>
Date: Sun, 22 Mar 2009 16:12:12 -0700
Quoted 8 lines
This fixes a locking bug in the dm9000 driver. It calls
request_irq()without settingIRQF_DISABLED... which is correct for handlers that support IRQ sharing, since that behavior is not guaranteed for shared IRQs. However, its IRQ handler then wrongly assumes that IRQs are blocked. So the fix just uses the right spinlock primitives in the IRQ handler.
Quoted 5 lines
NOTE: this is a classic example of the type of bug which lockdep currently masks by forcibly setting
IRQF_DISABLEDon IRQ handlers that did not request that flag.Signed-off-by David Brownell <[email protected]>
Applied, thanks.