Skip to contentSkip to conversation

remove duplicate code

PATCH Applied Gleb Natapov 2 participants 2 messages Mar 22, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove duplicate code

svm_do_inject_vector() reimplements pop_irq().

arch/x86/kvm/svm.c +1 -9
index 1821c20..da23fd3 100644
@@ -2344,15 +2344,7 @@ static void kvm_reput_irq(struct vcpu_svm *svm)
 
 static void svm_do_inject_vector(struct vcpu_svm *svm)
 {
-	struct kvm_vcpu *vcpu = &svm->vcpu;
-	int word_index = __ffs(vcpu->arch.irq_summary);
-	int bit_index = __ffs(vcpu->arch.irq_pending[word_index]);
-	int irq = word_index * BITS_PER_LONG + bit_index;
-
-	clear_bit(bit_index, &vcpu->arch.irq_pending[word_index]);
-	if (!vcpu->arch.irq_pending[word_index])
-		clear_bit(word_index, &vcpu->arch.irq_summary);
-	svm_inject_irq(svm, irq);
+	svm_inject_irq(svm, pop_irq(&svm->vcpu));
 }
 
 static void do_interrupt_requests(struct kvm_vcpu *vcpu,

--
Gleb.

Applied
#1 lore raw
Quoted 2 lines · Gleb Natapov

svm_do_inject_vector() reimplements pop_irq().

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function