Skip to contentSkip to conversation

b43: fix b43_plcp_get_bitrate_idx_ofdm return type

PATCH New Michael Buesch 1 participant 1 message Mar 22, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: fix b43_plcp_get_bitrate_idx_ofdm return type

From: Lorenzo Nava <[email protected]>

This patch fixes the return type of b43_plcp_get_bitrate_idx_ofdm. If the plcp contains an error, the function return value is 255 instead of -1, and the packet was not dropped. This causes a warning in __ieee80211_rx function because rate idx is out of range.

---

John, please queue as a bugfix to the current kernel.

drivers/net/wireless/b43/xmit.c +1 -1
Index: wireless-testing/drivers/net/wireless/b43/xmit.c
===================================================================
@@ -50,7 +50,7 @@ static int b43_plcp_get_bitrate_idx_cck(
 }
 
 /* Extract the bitrate index out of an OFDM PLCP header. */
-static u8 b43_plcp_get_bitrate_idx_ofdm(struct b43_plcp_hdr6 *plcp, bool aphy)
+static int b43_plcp_get_bitrate_idx_ofdm(struct b43_plcp_hdr6 *plcp, bool aphy)
 {
 	int base = aphy ? 0 : 4;
 
Signature · 1 line
Greetings, Michael.