mptsas: remove unneeded check

PATCH New Alan Cox 1 participant 1 message Mar 23, 2009

Subsystems (2)

SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)

lore

Share & tools

lore

Alan Cox

author

2009-03-23 10:45 UTC #0 lore raw

PATCH 1/1 mptsas: remove unneeded check

From: Alan Cox <[email protected]>

Quoted 1 line

From coverity checker. Closes #9675

(This is a resend. This was discussed before, shown to be a bogus check and
then the change never got applied - hence the origin of the diff being Red Hat)

Signed-off-by Alan Cox <[email protected]>

---

 drivers/message/fusion/mptsas.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

drivers/message/fusion/mptsas.c +2 -3

index 12b7325..a9019f0 100644
@@ -2279,9 +2279,8 @@ mptsas_delete_expander_phys(MPT_ADAPTER *ioc)
 	mutex_lock(&ioc->sas_topology_mutex);
 	list_for_each_entry_safe(port_info, n, &ioc->sas_topology, list) {
 
-		if (port_info->phy_info &&
-		    (!(port_info->phy_info[0].identify.device_info &
-		    MPI_SAS_DEVICE_INFO_SMP_TARGET)))
+		if (!(port_info->phy_info[0].identify.device_info &
+		    MPI_SAS_DEVICE_INFO_SMP_TARGET))
 			continue;
 
 		if (mptsas_sas_expander_pg0(ioc, &buffer,