Fix monitor command (screendump)
PATCH 1/1 Fix monitor command (screendump)
Hello,
starting with r6839, the monitor command 'screendump' raises a nullpointer memory access which crashs Qemu.
My patch fixes this for trunk and for the stable branch.
Regards
Stefan
PS. There are a lot of unapplied patches (not only from me) which really should be applied to trunk. Much time and efforts are wasted for maintaining local patch trees, some fixes are sent 3 times by different people. How can we improve this insatisfying situation?
Fix crash when calling screendump from monitor.
This was a regression introduced with r6839:
DisplayAllocator interface (Stefano Stabellini)
hw/vga.c +1 -0
@@ -2637,6 +2637,7 @@ dcl.dpy_resize = vga_save_dpy_resize; dcl.dpy_refresh = vga_save_dpy_refresh;register_displaychangelistener (ds, &dcl); + ds->allocator = &default_allocator; ds->surface =qemu_create_displaysurface (ds, w, h); s->ds = ds;
Quoted 7 lines · Stefan Weil
Hello,
starting with r6839, the monitor command 'screendump' raises a nullpointer memory access which crashs Qemu.
My patch fixes this for trunk and for the stable branch.
r6839 is not in stable so the patch isn't needed for stable.
Quoted 10 lines
Regards
Stefan
PS. There are a lot of unapplied patches (not only from me) which really should be applied to trunk. Much time and efforts are wasted for maintaining local patch trees, some fixes are sent 3 times by different people. How can we improve this insatisfying situation?
What are the unapplied patches? I have about 30 patches in my queue. Even the oldest (which had comments so I'll probably drop from my queue) are less than 2 weeks old. I don't have any unapplied patches from you in my queue.
There are certain subsystems that do not have an active maintainer right now. Really there is no solution for this without something stepping up to active maintain those subsystems. That basically requires someone devoting some time to maintaining a queue for that subsystem.
Regards,
Anthony Liguori
Quoted 4 lines
Quoted 22 lines · Stefan Weil
Hello,
starting with r6839, the monitor command 'screendump' raises a nullpointer memory access which crashs Qemu.
My patch fixes this for trunk and for the stable branch.
Regards
Stefan
PS. There are a lot of unapplied patches (not only from me) which really should be applied to trunk. Much time and efforts are wasted for maintaining local patch trees, some fixes are sent 3 times by different people. How can we improve this insatisfying situation?
Quoted 6 lines
Fix crash when calling screendump from monitor.
This was a regression introduced with r6839:
DisplayAllocator interface (Stefano Stabellini)Signed-off-by Stefan Weil <[email protected]>
Quoted 13 lines
Index:
trunk/hw/vga.c
===================================================================hw/vga.c +1
-0@@ -2637,6 +2637,7 @@ dcl.dpy_resize = vga_save_dpy_resize; dcl.dpy_refresh = vga_save_dpy_refresh;register_displaychangelistener (ds, &dcl); + ds->allocator = &default_allocator; ds->surface =qemu_create_displaysurface (ds, w, h); s->ds = ds;
Signature · 4 lines
Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx [email protected]
Quoted 7 lines · Stefan Weil
Hello,
starting with r6839, the monitor command 'screendump' raises a nullpointer memory access which crashs Qemu.
My patch fixes this for trunk and for the stable branch.
Anthony Liguori
AppliedQuoted 7 lines · Stefan Weil
Hello,
starting with r6839, the monitor command 'screendump' raises a nullpointer memory access which crashs Qemu.
My patch fixes this for trunk and for the stable branch.
Applied to trunk. Stable doesn't have the DisplayAllocator interface so this bug isn't present there.
Regards,
Anthony Liguori
Quoted 7 lines
Regards
Stefan