Skip to contentSkip to conversation

DM Exception Store: populate cache on commit

PATCH New Jonathan Brassow 1 participant 1 message Mar 25, 2009 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DM Exception Store: populate cache on commit

Patch name: dm-exception-store-populate-cache-on-commit.patch

The 'resume' exception store function is now in place to load the exception store type's caches on startup. However, we still need to continue to populate the caches as new exceptions are committed. This patch takes care of that.

drivers/md/dm-snap-persistent.c +9 -0
Index: linux-2.6/drivers/md/dm-snap-persistent.c
===================================================================
@@ -665,6 +665,15 @@ static void persistent_commit_exception(
 	write_exception(ps, ps->current_committed++, &de);
 
 	/*
+	 * We are safe to add the exception to our cache before we
+	 * issue the callbacks.  If we fail to allocate the memory
+	 * to put it in the cache though, the callbacks will have to
+	 * report the failure.
+	 */
+	if (add_exception(store, de.old_chunk, de.new_chunk))
+		ps->valid = 0;
+
+	/*
 	 * Add the callback to the back of the array.  This code
 	 * is the only place where the callback array is
 	 * manipulated, and we know that it will never be called
drivers/md/dm-snap-transient.c +14 -1
Index: linux-2.6/drivers/md/dm-snap-transient.c
===================================================================
@@ -77,7 +77,20 @@ static void transient_commit_exception(s
 				       void (*callback) (void *, int success),
 				       void *callback_context)
 {
-	/* Just succeed */
+	struct transient_c *tc = store->context;
+	struct dm_exception *new;
+
+	new = dm_alloc_exception(tc->table);
+	if (!new) {
+		callback(callback_context, 0);
+		return;
+	}
+
+	new->old_chunk = e->old_chunk;
+	new->new_chunk = e->new_chunk;
+
+	dm_insert_exception(tc->table, new);
+
 	callback(callback_context, 1);
 }