Skip to contentSkip to conversation

DM Exception Store: remove read_metadata from API

PATCH New Jonathan Brassow 1 participant 1 message Mar 25, 2009 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DM Exception Store: remove read_metadata from API

Patch name: dm-exception-store-remove-read_metadata-from-API.patch

Rip out crappy 'read_metadata' function from the exception store API. It is no longer needed, since the exception stores are now responsible for caching exceptions.

drivers/md/dm-exception-store.h +0 -10
Index: linux-2.6/drivers/md/dm-exception-store.h
===================================================================
@@ -34,16 +34,6 @@ struct dm_exception_store_type {
 	int (*resume) (struct dm_exception_store *store);
 
 	/*
-	 * The target shouldn't read the COW device until this is
-	 * called.  As exceptions are read from the COW, they are
-	 * reported back via the callback.
-	 */
-	int (*read_metadata) (struct dm_exception_store *store,
-			      int (*callback)(void *callback_context,
-					      chunk_t old, chunk_t new),
-			      void *callback_context);
-
-	/*
 	 * Find somewhere to store the next exception.
 	 */
 	int (*prepare_exception) (struct dm_exception_store *store,
drivers/md/dm-snap-persistent.c +42 -60

175 lines not on this page · raw message

drivers/md/dm-snap-transient.c +0 -10
Index: linux-2.6/drivers/md/dm-snap-transient.c
===================================================================
@@ -44,14 +44,6 @@ static void transient_dtr(struct dm_exce
 	kfree(tc);
 }
 
-static int transient_read_metadata(struct dm_exception_store *store,
-				   int (*callback)(void *callback_context,
-						   chunk_t old, chunk_t new),
-				   void *callback_context)
-{
-	return 0;
-}
-
 static int transient_resume(struct dm_exception_store *store)
 {
 	return 0;
@@ -179,7 +171,6 @@ static struct dm_exception_store_type _t
 	.ctr = transient_ctr,
 	.dtr = transient_dtr,
 	.resume = transient_resume,
-	.read_metadata = transient_read_metadata,
 	.prepare_exception = transient_prepare_exception,
 	.commit_exception = transient_commit_exception,
 	.lookup_exception = transient_lookup_exception,
@@ -193,7 +184,6 @@ static struct dm_exception_store_type _t
 	.ctr = transient_ctr,
 	.dtr = transient_dtr,
 	.resume = transient_resume,
-	.read_metadata = transient_read_metadata,
 	.prepare_exception = transient_prepare_exception,
 	.commit_exception = transient_commit_exception,
 	.lookup_exception = transient_lookup_exception,