Skip to contentSkip to conversation

xend: Allow user to specify vslots 0 - 1f for static pass-through

PATCH New Simon Horman 1 participant 1 message Mar 25, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xend: Allow user to specify vslots 0 - 1f for static pass-through

The current parser only accepts vslots 0 - f (hex), that is, only slots that have one digit. This is an omission as two digit slots with a leading 0 or 1 are also valid, representing the full range of slots 0 - 1f.

Thanks to Dexuan Cui for spotting this problem.

tools/python/xen/xm/create.py +1 -1
Index: xen-unstable.hg/tools/python/xen/xm/create.py
===================================================================
@@ -1057,7 +1057,7 @@ def preprocess_pci(vals):
                 r"(?P<bus>[0-9a-fA-F]{1,2})[:,]" + \
                 r"(?P<slot>[0-9a-fA-F]{1,2})[.,]" + \
                 r"(?P<func>[0-7])" + \
-                r"(@(?P<vslot>[0-9a-fA-F]))?" + \
+                r"(@(?P<vslot>[01]?[0-9a-fA-F]))?" + \
                 r"(,(?P<opts>.*))?$", \
                 pci_dev_str)
         if pci_match!=None: