Skip to contentSkip to conversation

firedtv: wrong types in printk

PATCH In review Alan Cox 2 participants 2 messages Mar 26, 2009 – Mar 27, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 firedtv: wrong types in printk

size_t is not int...

---

 drivers/media/dvb/firewire/firedtv-avc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/dvb/firewire/firedtv-avc.c +1 -1
index b55d9cc..424ed5d 100644
@@ -150,7 +150,7 @@ static void debug_fcp(const u8 *data, size_t length)
 		subunit_type = data[1] >> 3;
 		subunit_id = data[1] & 7;
 		op = subunit_type == 0x1e || subunit_id == 5 ? ~0 : data[2];
-		printk(KERN_INFO "%ssu=%x.%x l=%d: %-8s - %s\n",
+		printk(KERN_INFO "%ssu=%x.%x l=%Zd: %-8s - %s\n",
 		       prefix, subunit_type, subunit_id, length,
 		       debug_fcp_ctype(data[0]),
 		       debug_fcp_opcode(op, data, length));
#1 lore raw

drivers/media/dvb/firewire/firedtv-avc.c static void debug_fcp(const u8 *data, size_t length) · line 156

Quoted 11 lines · Alan Cox
drivers/media/dvb/firewire/firedtv-avc.c +1 -1
@@ -150,7 +150,7 @@ static void debug_fcp(const u8 *data, size_t length)
 		subunit_type = data[1] >> 3;
 		subunit_id = data[1] & 7;
 		op = subunit_type == 0x1e || subunit_id == 5 ? ~0 : data[2];
-		printk(KERN_INFO "%ssu=%x.%x l=%d: %-8s - %s\n",
+		printk(KERN_INFO "%ssu=%x.%x l=%Zd: %-8s - %s\n",
 		       prefix, subunit_type, subunit_id, length,
 		       debug_fcp_ctype(data[0]),
 		       debug_fcp_opcode(op, data, length));

This is already fixed in -next via linux1394-2.6.git. (1394 git pull request follows later today.)

Signature · 3 lines
Stefan Richter
-=====-==--= --== ==-==
http://arcgraph.de/sr/