Skip to contentSkip to conversation

MPC85xx: Add MPC8569 CPU support

PATCH Superseded Haiying Wang 3 participants 6 messages Mar 26, 2009 – Mar 27, 2009

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 MPC85xx: Add MPC8569 CPU support

There is a workaround for MPC8569 CPU Errata, which needs to set Bit 13 of LBCR in 4K bootpage. We setup a temp TLB for eLBC controller in bootpage, then invalidate it after LBCR bit 13 is set.

---
 cpu/mpc85xx/Makefile         |    1 +
 cpu/mpc85xx/cpu.c            |    2 +
 cpu/mpc85xx/start.S          |   47 ++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/fsl_law.c       |    2 +-
 include/asm-ppc/immap_85xx.h |    9 +++++++-
 include/asm-ppc/immap_qe.h   |    8 ++++--
 include/asm-ppc/processor.h  |    2 +
 7 files changed, 66 insertions(+), 5 deletions(-)
cpu/mpc85xx/Makefile +1 -0
index 99d88a8..8809302 100644
@@ -49,6 +49,7 @@ COBJS-$(CONFIG_MPC8544) += ddr-gen2.o
 COBJS-$(CONFIG_MPC8572) += ddr-gen3.o
 COBJS-$(CONFIG_MPC8536) += ddr-gen3.o
 COBJS-$(CONFIG_P2020)	+= ddr-gen3.o
+COBJS-$(CONFIG_MPC8569)	+= ddr-gen3.o
 
 COBJS-$(CONFIG_MPC8536) += mpc8536_serdes.o
 COBJS	= traps.o cpu.o cpu_init.o speed.o interrupts.o tlb.o \
cpu/mpc85xx/cpu.c +2 -0
index 5b72fe5..ef976a4 100644
@@ -61,6 +61,8 @@ struct cpu_type cpu_type_list [] = {
 	CPU_TYPE_ENTRY(8567, 8567_E),
 	CPU_TYPE_ENTRY(8568, 8568),
 	CPU_TYPE_ENTRY(8568, 8568_E),
+	CPU_TYPE_ENTRY(8569, 8569),
+	CPU_TYPE_ENTRY(8569, 8569_E),
 	CPU_TYPE_ENTRY(8572, 8572),
 	CPU_TYPE_ENTRY(8572, 8572_E),
 	CPU_TYPE_ENTRY(P2020, P2020),
cpu/mpc85xx/start.S +47 -0

53 lines not on this page · raw message

drivers/misc/fsl_law.c +1 -1
index 58340c1..be43a3e 100644
@@ -35,7 +35,7 @@ DECLARE_GLOBAL_DATA_PTR;
     defined(CONFIG_MPC8560) || defined(CONFIG_MPC8555)
 #define FSL_HW_NUM_LAWS 8
 #elif defined(CONFIG_MPC8548) || defined(CONFIG_MPC8544) || \
-      defined(CONFIG_MPC8568) || \
+      defined(CONFIG_MPC8568) || defined(CONFIG_MPC8569) || \
       defined(CONFIG_MPC8641) || defined(CONFIG_MPC8610)
 #define FSL_HW_NUM_LAWS 10
 #elif defined(CONFIG_MPC8536) || defined(CONFIG_MPC8572) || \
include/asm-ppc/immap_85xx.h +8 -1
index 094fb9c..de78dda 100644
@@ -1609,8 +1609,15 @@ typedef struct ccsr_gur {
 	char	res2[12];
 	uint	gpiocr;		/* 0xe0030 - GPIO control register */
 	char	res3[12];
+#if defined(CONFIG_MPC8569)
+	uint	plppar1;	/* 0xe0040 - Platform port pin assignment register 1 */
+	uint	plppar2;	/* 0xe0044 - Platform port pin assignment register 2 */
+	uint	plpdir1;	/* 0xe0048 - Platform port pin direction register 1 */
+	uint	plpdir2;	/* 0xe004c - Platform port pin direction register 2 */
+#else
 	uint	gpoutdr;	/* 0xe0040 - General-purpose output data register */
 	char	res4[12];
+#endif
 	uint	gpindr;		/* 0xe0050 - General-purpose input data register */
 	char	res5[12];
 	uint	pmuxcr;		/* 0xe0060 - Alternate function signal multiplex control */
@@ -1651,7 +1658,7 @@ typedef struct ccsr_gur {
 	uint	svr;		/* 0xe00a4 - System version register */
 	char	res10a[8];
 	uint	rstcr;		/* 0xe00b0 - Reset control register */
-#ifdef CONFIG_MPC8568
+#if defined(CONFIG_MPC8568)||defined(CONFIG_MPC8569)
 	char	res10b[76];
 	par_io_t qe_par_io[7];  /* 0xe0100 - 0xe01bf */
 	char	res10c[3136];
include/asm-ppc/immap_qe.h +5 -3
index 39da377..66a4735 100644
@@ -20,7 +20,9 @@
 typedef struct qe_iram {
 	u32 iadd;		/* I-RAM Address Register */
 	u32 idata;		/* I-RAM Data Register    */
-	u8 res0[0x78];
+	u8 res0[0x4];
+	u32 iready;
+	u8 res1[0x70];
 } __attribute__ ((packed)) qe_iram_t;
 
 /* QE Interrupt Controller
@@ -580,7 +582,7 @@ typedef struct qe_immap {
 	u8 res14[0x300];
 	u8 res15[0x3A00];
 	u8 res16[0x8000];	/* 0x108000 -  0x110000 */
-#if defined(CONFIG_MPC8568)
+#if defined(CONFIG_MPC8568)||defined(CONFIG_MPC8569)
 	u8 muram[0x10000];	/* 0x1_0000 -  0x2_0000 Multi-user RAM */
 	u8 res17[0x20000];	/* 0x2_0000 -  0x4_0000 */
 #else
@@ -592,7 +594,7 @@ typedef struct qe_immap {
 
 extern qe_map_t *qe_immr;
 
-#if defined(CONFIG_MPC8568)
+#if defined(CONFIG_MPC8568) || defined(CONFIG_MPC8569)
 #define QE_MURAM_SIZE		0x10000UL
 #elif defined(CONFIG_MPC8360)
 #define QE_MURAM_SIZE		0xc000UL
include/asm-ppc/processor.h +2 -0
index 5b29de0..83e3581 100644
@@ -955,6 +955,8 @@
 #define SVR_8567_E	0x807E00
 #define SVR_8568	0x807500
 #define SVR_8568_E	0x807D00
+#define SVR_8569	0x808000
+#define SVR_8569_E	0x808800
 #define SVR_8572	0x80E000
 #define SVR_8572_E	0x80E800
 #define SVR_P2020	0x80E200
Signature · 1 line
1.6.0.2
#1 lore raw

PATCH 2/3 MPC85xx: Load and enable QE microcode patch in IRAM

For the silicon which doesn't have ROM support in QE, it always needs to load a pre-built ucode binary to IRAM so that QE can work.

---
 drivers/qe/qe.c |    9 +++++++++
 drivers/qe/qe.h |    1 +
 2 files changed, 10 insertions(+), 0 deletions(-)
drivers/qe/qe.c +9 -0
index e90a4a5..ea5a14b 100644
@@ -161,6 +161,15 @@ void qe_init(uint qe_base)
 	/* Init the QE IMMR base */
 	qe_immr = (qe_map_t *)qe_base;
 
+#ifdef CONFIG_SYS_QE_FW_ADDR
+        /* Upload microcode to IRAM for those SOCs which do not have ROM in QE.
+         */
+        qe_upload_firmware((const struct qe_firmware *) CONFIG_SYS_QE_FW_ADDR);
+
+        /* enable the microcode in IRAM */
+        out_be32(&qe_immr->iram.iready,QE_IRAM_READY);
+#endif
+
 	gd->mp_alloc_base = QE_DATAONLY_BASE;
 	gd->mp_alloc_top = gd->mp_alloc_base + QE_DATAONLY_SIZE;
 
drivers/qe/qe.h +1 -0
index a55555f..d78edba 100644
@@ -230,6 +230,7 @@ typedef enum qe_clock {
 /* I-RAM */
 #define QE_IRAM_IADD_AIE	0x80000000	/* Auto Increment Enable */
 #define QE_IRAM_IADD_BADDR	0x00080000	/* Base Address */
+#define QE_IRAM_READY		0x80000000
 
 /* Structure that defines QE firmware binary files.
  *
Signature · 1 line
1.6.0.2
#2 lore raw

PATCH 3/3 MPC85xx: Add MPC8569MDS board support

This patch adds MPC8569MDS board support. The UART, QE UEC1 and UEC2, BRD EEPROM on I2C2 bus, PCI express and DDR3 SPD are supported in this patch.

---
 MAKEALL                                 |    1 +
 Makefile                                |    3 +
 board/freescale/mpc8569mds/Makefile     |   55 ++++
 board/freescale/mpc8569mds/bcsr.c       |   49 ++++
 board/freescale/mpc8569mds/bcsr.h       |   82 ++++++
 board/freescale/mpc8569mds/config.mk    |   30 ++
 board/freescale/mpc8569mds/ddr.c        |   86 ++++++
 board/freescale/mpc8569mds/law.c        |   59 ++++
 board/freescale/mpc8569mds/mpc8569mds.c |  325 ++++++++++++++++++++++
 board/freescale/mpc8569mds/tlb.c        |  100 +++++++
 board/freescale/mpc8569mds/u-boot.lds   |  143 ++++++++++
 include/configs/MPC8569MDS.h            |  455 +++++++++++++++++++++++++++++++
 12 files changed, 1388 insertions(+), 0 deletions(-)
 create mode 100644 board/freescale/mpc8569mds/Makefile
 create mode 100644 board/freescale/mpc8569mds/bcsr.c
 create mode 100644 board/freescale/mpc8569mds/bcsr.h
 create mode 100644 board/freescale/mpc8569mds/config.mk
 create mode 100644 board/freescale/mpc8569mds/ddr.c
 create mode 100644 board/freescale/mpc8569mds/law.c
 create mode 100644 board/freescale/mpc8569mds/mpc8569mds.c
 create mode 100644 board/freescale/mpc8569mds/tlb.c
 create mode 100644 board/freescale/mpc8569mds/u-boot.lds
 create mode 100644 include/configs/MPC8569MDS.h
MAKEALL +1 -0
index ed9e5ed..7b12d90 100755
@@ -375,6 +375,7 @@ LIST_85xx="		\
 	MPC8555CDS	\
 	MPC8560ADS	\
 	MPC8568MDS	\
+	MPC8569MDS	\
 	MPC8572DS	\
 	MPC8572DS_36BIT	\
 	PM854		\
Makefile +3 -0
index 61bae6d..16f5c4e 100644
@@ -2422,6 +2422,9 @@ MPC8555CDS_config:	unconfig
 MPC8568MDS_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8568mds freescale
 
+MPC8569MDS_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) ppc mpc85xx mpc8569mds freescale
+
 MPC8572DS_36BIT_config \
 MPC8572DS_config:       unconfig
 	@mkdir -p $(obj)include
board/freescale/mpc8569mds/Makefile new file +55 -0

55 lines not on this page · raw message

board/freescale/mpc8569mds/bcsr.c new file +49 -0

49 lines not on this page · raw message

board/freescale/mpc8569mds/bcsr.h new file +82 -0

82 lines not on this page · raw message

board/freescale/mpc8569mds/config.mk new file +30 -0
new file mode 100644
index 0000000..36b344e
@@ -0,0 +1,30 @@
+#
+# Copyright (C) 2009 Freescale Semiconductor, Inc. All rights reserved.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+#
+# mpc8569mds board
+#
+TEXT_BASE = 0xfff80000
+
+PLATFORM_CPPFLAGS += -DCONFIG_E500=1
+PLATFORM_CPPFLAGS += -DCONFIG_MPC85xx=1
+PLATFORM_CPPFLAGS += -DCONFIG_MPC8569=1
board/freescale/mpc8569mds/ddr.c new file +86 -0

86 lines not on this page · raw message

board/freescale/mpc8569mds/law.c new file +59 -0

59 lines not on this page · raw message

board/freescale/mpc8569mds/mpc8569mds.c new file +325 -0

325 lines not on this page · raw message

board/freescale/mpc8569mds/tlb.c new file +100 -0

100 lines not on this page · raw message

board/freescale/mpc8569mds/u-boot.lds new file +143 -0

143 lines not on this page · raw message

include/configs/MPC8569MDS.h new file +455 -0

455 lines not on this page · raw message

Signature · 1 line
1.6.0.2
#3 lore raw

PATCH 3/3 MPC85xx: Add MPC8569MDS board support

Dear Haiying Wang,

Quoted 35 lines
board/freescale/mpc8569mds/ddr.c new file +29 -0
new file mode 100644
index 0000000..c4e63fb
@@ -0,0 +1,86 @@
+/*
+ * Copyright 2009 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * Version 2 as published by the Free Software Foundation.
+ */
+
+#include <common.h>
+#include <i2c.h>
+
+#include <asm/fsl_ddr_sdram.h>
+#include <asm/fsl_ddr_dimm_params.h>
+
+static void
+get_spd(ddr3_spd_eeprom_t *spd, unsigned char i2c_address)
+{
+	i2c_read(i2c_address, 0, 1, (uchar *)spd, sizeof(ddr3_spd_eeprom_t));
+}
+
+
+unsigned int fsl_ddr_get_mem_data_rate(void)
+{
+	return get_ddr_freq(0);
+}
+
+void fsl_ddr_get_spd(ddr3_spd_eeprom_t *ctrl_dimms_spd,
+		      unsigned int ctrl_num)
+{

board/freescale/mpc8569mds/ddr.c line 39

Quoted 10 lines
board/freescale/mpc8569mds/ddr.c new file +10 -0
+	unsigned int i;
+	unsigned int i2c_address = 0;
+
+	for (i = 0; i < CONFIG_DIMM_SLOTS_PER_CTLR; i++) {
+		if (ctrl_num == 0 && i == 0) {
+			i2c_address = SPD_EEPROM_ADDRESS1;
+		}
+		if (ctrl_num == 0 && i == 1) {
+			i2c_address = SPD_EEPROM_ADDRESS2;
+		}

No curly braces for single line statements, please.

Quoted 6 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +0 -0
new file mode 100644
index 0000000..1022724
@@ -0,0 +1,325 @@

...

board/freescale/mpc8569mds/mpc8569mds.c line 127

Quoted 9 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +9 -0
+phys_size_t
+initdram(int board_type)
+{
+	long dram_size = 0;
+
+	puts("Initializing\n");
+
+#if defined(CONFIG_DDR_DLL)
+	{

Please avoid this extra block here.

board/freescale/mpc8569mds/mpc8569mds.c line 135

Quoted 8 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +8 -0
+		/*
+		 * Work around to stabilize DDR DLL MSYNC_IN.
+		 * Errata DDR9 seems to have been fixed.
+		 * This is now the workaround for Errata DDR11:
+		 *    Override DLL = 1, Course Adj = 1, Tap Select = 0
+		 */
+
+		volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);

Line too long.

board/freescale/mpc8569mds/mpc8569mds.c line 147

Quoted 12 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +12 -0
+
+		gur->ddrdllcr = 0x81000000;
+		asm("sync;isync;msync");
+		udelay(200);
+	}
+#endif
+
+#ifdef CONFIG_SPD_EEPROM
+	dram_size = fsl_ddr_sdram();
+#else
+        dram_size = fixed_sdram();
+#endif

Indentation not by TAB.

Quoted 28 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +28 -0
+
+	dram_size = setup_ddr_tlbs(dram_size / 0x100000);
+	dram_size *= 0x100000;
+
+	puts("    DDR: ");
+	return dram_size;
+}
+
+#if !defined(CONFIG_SPD_EEPROM)
+phys_size_t fixed_sdram(void)
+{
+	volatile ccsr_ddr_t *ddr = (ccsr_ddr_t *)CONFIG_SYS_MPC85xx_DDR_ADDR;
+	uint d_init;
+
+	ddr->cs0_bnds = CONFIG_SYS_DDR_CS0_BNDS;
+	ddr->cs0_config = CONFIG_SYS_DDR_CS0_CONFIG;
+	ddr->timing_cfg_3 = CONFIG_SYS_DDR_TIMING_3;
+	ddr->timing_cfg_0 = CONFIG_SYS_DDR_TIMING_0;
+	ddr->timing_cfg_1 = CONFIG_SYS_DDR_TIMING_1;
+	ddr->timing_cfg_2 = CONFIG_SYS_DDR_TIMING_2;
+	ddr->sdram_cfg = CONFIG_SYS_DDR_SDRAM_CFG;
+	ddr->sdram_cfg_2 = CONFIG_SYS_DDR_SDRAM_CFG_2;
+	ddr->sdram_mode = CONFIG_SYS_DDR_SDRAM_MODE;
+	ddr->sdram_mode_2 = CONFIG_SYS_DDR_SDRAM_MODE_2;
+	ddr->sdram_interval = CONFIG_SYS_DDR_SDRAM_INTERVAL;
+	ddr->sdram_data_init = CONFIG_SYS_DDR_DATA_INIT;
+	ddr->sdram_clk_cntl = CONFIG_SYS_DDR_SDRAM_CLK_CNTL;
+	ddr->timing_cfg_4 = CONFIG_SYS_DDR_TIMING_4;

board/freescale/mpc8569mds/mpc8569mds.c line 185

Quoted 10 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +10 -0
+	ddr->timing_cfg_5 = CONFIG_SYS_DDR_TIMING_5;
+	ddr->ddr_zq_cntl =  CONFIG_SYS_DDR_ZQ_CNTL;
+	ddr->ddr_wrlvl_cntl = CONFIG_SYS_DDR_WRLVL_CNTL;
+	ddr->sdram_cfg_2 = CONFIG_SYS_DDR_SDRAM_CFG_2;
+#if defined (CONFIG_DDR_ECC)
+	ddr->err_int_en = CONFIG_SYS_DDR_ERR_INT_EN;
+	ddr->err_disable = CONFIG_SYS_DDR_ERR_DIS;
+	ddr->err_sbe = CONFIG_SYS_DDR_SBE;
+#endif
+	asm("sync;isync");

Please use accessor functions for register accesses (here and averywhere). This will probably allow you to get rid of the "sync;isync", too.

Quoted 8 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +8 -0
+	udelay(500);
+
+	ddr->sdram_cfg = CONFIG_SYS_DDR_CONTROL;
+#if defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)
+	d_init = 1;
+	debug("DDR - 1st controller: memory initializing\n");
+	/*
+	 * Poll until memory is initialized.

board/freescale/mpc8569mds/mpc8569mds.c line 204

Quoted 10 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +10 -0
+	 * 512 Meg at 400 might hit this 200 times or so.
+	 */
+	while ((ddr->sdram_cfg_2 & (d_init << 4)) != 0) {
+		udelay(1000);
+	}
+	debug("DDR: memory initialized\n\n");
+	asm("sync; isync");
+	udelay(500);
+#endif
+	return 1024 * 1024 * 1024;

Why is no auto-sizing being used here?

Quoted 11 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +11 -0
+}
+#endif
+
+/*
+ * Initialize Local Bus
+ */
+void
+local_bus_init(void)
+{
+	volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
+	volatile ccsr_lbc_t *lbc = (void *)(CONFIG_SYS_MPC85xx_LBC_ADDR);

board/freescale/mpc8569mds/mpc8569mds.c line 225

Quoted 10 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +10 -0
+
+	uint clkdiv;
+	uint lbc_hz;
+	sys_info_t sysinfo;
+
+	get_sys_info(&sysinfo);
+	clkdiv = (lbc->lcrr & LCRR_CLKDIV) * 2;
+	lbc_hz = sysinfo.freqSystemBus / 1000000 / clkdiv;
+
+	gur->lbiuiplldcr1 = 0x00078080;

Please use accessor functions, see above.

board/freescale/mpc8569mds/mpc8569mds.c line 232

Quoted 7 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +7 -0
+	if (clkdiv == 16) {
+		gur->lbiuiplldcr0 = 0x7c0f1bf0;
+	} else if (clkdiv == 8) {
+		gur->lbiuiplldcr0 = 0x6c0f1bf0;
+	} else if (clkdiv == 4) {
+		gur->lbiuiplldcr0 = 0x5c0f1bf0;
+	}

No braces here.

...

Quoted 4 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +4 -0
+pci_init_board(void)
+{
+	volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
+	uint io_sel = (gur->pordevsr & MPC85xx_PORDEVSR_IO_SEL) >> 19;

board/freescale/mpc8569mds/mpc8569mds.c line 263

Quoted 10 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +10 -0
+	uint host_agent = (gur->porbmsr & MPC85xx_PORBMSR_HA) >> 16;
+
+#ifdef CONFIG_PCIE1
+{
+	volatile ccsr_fsl_pci_t *pci = (ccsr_fsl_pci_t *) CONFIG_SYS_PCIE1_ADDR;
+	struct pci_controller *hose = &pcie1_hose;
+	int pcie_ep =  (host_agent == 0) || (host_agent == 2 ) || (host_agent == 3);
+	struct pci_region *r = hose->regions;
+
+	int pcie_configured  = io_sel >= 1;

Please separate declarations and code. Its is more or less unreadable. Also, lines are too long.

board/freescale/mpc8569mds/mpc8569mds.c line 272

Quoted 8 lines
board/freescale/mpc8569mds/mpc8569mds.c new file +8 -0
+	if (pcie_configured && !(gur->devdisr & MPC85xx_DEVDISR_PCIE)){
+		printf ("\n    PCIE connected to slot as %s (base address %x)",
+			pcie_ep ? "End Point" : "Root Complex",
+			(uint)pci);
+
+		if (pci->pme_msg_det) {
+			pci->pme_msg_det = 0xffffffff;
+			debug (" with errors.  Clearing.  Now 0x%08x",pci->pme_msg_det);

Line too long. Check all files, please.

...

Quoted 6 lines
include/configs/MPC8569MDS.h new file +0 -0
new file mode 100644
index 0000000..a759e05
@@ -0,0 +1,455 @@

...

include/configs/MPC8569MDS.h line 58

Quoted 5 lines
include/configs/MPC8569MDS.h new file +5 -0
+#ifndef __ASSEMBLY__
+extern unsigned long get_clock_freq(void);
+#endif						  /*Replace a call to get_clock_freq (after it is implemented)*/
+#define CONFIG_SYS_CLK_FREQ	66000000 /*TODO: restore if wanting to read from BCSR: get_clock_freq()*/ /* sysclk for MPC85xx */
+#define CONFIG_DDR_CLK_FREQ	66000000

Line lenght!!!

Quoted 16 lines
include/configs/MPC8569MDS.h new file +16 -0
+#define	CONFIG_EXTRA_ENV_SETTINGS				        \
+   "netdev=eth0\0"                                                      \
+   "consoledev=ttyS0\0"                                                 \
+   "ramdiskaddr=600000\0"                                               \
+   "ramdiskfile=your.ramdisk.u-boot\0"					\
+   "fdtaddr=400000\0"							\
+   "fdtfile=your.fdt.dtb\0"						\
+   "nfsargs=setenv bootargs root=/dev/nfs rw "				\
+      "nfsroot=$serverip:$rootpath "					\
+      "ip=$ipaddr:$serverip:$gatewayip:$netmask:$hostname:$netdev:off " \
+      "console=$consoledev,$baudrate $othbootargs\0"			\
+   "ramargs=setenv bootargs root=/dev/ram rw "				\
+      "console=$consoledev,$baudrate $othbootargs\0"			\
+
+#define CONFIG_NFSBOOTCOMMAND	                                        \
+   "run nfsargs;"							\

include/configs/MPC8569MDS.h line 451

Quoted 10 lines
include/configs/MPC8569MDS.h new file +10 -0
+   "tftp $loadaddr $bootfile;"                                          \
+   "tftp $fdtaddr $fdtfile;"						\
+   "bootm $loadaddr - $fdtaddr"
+
+
+#define CONFIG_RAMBOOTCOMMAND \
+   "run ramargs;"							\
+   "tftp $ramdiskaddr $ramdiskfile;"                                    \
+   "tftp $loadaddr $bootfile;"                                          \
+   "bootm $loadaddr $ramdiskaddr"

Indentation by TAB, please.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When the ax entered the forest, the trees said, "The handle is one of
us!"                                               -- Turkish proverb
#4 lore raw

PATCH 2/3 MPC85xx: Load and enable QE microcode patch in IRAM

In reply to Haiying Wang
Quoted 5 lines · Haiying Wang

For the silicon which doesn't have ROM support in QE, it always needs to load a pre-built ucode binary to IRAM so that QE can work.

Just for the record:

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#5 lore raw

PATCH 1/3 MPC85xx: Add MPC8569 CPU support

In reply to Haiying Wang

Dear Haiying Wang,

Quoted 5 lines · In message <[email protected]> you wrote:

There is a workaround for MPC8569 CPU Errata, which needs to set Bit 13 of LBCR in 4K bootpage. We setup a temp TLB for eLBC controller in bootpage, then invalidate it after LBCR bit 13 is set.

...

Quoted 2 lines
cpu/mpc85xx/start.S +0 -0

...

cpu/mpc85xx/start.S _start_e500: · line 207

Quoted 8 lines
cpu/mpc85xx/start.S +8 -0
+	lis     r7,FSL_BOOKE_MAS1(1, 0, 0, 0, BOOKE_PAGESZ_4K)@h
+	ori     r7,r7,FSL_BOOKE_MAS1(1, 0, 0, 0, BOOKE_PAGESZ_4K)@l
+
+	lis     r8,FSL_BOOKE_MAS2(CONFIG_SYS_LBC_ADDR, MAS2_I|MAS2_G)@h
+	ori     r8,r8,FSL_BOOKE_MAS2(CONFIG_SYS_LBC_ADDR, MAS2_I|MAS2_G)@l
+
+	lis     r9,FSL_BOOKE_MAS3(CONFIG_SYS_LBC_ADDR, 0, (MAS3_SX|MAS3_SW|MAS3_SR))@h
+	ori     r9,r9,FSL_BOOKE_MAS3(CONFIG_SYS_LBC_ADDR, 0, (MAS3_SX|MAS3_SW|MAS3_SR))@l

Lines too long.

Quoted 5 lines
drivers/misc/fsl_law.c +0 -0
index 58340c1..be43a3e 100644
@@ -35,7 +35,7 @@ DECLARE_GLOBAL_DATA_PTR;

...

drivers/misc/fsl_law.c

Quoted 6 lines
drivers/misc/fsl_law.c +6 -0
+#if defined(CONFIG_MPC8569)
+	uint	plppar1;	/* 0xe0040 - Platform port pin assignment register 1 */
+	uint	plppar2;	/* 0xe0044 - Platform port pin assignment register 2 */
+	uint	plpdir1;	/* 0xe0048 - Platform port pin direction register 1 */
+	uint	plpdir2;	/* 0xe004c - Platform port pin direction register 2 */
+#else

Lines too long.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The thing is, as you progress in the Craft,  you'll  learn  there  is
another rule... When you break rules, break 'em good and hard.
                                    - Terry Pratchett, _Wyrd Sisters_