Skip to contentSkip to conversation

Network died completely in 2.6.29

DISCUSSION Ondrej Zary 2 participants 3 messages Mar 27, 2009 – Mar 28, 2009 Networking

lore
Share & tools
lore
#0 lore raw

Hello,
upgraded to 2.6.29 today. It appeared to work fine for a couple of hours. But suddenly the network stopped. I wasn't even able to ping my local IP. Even pinging 127.0.0.1 did not work. There were no errors in dmesg and the system appeared to work fine otherwise. Had to reboot (into 2.6.28).

Never seen this before. Anyone with the same problem?

Signature · 1 line
Ondrej Zary
maintainer
#1 lore raw

From: Ondrej Zary <[email protected]>
Date: Fri, 27 Mar 2009 23:51:36 +0100

Quoted 6 lines

upgraded to 2.6.29 today. It appeared to work fine for a couple of hours. But suddenly the network stopped. I wasn't even able to ping my local IP. Even pinging 127.0.0.1 did not work. There were no errors in dmesg and the system appeared to work fine otherwise. Had to reboot (into 2.6.28).

Never seen this before. Anyone with the same problem?

It's a known problem, the following fix will be submitted to 2.6.29.1 over the weekend.

GRO: Disable GRO on legacy netif_rx path

When I fixed the GRO crash in the legacy receive path I used napi_complete to replace __napi_complete. Unfortunately they're not the same when NETPOLL is enabled, which may result in us not calling __napi_complete at all.

What's more, we really do need to keep the __napi_complete call within the IRQ-off section since in theory an IRQ can occur in between and fill up the backlog to the maximum, causing us to lock up.

Since we can't seem to find a fix that works properly right now, this patch reverts all the GRO support from the netif_rx path.

---
 net/core/dev.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)
net/core/dev.c +3 -6
index 052dd47..63ec4bf 100644
@@ -2627,18 +2627,15 @@ static int process_backlog(struct napi_struct *napi, int quota)
 		local_irq_disable();
 		skb = __skb_dequeue(&queue->input_pkt_queue);
 		if (!skb) {
+			__napi_complete(napi);
 			local_irq_enable();
-			napi_complete(napi);
-			goto out;
+			break;
 		}
 		local_irq_enable();
 
-		napi_gro_receive(napi, skb);
+		netif_receive_skb(skb);
 	} while (++work < quota && jiffies == start_time);
 
-	napi_gro_flush(napi);
-
-out:
 	return work;
 }
 
Signature · 1 line
1.6.2.1.222.g570cc
#2 lore raw
Quoted 8 lines · On Friday 27 March 2009 23:53:46 David Miller wrote:

From: Ondrej Zary <[email protected]>
Date: Fri, 27 Mar 2009 23:51:36 +0100

Quoted 5 lines

upgraded to 2.6.29 today. It appeared to work fine for a couple of hours. But suddenly the network stopped. I wasn't even able to ping my local IP. Even pinging 127.0.0.1 did not work. There were no errors in dmesg and the system appeared to work fine otherwise. Had to reboot (into 2.6.28).

Quoted 4 lines
Quoted 1 line

Never seen this before. Anyone with the same problem?

It's a known problem, the following fix will be submitted to 2.6.29.1 over the weekend.

Thanks, it seems to work now.

Signature · 1 line
Ondrej Zary