Skip to contentSkip to conversation

hso: fix for the 'invalid frame length' messages

PATCH In review Jan Dumon 3 participants 4 messages Mar 30, 2009 – Apr 2, 2009 2 messages not in the archive

Subsystems (4)
lore
Share & tools
lore

Jan Dumon

author
#0 lore raw

PATCH 1/1 hso: fix for the 'invalid frame length' messages

From: Jan Dumon <[email protected]>

Some devices cannot send very short usb transfers. To get around this the firmware adds a known pattern and flags the driver that it should check for this pattern on short transfers. This flag was not taken into account by the driver.

---

drivers/net/usb/hso.c +6 -4
index a9320db..67f05ad 100644
@@ -2532,14 +2532,15 @@ static void hso_create_rfkill(struct hso_device *hso_dev,
 }
 
 /* Creates our network device */
-static struct hso_device *hso_create_net_device(struct usb_interface *interface)
+static struct hso_device *hso_create_net_device(struct usb_interface *interface,
+						int port_spec)
 {
 	int result, i;
 	struct net_device *net;
 	struct hso_net *hso_net;
 	struct hso_device *hso_dev;
 
-	hso_dev = hso_create_device(interface, HSO_INTF_MUX | HSO_PORT_NETWORK);
+	hso_dev = hso_create_device(interface, port_spec);
 	if (!hso_dev)
 		return NULL;
 
@@ -2939,7 +2940,8 @@ static int hso_probe(struct usb_interface *interface,
 		if ((port_spec & HSO_PORT_MASK) == HSO_PORT_NETWORK) {
 			/* Create the network device */
 			if (!disable_net) {
-				hso_dev = hso_create_net_device(interface);
+				hso_dev = hso_create_net_device(interface,
+								port_spec);
 				if (!hso_dev)
 					goto exit;
 				tmp_dev = hso_dev;
@@ -2971,7 +2973,7 @@ static int hso_probe(struct usb_interface *interface,
 		/* It's a regular bulk interface */
 		if (((port_spec & HSO_PORT_MASK) == HSO_PORT_NETWORK)
 		    && !disable_net)
-			hso_dev = hso_create_net_device(interface);
+			hso_dev = hso_create_net_device(interface, port_spec);
 		else
 			hso_dev =
 			    hso_create_bulk_serial_device(interface, port_spec);

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#1 lore raw

From: Jan Dumon <[email protected]>
Date: Mon, 30 Mar 2009 11:44:59 +0200

Quoted 6 lines

Some devices cannot send very short usb transfers. To get around this the firmware adds a known pattern and flags the driver that it should check for this pattern on short transfers. This flag was not taken into account by the driver.

These patches do not apply cleanly, please respin them against the current sources.

A message that is not in the archive (sent off-list or not yet received): 20090402.012032.67869929.davem-fT/PcQaiUtIeIZ0/[email protected]

author
#3 lore raw
Quoted 8 lines · David Miller

From: Jan Dumon <[email protected]>
Date: Mon, 30 Mar 2009 11:44:59 +0200

Quoted 5 lines

Some devices cannot send very short usb transfers. To get around this the firmware adds a known pattern and flags the driver that it should check for this pattern on short transfers. This flag was not taken into account by the driver.

Quoted 4 lines
Quoted 1 line

These patches do not apply cleanly, please respin them against the current sources.

The diff was taken against 2.6.29, problem is that they both change the same file (as did the product ID patch) and that changes the line numbers...
Against which sources should I take them again and should I start from the same clean sources for each patch or can they be "stacked" ?

Greets.
Jan.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

From: Jan Dumon <[email protected]>
Date: Thu, 02 Apr 2009 10:34:02 +0200

Quoted 3 lines

Against which sources should I take them again and should I start from the same clean sources for each patch or can they be "stacked" ?

When you have multiple patches, you number them, and they are applied in that series order.

You can work against:

	git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html