oprofile: Thou shalt not call __exit functions from __init functions
PATCH 1/1 oprofile: Thou shalt not call __exit functions from __init functions
buffer_sync_cleanup' referenced in section .init.text' of arch/arm/oprofile/built-in.o: defined in discarded section `.exit.text' of arch/arm/oprofile/built-in.o
---
drivers/oprofile/buffer_sync.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/oprofile/buffer_sync.c +1 -1
@@ -574,7 +574,7 @@ int __init buffer_sync_init(void)return 0 ; } -void __exit buffer_sync_cleanup(void) +void buffer_sync_cleanup (void ) {free_cpumask_var (marked_cpus); }
Signature · 1 line
Russell King
Quoted 3 lines · On Monday 30 March 2009 02:42:22 Russell King wrote:
buffer_sync_cleanup' referenced in section.init.text' ofarch/arm/oprofile/built-in.o: defined in discarded section `.exit.text' ofarch/arm/oprofile/built-in.oSigned-off-by Russell King <[email protected]>
Thanks, I've applied it in case the oprofile people don't get there first.
Cheers,
Rusty.
Quoted 4 lines · Rusty Russell
Quoted 3 lines · On Monday 30 March 2009 02:42:22 Russell King wrote:
buffer_sync_cleanup' referenced in section.init.text' ofarch/arm/oprofile/built-in.o: defined in discarded section `.exit.text' ofarch/arm/oprofile/built-in.oSigned-off-by Russell King <[email protected]>
There is patch 4c50d9ea9ca9e46b65aeffed3e0d6f54ff38c8d4 in tip/cpus4096 that reworks and fixes this code already. It should go upstream too.
-Robert
Quoted 11 lines
Thanks, I've applied it in case the oprofile people don't get there first.
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 3 lines
Advanced Micro Devices, Inc. Operating System Research Center email: [email protected]