Skip to contentSkip to conversation

ETHOC: fix build breakage on s390

PATCH Applied Heiko Carstens 3 participants 3 messages Mar 30, 2009 – Mar 31, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ETHOC: fix build breakage on s390

From: Heiko Carstens <[email protected]>

Let driver depend on HAS_IOMEM to avoid build breakage on s390:

CC drivers/net/ethoc.o
drivers/net/ethoc.c: In function 'ethoc_read':
drivers/net/ethoc.c:221: error: implicit declaration of function 'ioread32' drivers/net/ethoc.c: In function 'ethoc_write':
drivers/net/ethoc.c:226: error: implicit declaration of function 'iowrite32' drivers/net/ethoc.c: In function 'ethoc_rx':
drivers/net/ethoc.c:405: error: implicit declaration of function 'memcpy_fromio' drivers/net/ethoc.c: In function 'ethoc_start_xmit':
drivers/net/ethoc.c:828: error: implicit declaration of function 'memcpy_toio'

---
 drivers/net/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/Kconfig +1 -1
Index: linux-2.6/drivers/net/Kconfig
===================================================================
@@ -974,7 +974,7 @@ config ENC28J60_WRITEVERIFY
 
 config ETHOC
 	tristate "OpenCores 10/100 Mbps Ethernet MAC support"
-	depends on NET_ETHERNET
+	depends on NET_ETHERNET && HAS_IOMEM
 	select MII
 	select PHYLIB
 	help
Acked-by on v1 1/1
#1 lore raw
Quoted 25 lines · Heiko Carstens

From: Heiko Carstens <[email protected]>

Let driver depend on HAS_IOMEM to avoid build breakage on s390:

CC drivers/net/ethoc.o
drivers/net/ethoc.c: In function 'ethoc_read':
drivers/net/ethoc.c:221: error: implicit declaration of function 'ioread32' drivers/net/ethoc.c: In function 'ethoc_write':
drivers/net/ethoc.c:226: error: implicit declaration of function 'iowrite32' drivers/net/ethoc.c: In function 'ethoc_rx':
drivers/net/ethoc.c:405: error: implicit declaration of function 'memcpy_fromio' drivers/net/ethoc.c: In function 'ethoc_start_xmit':
drivers/net/ethoc.c:828: error: implicit declaration of function 'memcpy_toio'

---
 drivers/net/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/net/Kconfig
===================================================================

drivers/net/Kconfig config ENC28J60_WRITEVERIFY · line 980

Quoted 8 lines
drivers/net/Kconfig +1 -1
@@ -974,7 +974,7 @@ config ENC28J60_WRITEVERIFY
 
 config ETHOC
 	tristate "OpenCores 10/100 Mbps Ethernet MAC support"
-	depends on NET_ETHERNET
+	depends on NET_ETHERNET && HAS_IOMEM
 	select MII
 	select PHYLIB
 	help
maintainer Applied
#2 lore raw

From: Thierry Reding <[email protected]>
Date: Mon, 30 Mar 2009 13:52:02 +0200

Quoted 7 lines · Heiko Carstens
Quoted 6 lines

From: Heiko Carstens <[email protected]>

Let driver depend on HAS_IOMEM to avoid build breakage on s390:

CC drivers/net/ethoc.o
drivers/net/ethoc.c: In function 'ethoc_read':

...

Quoted 2 lines
Quoted 2 lines

...

Quoted 1 line

Applied.