Skip to contentSkip to conversation

ARM Pull Request

U-Boot Jean-Christophe PLAGNIOL-VILLARD 3 participants 9 messages Mar 29, 2009 – Mar 31, 2009

lore
Share & tools
lore
#0 lore raw

Hi Wolfgang,

Please pull
The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

git://git.denx.de/u-boot-arm.git master

Jean-Christophe PLAGNIOL-VILLARD (19):
s3c4510b: move specific code to soc directory
s3c44b0: move i2c driver to drivers/i2c
s3c44b0: move rtc driver to drivers/rtc
s3c44b0: move serial driver to drivers/serial
s3c44b0: extract cache from cpu.c
sa1100: move serial driver to drivers/serial
netarm: move serial driver to drivers/serial
imx31: move serial driver to drivers/serial
s3c64xx: move usb driver to drivers/usb
ks8695: move serial driver to drivers/serial
lpc2292: move serial driver to drivers/serial arm720t/clps7111: move serial driver to drivers/serial
omap3: remove duplicate interrupts code
imx: move serial driver to drivers/serial
davinci: move nand driver to drivers/mtd/nand
davinci: move i2c driver to drivers/i2c
s3c24x0: move serial driver to drivers/serial
s3c24x0: move i2c driver to drivers/i2c
s3c2410: move nand driver to drivers/mtd/nand

Ladislav Michl (7):
Remove nowhere used symbol CONFIG_SYS_CLKS_IN_HZ
NetStar: update crcit utility
NetStar: use generic flash driver
NetStar: add RTC support
OMAP: reindent timer code
OMAP: rename timer divisor
OMAP: use {read,write}l to access timer registers

 Makefile                                           |    2 +-
 board/netstar/Makefile                             |    2 +-
 board/netstar/crcit.c                              |   14 +-
 board/netstar/flash.c                              |  343 ----------------
 board/netstar/netstar.c                            |   20 +
 cpu/arm1136/mx31/Makefile                          |    2 +-
 cpu/arm1136/omap24xx/interrupts.c                  |    2 +-
 cpu/arm1176/s3c64xx/Makefile                       |    1 -
 cpu/arm720t/Makefile                               |    2 +-
 cpu/arm720t/cpu.c                                  |   62 ---
 cpu/arm720t/s3c4510b/Makefile                      |   46 ++
 cpu/arm720t/s3c4510b/cache.c                       |   86 ++++
 cpu/arm720t/serial.c                               |  202 ---------
 cpu/arm920t/imx/Makefile                           |    2 +-
 cpu/arm920t/ks8695/Makefile                        |    2 +-
 cpu/arm920t/s3c24x0/Makefile                       |    3 +-
 cpu/arm925t/interrupts.c                           |   40 +-
 cpu/arm926ejs/davinci/Makefile                     |    2 +-
 cpu/arm926ejs/omap/timer.c                         |    2 +-
 cpu/arm_cortexa8/omap3/interrupts.c                |  130 +------
 cpu/s3c44b0/Makefile                               |    2 +-
 cpu/s3c44b0/cache.c                                |   91 ++++
 cpu/s3c44b0/cpu.c                                  |  430 --------------------
 cpu/sa1100/Makefile                                |    2 +-
 drivers/i2c/Makefile                               |    3 +
 .../davinci/i2c.c => drivers/i2c/davinci_i2c.c     |    5 -
 .../s3c24x0/i2c.c => drivers/i2c/s3c24x0_i2c.c     |    5 -
 drivers/i2c/s3c44b0_i2c.c                          |  315 ++++++++++++++
 drivers/mtd/nand/Makefile                          |    2 +
 .../nand.c => drivers/mtd/nand/davinci_nand.c      |    9 -
 .../nand.c => drivers/mtd/nand/s3c2410_nand.c      |    8 -
 drivers/rtc/Makefile                               |    1 +
 drivers/rtc/s3c44b0_rtc.c                          |  102 +++++
 drivers/serial/Makefile                            |    9 +
 .../serial.c => drivers/serial/serial_clps7111.c   |   97 ++---
 .../imx/serial.c => drivers/serial/serial_imx.c    |    6 -
 .../serial.c => drivers/serial/serial_ks8695.c     |    0
 drivers/serial/serial_lpc2292.c                    |  105 +++++
 .../mx31/serial.c => drivers/serial/serial_mx31.c  |    6 -
 {cpu/arm720t => drivers/serial}/serial_netarm.c    |    5 -
 .../serial.c => drivers/serial/serial_s3c24x0.c    |    4 -
 .../serial.c => drivers/serial/serial_s3c44b0.c    |    0
 .../serial.c => drivers/serial/serial_sa1100.c     |    0
 drivers/usb/Makefile                               |    1 +
 .../s3c64xx/usb.c => drivers/usb/s3c64xx_usb.c     |    0
 include/asm-arm/arch-arm720t/hardware.h            |    4 +-
 .../s3c4510b.h => arch-s3c4510b/hardware.h}        |    0
 include/configs/ADNPESC1.h                         |    1 -
 include/configs/B2.h                               |    6 +-
 include/configs/DK1C20.h                           |    1 -
 include/configs/DK1S10.h                           |    1 -
 include/configs/EXBITGEN.h                         |    2 -
 include/configs/SMN42.h                            |    3 +-
 include/configs/SX1.h                              |    8 +-
 include/configs/VCMA9.h                            |    4 +-
 include/configs/W7OLMC.h                           |    2 -
 include/configs/W7OLMG.h                           |    2 -
 include/configs/actux1.h                           |    2 -
 include/configs/actux2.h                           |    2 -
 include/configs/actux3.h                           |    2 -
 include/configs/actux4.h                           |    2 -
 include/configs/apollon.h                          |    7 +-
 include/configs/armadillo.h                        |    3 +-
 include/configs/assabet.h                          |    3 +-
 include/configs/cerf250.h                          |    2 -
 include/configs/cm4008.h                           |    3 +-
 include/configs/cm41xx.h                           |    3 +-
 include/configs/cradle.h                           |    2 -
 include/configs/csb226.h                           |    2 -
 include/configs/csb272.h                           |    1 -
 include/configs/csb472.h                           |    1 -
 include/configs/davinci_dvevm.h                    |    1 +
 include/configs/davinci_schmoogie.h                |    1 +
 include/configs/davinci_sffsdr.h                   |    1 +
 include/configs/davinci_sonata.h                   |    1 +
 include/configs/delta.h                            |    2 -
 include/configs/dnp1110.h                          |    3 +-
 include/configs/eNET.h                             |    2 -
 include/configs/ep7312.h                           |    3 +-
 include/configs/evb4510.h                          |    2 -
 include/configs/gcplus.h                           |    3 +-
 include/configs/hymod.h                            |    2 -
 include/configs/impa7.h                            |    3 +-
 include/configs/innokom.h                          |    2 -
 include/configs/integratorap.h                     |    1 -
 include/configs/integratorcp.h                     |    1 -
 include/configs/ixdp425.h                          |    2 -
 include/configs/ixdpg425.h                         |    1 -
 include/configs/lart.h                             |    3 +-
 include/configs/logodl.h                           |    2 -
 include/configs/lpc2292sodimm.h                    |    3 +-
 include/configs/lpd7a400.h                         |    2 -
 include/configs/lpd7a404.h                         |    2 -
 include/configs/lubbock.h                          |    2 -
 include/configs/modnet50.h                         |    3 +-
 include/configs/mx1ads.h                           |    2 +-
 include/configs/mx1fs2.h                           |    5 +-
 include/configs/netstar.h                          |   35 +-
 include/configs/nmdk8815.h                         |    1 -
 include/configs/ns9750dev.h                        |    2 -
 include/configs/omap1510inn.h                      |    8 +-
 include/configs/omap1610h2.h                       |    6 +-
 include/configs/omap1610inn.h                      |    6 +-
 include/configs/omap2420h4.h                       |   12 +-
 include/configs/omap3_beagle.h                     |    8 +-
 include/configs/omap3_evm.h                        |    9 +-
 include/configs/omap3_overo.h                      |    9 +-
 include/configs/omap3_pandora.h                    |    9 +-
 include/configs/omap3_zoom1.h                      |    8 +-
 include/configs/omap5912osk.h                      |    6 +-
 include/configs/omap730p2.h                        |    9 +-
 include/configs/pdnb3.h                            |    1 -
 include/configs/pleb2.h                            |    2 -
 include/configs/pxa255_idp.h                       |    2 -
 include/configs/sbc2410x.h                         |    4 +-
 include/configs/sc520_cdp.h                        |    2 -
 include/configs/sc520_spunk.h                      |    2 -
 include/configs/scb9328.h                          |    3 +-
 include/configs/shannon.h                          |    3 +-
 include/configs/smdk2400.h                         |    3 +-
 include/configs/smdk2410.h                         |    3 +-
 include/configs/smdk6400.h                         |    1 +
 include/configs/trab.h                             |    3 +-
 include/configs/trizepsiv.h                        |    2 -
 include/configs/versatile.h                        |    1 -
 include/configs/voiceblue.h                        |    8 +-
 include/configs/wepep250.h                         |    2 -
 include/configs/xaeniax.h                          |    2 -
 include/configs/xm250.h                            |    2 -
 include/configs/xsengine.h                         |    1 -
 include/configs/zylonite.h                         |    2 -
 131 files changed, 936 insertions(+), 1538 deletions(-)
 delete mode 100644 board/netstar/flash.c
 create mode 100644 cpu/arm720t/s3c4510b/Makefile
 create mode 100644 cpu/arm720t/s3c4510b/cache.c
 delete mode 100644 cpu/arm720t/serial.c
 create mode 100644 cpu/s3c44b0/cache.c
 rename cpu/arm926ejs/davinci/i2c.c => drivers/i2c/davinci_i2c.c (98%)
 rename cpu/arm920t/s3c24x0/i2c.c => drivers/i2c/s3c24x0_i2c.c (99%)
 create mode 100644 drivers/i2c/s3c44b0_i2c.c
 rename cpu/arm926ejs/davinci/nand.c => drivers/mtd/nand/davinci_nand.c (98%)
 rename cpu/arm920t/s3c24x0/nand.c => drivers/mtd/nand/s3c2410_nand.c (96%)
 create mode 100644 drivers/rtc/s3c44b0_rtc.c
 copy cpu/sa1100/serial.c => drivers/serial/serial_clps7111.c (56%)
 rename cpu/arm920t/imx/serial.c => drivers/serial/serial_imx.c (97%)
 rename cpu/arm920t/ks8695/serial.c => drivers/serial/serial_ks8695.c (100%)
 create mode 100644 drivers/serial/serial_lpc2292.c
 rename cpu/arm1136/mx31/serial.c => drivers/serial/serial_mx31.c (99%)
 rename {cpu/arm720t => drivers/serial}/serial_netarm.c (99%)
 rename cpu/arm920t/s3c24x0/serial.c => drivers/serial/serial_s3c24x0.c (97%)
 rename cpu/s3c44b0/serial.c => drivers/serial/serial_s3c44b0.c (100%)
 rename cpu/sa1100/serial.c => drivers/serial/serial_sa1100.c (100%)
 rename cpu/arm1176/s3c64xx/usb.c => drivers/usb/s3c64xx_usb.c (100%)
 rename include/asm-arm/{arch-arm720t/s3c4510b.h => arch-s3c4510b/hardware.h} (100%)

Best Regards,
J.

#1 lore raw

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 23 lines · In message <[email protected]> you wrote:

Hi Wolfgang,

Please pull
The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

git://git.denx.de/u-boot-arm.git master

Jean-Christophe PLAGNIOL-VILLARD (19):
s3c4510b: move specific code to soc directory
s3c44b0: move i2c driver to drivers/i2c
s3c44b0: move rtc driver to drivers/rtc
s3c44b0: move serial driver to drivers/serial
s3c44b0: extract cache from cpu.c
sa1100: move serial driver to drivers/serial
netarm: move serial driver to drivers/serial
imx31: move serial driver to drivers/serial
s3c64xx: move usb driver to drivers/usb
ks8695: move serial driver to drivers/serial
lpc2292: move serial driver to drivers/serial

Quoted 8 lines

arm720t/clps7111: move serial driver to drivers/serial
omap3: remove duplicate interrupts code
imx: move serial driver to drivers/serial
davinci: move nand driver to drivers/mtd/nand
davinci: move i2c driver to drivers/i2c
s3c24x0: move serial driver to drivers/serial
s3c24x0: move i2c driver to drivers/i2c
s3c2410: move nand driver to drivers/mtd/nand

Ummm... don't you think it would be appropriate to allow at least for 2...3 days of review?

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In a business, marketroids, salespukes, and  lawyers  have  different
goals from those who actually do work and produce something. Usually,
is  is the former who triumph over the latter, due to the simple rule
that those who print the money make the rules.
         -- Tom Christiansen in <[email protected]>
#2 lore raw
Quoted 35 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 23 lines · In message <[email protected]> you wrote:

Hi Wolfgang,

Please pull
The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

git://git.denx.de/u-boot-arm.git master

Jean-Christophe PLAGNIOL-VILLARD (19):
s3c4510b: move specific code to soc directory
s3c44b0: move i2c driver to drivers/i2c
s3c44b0: move rtc driver to drivers/rtc
s3c44b0: move serial driver to drivers/serial
s3c44b0: extract cache from cpu.c
sa1100: move serial driver to drivers/serial
netarm: move serial driver to drivers/serial
imx31: move serial driver to drivers/serial
s3c64xx: move usb driver to drivers/usb
ks8695: move serial driver to drivers/serial
lpc2292: move serial driver to drivers/serial

Quoted 8 lines

arm720t/clps7111: move serial driver to drivers/serial
omap3: remove duplicate interrupts code
imx: move serial driver to drivers/serial
davinci: move nand driver to drivers/mtd/nand
davinci: move i2c driver to drivers/i2c
s3c24x0: move serial driver to drivers/serial
s3c24x0: move i2c driver to drivers/i2c
s3c2410: move nand driver to drivers/mtd/nand

Quoted 2 lines

Ummm... don't you think it would be appropriate to allow at least for 2...3 days of review?

The 14 first patches are already send 4 days agao
the 6 last are just code move

but if you prefer to wait 2 or 3 days ok

Best Regards,
J.

#3 lore raw
In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD

Hi Wolfgang,

Please pull
The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

git://git.denx.de/u-boot-arm.git master

Quoted 14 lines

Jean-Christophe PLAGNIOL-VILLARD (19):
s3c4510b: move specific code to soc directory
s3c44b0: move i2c driver to drivers/i2c
s3c44b0: move rtc driver to drivers/rtc
s3c44b0: move serial driver to drivers/serial
s3c44b0: extract cache from cpu.c
sa1100: move serial driver to drivers/serial
netarm: move serial driver to drivers/serial
imx31: move serial driver to drivers/serial
s3c64xx: move usb driver to drivers/usb
ks8695: move serial driver to drivers/serial
lpc2292: move serial driver to drivers/serial arm720t/clps7111: move serial driver to drivers/serial
omap3: remove duplicate interrupts code

This patch isn't finally reviewed

http://lists.denx.de/pipermail/u-boot/2009-March/049762.html

Please remove it from the pull request until everybody agreed.

Quoted 6 lines

imx: move serial driver to drivers/serial
davinci: move nand driver to drivers/mtd/nand
davinci: move i2c driver to drivers/i2c
s3c24x0: move serial driver to drivers/serial
s3c24x0: move i2c driver to drivers/i2c
s3c2410: move nand driver to drivers/mtd/nand

It seems to me that

http://lists.denx.de/pipermail/u-boot/2009-March/049662.html

is unanswered. Therefore again:

What's about

http://lists.denx.de/pipermail/u-boot/2009-March/049146.html

?

Dirk

#4 lore raw
Quoted 27 lines · Dirk Behme
Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD

Hi Wolfgang,

Please pull
The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

git://git.denx.de/u-boot-arm.git master

Quoted 14 lines

Jean-Christophe PLAGNIOL-VILLARD (19):
s3c4510b: move specific code to soc directory
s3c44b0: move i2c driver to drivers/i2c
s3c44b0: move rtc driver to drivers/rtc
s3c44b0: move serial driver to drivers/serial
s3c44b0: extract cache from cpu.c
sa1100: move serial driver to drivers/serial
netarm: move serial driver to drivers/serial
imx31: move serial driver to drivers/serial
s3c64xx: move usb driver to drivers/usb
ks8695: move serial driver to drivers/serial
lpc2292: move serial driver to drivers/serial arm720t/clps7111: move serial driver to drivers/serial
omap3: remove duplicate interrupts code

Quoted 5 lines

This patch isn't finally reviewed

http://lists.denx.de/pipermail/u-boot/2009-March/049762.html

Please remove it from the pull request until everybody agreed

this duplicated code so I'll remove it anyway I do not want duplicated code

Quoted 11 lines
Quoted 7 lines

imx: move serial driver to drivers/serial
davinci: move nand driver to drivers/mtd/nand
davinci: move i2c driver to drivers/i2c
s3c24x0: move serial driver to drivers/serial
s3c24x0: move i2c driver to drivers/i2c
s3c2410: move nand driver to drivers/mtd/nand

It seems to me that

http://lists.denx.de/pipermail/u-boot/2009-March/049662.html

This one is NACK

Quoted 8 lines

is unanswered. Therefore again:

What's about

http://lists.denx.de/pipermail/u-boot/2009-March/049146.html

?

I'm not statisfy about this one I'm looking on an other implementation so this patch will wait a few more days

Best Regards,
J.

#5 lore raw

Dear Jean-Christophe,

Quoted 27 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 26 lines · Dirk Behme
Quoted 25 lines · Jean-Christophe PLAGNIOL-VILLARD

Hi Wolfgang,

Please pull
The following changes since commit 88685b5f62274167ad2ba8a58e108d89ff71955b:
Wolfgang Denk (1):
VCMA9: fix compile errors

are available in the git repository at:

git://git.denx.de/u-boot-arm.git master

Jean-Christophe PLAGNIOL-VILLARD (19):
s3c4510b: move specific code to soc directory
s3c44b0: move i2c driver to drivers/i2c
s3c44b0: move rtc driver to drivers/rtc
s3c44b0: move serial driver to drivers/serial
s3c44b0: extract cache from cpu.c
sa1100: move serial driver to drivers/serial
netarm: move serial driver to drivers/serial
imx31: move serial driver to drivers/serial
s3c64xx: move usb driver to drivers/usb
ks8695: move serial driver to drivers/serial
lpc2292: move serial driver to drivers/serial arm720t/clps7111: move serial driver to drivers/serial
omap3: remove duplicate interrupts code

Quoted 6 lines
Quoted 5 lines

This patch isn't finally reviewed

http://lists.denx.de/pipermail/u-boot/2009-March/049762.html

Please remove it from the pull request until everybody agreed

this duplicated code

It would be nice if you could give the exact file in which you found the other/original version of this code. As already mentioned I'd like to compare/review it.

Quoted 1 line

so I'll remove it anyway I do not want duplicated code

It would be nice if we could agree on a common way how to improve (remove?) this code. And not just "I'll remove it anyway". Sorry if I misunderstood this, but it could be understood as "I will remove it independent of what other people think and do".

Quoted 10 lines
Quoted 9 lines
Quoted 6 lines

imx: move serial driver to drivers/serial
davinci: move nand driver to drivers/mtd/nand
davinci: move i2c driver to drivers/i2c
s3c24x0: move serial driver to drivers/serial
s3c24x0: move i2c driver to drivers/i2c
s3c2410: move nand driver to drivers/mtd/nand

It seems to me that

http://lists.denx.de/pipermail/u-boot/2009-March/049662.html

This one is NACK

? This link just links to a mail with two questions, not a patch ?

Quoted 9 lines
Quoted 7 lines

is unanswered. Therefore again:

What's about

http://lists.denx.de/pipermail/u-boot/2009-March/049146.html

?

I'm not statisfy about this one I'm looking on an other implementation so this patch will wait a few more days

It would be nice if you could share your ideas/doubts/findings so that we can work together on improving this code.

Dirk

#6 lore raw

Dear Dirk Behme,

Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Quoted 4 lines

http://lists.denx.de/pipermail/u-boot/2009-March/049762.html

Please remove it from the pull request until everybody agreed

this duplicated code

It would be nice if you could give the exact file in which you found the other/original version of this code. As already mentioned I'd like to compare/review it.

Quoted 6 lines
Quoted 1 line

so I'll remove it anyway I do not want duplicated code

It would be nice if we could agree on a common way how to improve (remove?) this code. And not just "I'll remove it anyway". Sorry if I misunderstood this, but it could be understood as "I will remove it independent of what other people think and do".

I have to admit that I, too, hesitated what that statement was supposed to mean. Jean-Christophe, it would really be nice to raise your complaints on the mailing list, and without too long delays, so we can discuss things.

Quoted 5 lines
Quoted 2 lines

I'm not statisfy about this one I'm looking on an other implementation so this patch will wait a few more days

It would be nice if you could share your ideas/doubts/findings so that we can work together on improving this code.

Again, I agree 100%. Jean-Christophe, please share your concerns on the mailing list, and without so long delays after the postings. It is not your job as a custodian to fix everything yourself. It is sufficient (and actually usualy much better, think for example about the long-term educational aspect) just to raise your concerns and ask the original poster to change things (or maybe he has good reasons for doing it this way, which you didn't see). But please keep such discussion on the mailing list, and without big delays. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The biggest difference between time and space is that you can't reuse
time.                                                 - Merrick Furst
#7 lore raw
Quoted 20 lines · Wolfgang Denk

Dear Dirk Behme,

Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Quoted 4 lines

http://lists.denx.de/pipermail/u-boot/2009-March/049762.html

Please remove it from the pull request until everybody agreed

this duplicated code

It would be nice if you could give the exact file in which you found the other/original version of this code. As already mentioned I'd like to compare/review it.

Quoted 6 lines
Quoted 1 line

so I'll remove it anyway I do not want duplicated code

It would be nice if we could agree on a common way how to improve (remove?) this code. And not just "I'll remove it anyway". Sorry if I misunderstood this, but it could be understood as "I will remove it independent of what other people think and do".

Quoted 4 lines

I have to admit that I, too, hesitated what that statement was supposed to mean. Jean-Christophe, it would really be nice to raise your complaints on the mailing list, and without too long delays, so we can discuss things.

It's simple I really hate duplicated that's all
so when I find copy&paste I remote it

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

I'm not statisfy about this one I'm looking on an other implementation so this patch will wait a few more days

It would be nice if you could share your ideas/doubts/findings so that we can work together on improving this code.

Quoted 8 lines

Again, I agree 100%. Jean-Christophe, please share your concerns on the mailing list, and without so long delays after the postings. It is not your job as a custodian to fix everything yourself. It is sufficient (and actually usualy much better, think for example about the long-term educational aspect) just to raise your concerns and ask the original poster to change things (or maybe he has good reasons for doing it this way, which you didn't see). But please keep such discussion on the mailing list, and without big delays. Thanks.

I need to time to study a way to clean it up. Without necessarely implement it I'm just bored by reading duplicated code everytime as the timer implementations.

So I need few days to study it

Best Regards,
J.

#8 lore raw
Quoted 17 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 16 lines · Wolfgang Denk

Dear Dirk Behme,

Quoted 13 lines · In message <[email protected]> you wrote:
Quoted 4 lines
Quoted 3 lines

http://lists.denx.de/pipermail/u-boot/2009-March/049762.html

Please remove it from the pull request until everybody agreed

this duplicated code

It would be nice if you could give the exact file in which you found the other/original version of this code. As already mentioned I'd like to compare/review it.

Quoted 1 line

so I'll remove it anyway I do not want duplicated code

It would be nice if we could agree on a common way how to improve (remove?) this code. And not just "I'll remove it anyway". Sorry if I misunderstood this, but it could be understood as "I will remove it independent of what other people think and do".

Quoted 6 lines
Quoted 4 lines

I have to admit that I, too, hesitated what that statement was supposed to mean. Jean-Christophe, it would really be nice to raise your complaints on the mailing list, and without too long delays, so we can discuss things.

It's simple I really hate duplicated that's all
so when I find copy&paste I remote it

It would be nice if you could give the exact file in which you found the other/original version of this code. As already mentioned I'd like to compare/review it.

Dirk