proc 6/6: cleanup proc_flush_task()
PATCH 1/1 proc 6/6: cleanup proc_flush_task()
Quoted 1 line
From
d789ba9bf62f4fffa0ad75c22815abdf5f46fb06Mon Sep 17 00:00:00 2001
From: Eric W. Biederman <[email protected]>
Date: Wed, 19 Nov 2008 05:16:17 +0300
Subject: [PATCH 11/11] proc 6/6: cleanup proc_flush_task()
- shrink_dcache_parent is guaranteed to only flush dcache entries from the specified superblock. So the the insanely subtle PF_EXITING check designed to avoid flushing filesystems inodes that are not safe to call during exit is unecessary.
- The test to avoid excess flushing of dcache entries in proc got inverted and generally broken for threads, and frankly all it saved was a single d_hash_and_lookup so there was very little point to it. So remove the check and keep the code stupid and correct.
--- fs/proc/base.c | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-)
fs/proc/base.c +3 -8
@@ -2578,15 +2578,11 @@ static void proc_flush_task_mnt(struct vfsmount *mnt, pid_t pid, pid_t tgid) name.len =snprintf (buf,sizeof (buf),"%d" , pid); dentry =d_hash_and_lookup (mnt->mnt_root, &name);if (dentry) { -if (!(current->flags &PF_EXITING )) -shrink_dcache_parent (dentry); +shrink_dcache_parent (dentry);d_drop (dentry);dput (dentry); } -if (tgid ==0 ) - goto out; - name.name = buf; name.len =snprintf (buf,sizeof (buf),"%d" , tgid); leader =d_hash_and_lookup (mnt->mnt_root, &name);
@@ -2647,13 +2643,12 @@ void proc_flush_task(struct task_struct *task)struct upid *upid; pid =task_pid (task); -if (thread_group_leader (task)) - tgid =task_tgid (task); + tgid =task_tgid (task);for (i =0 ; i <= pid->level; i++) { upid = &pid->numbers[i];proc_flush_task_mnt (upid->ns->proc_mnt, upid->nr, - tgid ? tgid->numbers[i].nr :0 ); + tgid->numbers[i].nr); } upid = &pid->numbers[pid->level];
Signature · 1 line
1.5.6.5