mpc83xx: Set guarded bit on BAT that covers the end of the address space
PATCH 1/1 mpc83xx: Set guarded bit on BAT that covers the end of the address space
continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer from the same problem.
--- include/configs/MPC8349EMDS.h | 3 ++- include/configs/MPC8349ITX.h | 3 ++- include/configs/MVBLM7.h | 3 ++- include/configs/SIMPC8313.h | 2 +- include/configs/sbc8349.h | 3 ++- 5 files changed, 9 insertions(+), 5 deletions(-)
include/configs/MPC8349EMDS.h +2 -1
@@ -683,7 +683,8 @@#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE)#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)#define CONFIG_SYS_IBAT7L (0)
include/configs/MPC8349ITX.h +2 -1
@@ -615,7 +615,8 @@ boards, we say we have two, but don't display a message if we find only one. */#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE)#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)#define CONFIG_SYS_IBAT7L 0
include/configs/MVBLM7.h +2 -1
@@ -360,7 +360,8 @@#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)/* stack in DCACHE 0xFDF00000 & FLASH @ 0xFF800000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE)#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)#define CONFIG_SYS_IBAT7L 0#define CONFIG_SYS_IBAT7U 0
include/configs/SIMPC8313.h +1 -1
@@ -437,7 +437,7 @@#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_GUARDEDSTORAGE)#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)#define CONFIG_SYS_IBAT7L (0)
include/configs/sbc8349.h +2 -1
@@ -605,7 +605,8 @@#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */ -#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE) +#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \ + BATL_GUARDEDSTORAGE)#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)#define CONFIG_SYS_IBAT7L (0)
Signature · 1 line
1.6.1.3
PATCH 1/1 mpc83xx: Set guarded bit on BAT that covers the end of the address space
Dear Kim Phillips,
Quoted 5 lines · In message <[email protected]> you wrote:
continuation of commit
a5d7049a4to remaining mpc83xx boards that suffer from the same problem.Signed-off-by Kim Phillips <[email protected]>CC Scott Wood <[email protected]>
Umm... what does that mean: "continuation of commit a5d7049a4"?
If these commits belong together logically, you must not split them apart.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You can do this in a number of ways. IBM chose to do all of them. Why do you find that funny? -- D. Taylor, Computer Science 350
PATCH 1/1 mpc83xx: Set guarded bit on BAT that covers the end of the address space
Quoted 6 lines · Wolfgang Denk
Dear Kim Phillips,
Quoted 3 lines · In message <[email protected]> you wrote:
continuation of commit
a5d7049a4to remaining mpc83xx boards that suffer from the same problem.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Kim Phillips <[email protected]>CC Scott Wood <[email protected]>Umm... what does that mean: "continuation of commit
a5d7049a4"?If these commits belong together logically, you must not split them apart.
There's no bisectability problem; it's just similar bugs being fixed on other boards.
-Scott
PATCH 1/1 mpc83xx: Set guarded bit on BAT that covers the end of the address space
Dear Scott Wood,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Umm... what does that mean: "continuation of commit
a5d7049a4"?If these commits belong together logically, you must not split them apart.
There's no bisectability problem; it's just similar bugs being fixed on other boards.
why not fix them in a single commit, then?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The most difficult thing in the world is to know how to do a thing
and to watch someone else doing it wrong, without commenting.
-- T.H. WhitePATCH 1/1 mpc83xx: Set guarded bit on BAT that covers the end of the address space
Quoted 6 lines · On Tue, 31 Mar 2009 23:24:42 +0200 Wolfgang Denk <[email protected]> wrote:
Dear Scott Wood,
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 3 lines
Umm... what does that mean: "continuation of commit
a5d7049a4"?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
If these commits belong together logically, you must not split them apart.
There's no bisectability problem; it's just similar bugs being fixed on other boards.
why not fix them in a single commit, then?
this sounds reasonable - it gets rid of a moot commit, saving bisection its traversal. I'll add this to Scott's original patch and explain what I did between the s-o-b lines.
Kim