Skip to contentSkip to conversation

x86: smarten /proc/interrupts output for new counters

PATCH RESEND In review Hidetoshi Seto 3 participants 3 messages Mar 31, 2009 – Apr 1, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 x86: smarten /proc/interrupts output for new counters

Now /proc/interrupts of tip tree has new counters:
CNT: Performance counter interrupts
PLT: Platform interrupts

Format change of output as like that by commit:
commit 7a81d9a7da03d2f27840d659f97ef140d032f609
x86: smarten /proc/interrupts output
should be applied to these new counters too.

Cc Ingo Molnar <[email protected]>
Cc Jan Beulich <[email protected]>
---
 arch/x86/kernel/irq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/irq.c +2 -2
index 9c27543..35b3725 100644
@@ -63,13 +63,13 @@ static int show_other_interrupts(struct seq_file *p, int prec)
 	for_each_online_cpu(j)
 		seq_printf(p, "%10u ", irq_stats(j)->irq_spurious_count);
 	seq_printf(p, "  Spurious interrupts\n");
-	seq_printf(p, "CNT: ");
+	seq_printf(p, "%*s: ", prec, "CNT");
 	for_each_online_cpu(j)
 		seq_printf(p, "%10u ", irq_stats(j)->apic_perf_irqs);
 	seq_printf(p, "  Performance counter interrupts\n");
 #endif
 	if (generic_interrupt_extension) {
-		seq_printf(p, "PLT: ");
+		seq_printf(p, "%*s: ", prec, "PLT");
 		for_each_online_cpu(j)
 			seq_printf(p, "%10u ", irq_stats(j)->generic_irqs);
 		seq_printf(p, "  Platform interrupts\n");
Signature · 1 line
1.6.2.1
Acked-by on v1 1/1
#1 lore raw

Re: [RESEND][PATCH -tip] x86: smarten /proc/interrupts output for newcounters

Quoted 1 line
Quoted 1 line
Quoted 1 line

Hidetoshi Seto <[email protected]> 31.03.09 09:55 >>>

Now /proc/interrupts of tip tree has new counters:
CNT: Performance counter interrupts
PLT: Platform interrupts

Format change of output as like that by commit:
commit 7a81d9a7da03d2f27840d659f97ef140d032f609
x86: smarten /proc/interrupts output
should be applied to these new counters too.

Cc Ingo Molnar <[email protected]>
Cc Jan Beulich <[email protected]>
---
 arch/x86/kernel/irq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/irq.c +2 -2
index 9c27543..35b3725 100644
@@ -63,13 +63,13 @@ static int show_other_interrupts(struct seq_file *p, int prec)
 	for_each_online_cpu(j)
 		seq_printf(p, "%10u ", irq_stats(j)->irq_spurious_count);
 	seq_printf(p, "  Spurious interrupts\n");
-	seq_printf(p, "CNT: ");
+	seq_printf(p, "%*s: ", prec, "CNT");
 	for_each_online_cpu(j)
 		seq_printf(p, "%10u ", irq_stats(j)->apic_perf_irqs);
 	seq_printf(p, "  Performance counter interrupts\n");
 #endif
 	if (generic_interrupt_extension) {
-		seq_printf(p, "PLT: ");
+		seq_printf(p, "%*s: ", prec, "PLT");
 		for_each_online_cpu(j)
 			seq_printf(p, "%10u ", irq_stats(j)->generic_irqs);
 		seq_printf(p, "  Platform interrupts\n");
Signature · 1 line
1.6.2.1
#2 lore raw

Re: [RESEND][PATCH -tip] x86: smarten /proc/interrupts output for newcounters

Quoted 1 line · Jan Beulich

Thanks, we can apply this one once -tip merges latest -git. (which is any day now)

Ingo