fsl_pq_mdio: Revive UCC MDIO support
Subsystems (2)
PATCH 1/1 fsl_pq_mdio: Revive UCC MDIO support
commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC and gianfar MDIO bus drivers") introduced a regression so that UCC MDIO buses no longer work.
This is because fsl_pq_mdio driver wrongly masks all non-TBI PHYs for !fsl,gianfar-mdio buses, while it should do that only for fsl,gianfar-tbi buses.
--- drivers/net/fsl_pq_mdio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/fsl_pq_mdio.c +1 -1
@@ -387,7 +387,7 @@ static int fsl_pq_mdio_probe(struct of_device *ofdev,* The TBIPHY-only buses will find PHYs at every address, * so we mask them all but the TBI */ -if (!of_device_is_compatible (np,"fsl,gianfar-mdio" )) +if (of_device_is_compatible (np,"fsl,gianfar-tbi" )) new_bus->phy_mask = ~(1 << tbiaddr); err =mdiobus_register (new_bus);
Signature · 1 line
1.5.6.5
From: Anton Vorontsov <[email protected]>
Date: Tue, 31 Mar 2009 22:33:52 +0400
Quoted 9 lines
commit
1577ecef766650a57fceb171acee2b13cbfaf1d3("netdev: Merge UCC and gianfar MDIO bus drivers") introduced a regression so that UCC MDIO buses no longer work.This is because
fsl_pq_mdiodriver wrongly masks all non-TBI PHYs for !fsl,gianfar-mdio buses, while it should do that only for fsl,gianfar-tbi buses.Signed-off-by Anton Vorontsov <[email protected]>
Applied, thanks.