Skip to contentSkip to conversation

input: hp_sdc_rtc should depend on serio

PATCH In review Alexander Beregalov 2 participants 2 messages Apr 3, 2009 – Apr 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: hp_sdc_rtc should depend on serio

Fix this build error when CONFIG_SERIO is not set hp_sdc_rtc.c:691: undefined reference to `hp_sdc_request_timer_irq' and so on..

"select should be used with care. select will force a symbol to a value without visiting the dependencies."

---

 drivers/input/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/input/misc/Kconfig +1 -0
index 203abac..ae5d7dc 100644
@@ -215,6 +215,7 @@ config INPUT_SGI_BTNS
 config HP_SDC_RTC
 	tristate "HP SDC Real Time Clock"
 	depends on GSC || HP300
+	select SERIO
 	select HP_SDC
 	help
 	  Say Y here if you want to support the built-in real time clock
maintainer
#1 lore raw

Hi Alexander,

Quoted 18 lines · Alexander Beregalov

Fix this build error when CONFIG_SERIO is not set hp_sdc_rtc.c:691: undefined reference to `hp_sdc_request_timer_irq' and so on..

"select should be used with care. select will force a symbol to a value without visiting the dependencies."

---

 drivers/input/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/input/misc/Kconfig +0 -0
index 203abac..ae5d7dc 100644

drivers/input/misc/Kconfig config INPUT_SGI_BTNS · line 218

Quoted 4 lines
drivers/input/misc/Kconfig +1 -0
@@ -215,6 +215,7 @@ config INPUT_SGI_BTNS
 config HP_SDC_RTC
 	tristate "HP SDC Real Time Clock"
 	depends on GSC || HP300
+	select SERIO

Why don'we make it "depend on SERIO"?

Signature · 1 line
Dmitry