Skip to contentSkip to conversation

Noisily disable the legacy NAND subsystem.

PATCH New Scott Wood 4 participants 4 messages Apr 1, 2009 – Apr 4, 2009 Memory technology devices (MTD)

lore
Share & tools
lore

Scott Wood

author
#0 lore raw

PATCH v2 1/1 Noisily disable the legacy NAND subsystem.

Legacy NAND is marked for feature removal after April 2009 (i.e. this upcoming release). There are still several boards that reference it (though many do so only for disk-on-chip support which has been silently disabled for a while now). These boards will now fail to build with #error, though the code is still there if the user removes #error.

The plan is to remove the code outright in the next release, along with any board code that refers to it (such as board/esd/common/auto_update.c).

Also, remove the legacy NAND API description from README.nand.

---
Now with doc updates, restoration of a missing changelog line, and clarification of the error message in cmd_doc.c.

Applied to u-boot-nand-flash.

 common/cmd_doc.c                      |    4 +
 doc/README.nand                       |  109 ++++-----------------------------
 drivers/mtd/nand_legacy/nand_legacy.c |    3 +
 3 files changed, 20 insertions(+), 96 deletions(-)
common/cmd_doc.c +4 -0
index e2d4a42..3385c67 100644
@@ -14,6 +14,10 @@
 #include <linux/mtd/nftl.h>
 #include <linux/mtd/doc2000.h>
 
+#error This code is broken and will be removed outright in the next release.
+#error If you need diskonchip support, please update the Linux driver in
+#error drivers/mtd/nand/diskonchip.c to work with u-boot.
+
 /*
  * ! BROKEN !
  *
doc/README.nand +13 -96

123 lines not on this page · raw message

drivers/mtd/nand_legacy/nand_legacy.c +3 -0
index 441780a..d9ae9c7 100644
@@ -18,6 +18,9 @@
 #include <linux/mtd/nand_ids.h>
 #include <jffs2/jffs2.h>
 
+#error Legacy NAND is deprecated.  Please convert to the current NAND interface.
+#error This code will be removed outright in the next release.
+
 #ifdef CONFIG_OMAP1510
 void archflashwp(void *archdata, int wp);
 #endif
Signature · 1 line
1.5.6.rc1.6.gc53ad
#1 lore raw

PATCH v2 1/1 Noisily disable the legacy NAND subsystem.

Quoted 9 lines · Scott Wood

Legacy NAND is marked for feature removal after April 2009 (i.e. this upcoming release). There are still several boards that reference it (though many do so only for disk-on-chip support which has been silently disabled for a while now). These boards will now fail to build with #error, though the code is still there if the user removes #error.

The plan is to remove the code outright in the next release, along with any board code that refers to it (such as board/esd/common/auto_update.c).

Quoted 8 lines

Also, remove the legacy NAND API description from README.nand.

---
Now with doc updates, restoration of a missing changelog line, and clarification of the error message in cmd_doc.c.

Applied to u-boot-nand-flash.

Scoot you brake the rm9200dk

could you convert your #error in #warning for this release
as it's said in the commit message it will be remove for the next release

it will be nice to have this kind of #error at the beginning to the merge to allow people to fix it

Best Regards,
J.

#2 lore raw

PATCH v2 1/1 Noisily disable the legacy NAND subsystem.

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 2 lines · In message <[email protected]> you wrote:

Scoot you brake the rm9200dk

No, he did not. He just made the problem clearly visible - the code
was has been broken before (just silently), if I understand
correctly.

Quoted 2 lines

could you convert your #error in #warning for this release
as it's said in the commit message it will be remove for the next release

I think we should leave this an #error, so people are really forced to react.

Quoted 2 lines

it will be nice to have this kind of #error at the beginning to the merge to allow people to fix it

Well, we are on the very first day of 10 week long bux fixing period. Can you imagine any better point in time to check this in? I cannot.

So please don't complain, either help fixing the broken code or remove the config option from the affected boards.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Es sind ?berhaupt nur die Dummk?pfe, die sich den Befehlen der  M?ch-
tigen  widersetzen.  Um  sie  zu ruinieren ist es genug, ihre Befehle
treu zu erf?llen.                  - Peter Hacks: "Die sch?ne Helena"
#3 lore raw

PATCH v2 1/1 Noisily disable the legacy NAND subsystem.

Quoted 10 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 2 lines · In message <[email protected]> you wrote:

Scoot you brake the rm9200dk

No, he did not. He just made the problem clearly visible - the code
was has been broken before (just silently), if I understand
correctly.

Quoted 6 lines
Quoted 2 lines

could you convert your #error in #warning for this release as it's said in the commit message it will be remove for the next

release

I think we should leave this an #error, so people are really forced to react.

Second that. That ancient code should've long died.

---
******************************************************************
* KSI at home KOI8 Net < > The impossible we do immediately. *
* Las Vegas NV, USA < > Miracles require 24-hour notice. *
******************************************************************