mpc5200: reduce delays in i2c
PATCH 1/1 mpc5200: reduce delays in i2c
The previous code waited 1000us before checking i2c status. Measurement shows i2c is usually ready in under 50us. Change the polling interval to 15us, loop 6,667 times to keep the polling timeout constant at 100ms.
--- cpu/mpc5xxx/i2c.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
cpu/mpc5xxx/i2c.c +3 -3
@@ -38,7 +38,7 @@ DECLARE_GLOBAL_DATA_PTR;#error CONFIG_SYS_I2C_MODULE is not properly configured#endif -#define I2C_TIMEOUT 100 +#define I2C_TIMEOUT 6667#define I2C_RETRIES 3struct mpc5xxx_i2c_tap {
@@ -94,7 +94,7 @@ static int wait_for_bb(void)mpc_reg_out (®s->mcr,0 ,0 );mpc_reg_out (®s->mcr,I2C_EN ,0 );#endif -udelay (1000 ); +udelay (15 ); status =mpc_reg_in (®s->msr); }
@@ -109,7 +109,7 @@ static int wait_for_pin(int *status) *status =mpc_reg_in (®s->msr);while (timeout-- && !(*status &I2C_IF )) { -udelay (1000 ); +udelay (15 ); *status =mpc_reg_in (®s->msr); }
Wolfgang Denk
AppliedPATCH 1/1 mpc5200: reduce delays in i2c
Dear Jon Smirl,
Quoted 8 lines · In message <20090404214451.3615.21311.stgit@terra> you wrote:
The previous code waited 1000us before checking i2c status. Measurement shows i2c is usually ready in under 50us. Change the polling interval to 15us, loop 6,667 times to keep the polling timeout constant at 100ms.
--- cpu/mpc5xxx/i2c.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de God made machine language; all the rest is the work of man.