pvrusb2: Drop client_register/unregister stubs
PATCH 1/1 pvrusb2: Drop client_register/unregister stubs
The client_register and client_unregister methods are optional so there is no point in defining stub ones. Especially when these methods are likely to be removed soon.
Signed-off-by Jean Delvare <[email protected]>
--- linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c | 12 ------------ 1 file changed, 12 deletions(-)
linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c +0 -12
@@ -595,16 +595,6 @@ static u32 pvr2_i2c_functionality(structreturn I2C_FUNC_SMBUS_EMUL |I2C_FUNC_I2C ; } -static int pvr2_i2c_attach_inform (struct i2c_client *client) -{ -return 0 ; -} - -static int pvr2_i2c_detach_inform (struct i2c_client *client) -{ -return 0 ; -} -static struct i2c_algorithm pvr2_i2c_algo_template = { .master_xfer = pvr2_i2c_xfer, .functionality = pvr2_i2c_functionality,
@@ -617,8 +607,6 @@ static struct i2c_adapter pvr2_i2c_adap_ .owner = THIS_MODULE, .class = 0, .id = I2C_HW_B_BT848, - .client_register = pvr2_i2c_attach_inform, - .client_unregister = pvr2_i2c_detach_inform, };
Signature · 1 line
Jean Delvare
Acked-by Mike Isely <[email protected]>
Quoted 39 lines · Jean Delvare
The
client_registerandclient_unregistermethods are optional so there is no point in defining stub ones. Especially when these methods are likely to be removed soon.Signed-off-by Jean Delvare <[email protected]>--- linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c | 12 ------------ 1 file changed, 12 deletions(-)linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c +0
-12@@ -595,16 +595,6 @@ static u32 pvr2_i2c_functionality(structreturn I2C_FUNC_SMBUS_EMUL |I2C_FUNC_I2C ; } -static int pvr2_i2c_attach_inform (struct i2c_client *client) -{ -return 0 ; -} - -static int pvr2_i2c_detach_inform (struct i2c_client *client) -{ -return 0 ; -} -static struct i2c_algorithm pvr2_i2c_algo_template = { .master_xfer = pvr2_i2c_xfer, .functionality = pvr2_i2c_functionality,@@ -617,8 +607,6 @@ static struct i2c_adapter pvr2_i2c_adap_ .owner = THIS_MODULE, .class = 0, .id = I2C_HW_B_BT848, - .client_register = pvr2_i2c_attach_inform, - .client_unregister = pvr2_i2c_detach_inform, };
Signature · 3 lines
Mike Isely isely @ pobox (dot) com PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8