Completely decode instruction in decoding stage.
PATCH 1/3 Completely decode instruction in decoding stage.
After instruction decoding decode_cache.eip should point after instruction.
Signed-off-by Gleb Natapov <[email protected]>
---
arch/x86/kvm/x86_emulate.c | 107 ++++++++++++++++---------------------------- 1 files changed, 38 insertions(+), 69 deletions(-)
arch/x86/kvm/x86_emulate.c +38 -69
@@ -76,6 +76,7 @@#define Src2CL (1<<29)#define Src2ImmByte (2<<29)#define Src2One (3<<29) +#define Src2Imm16 (4<<29)#define Src2Mask (7<<29)enum {
@@ -135,8 +136,10 @@ static u32 opcode_table[256] = { SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps,/* insb, insw/insd */ SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps,/* outsb, outsw/outsd */ /* 0x70 - 0x77 */ - ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, - ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, + ImplicitOps | SrcImmByte, ImplicitOps | SrcImmByte, + ImplicitOps | SrcImmByte, ImplicitOps | SrcImmByte, + ImplicitOps | SrcImmByte, ImplicitOps | SrcImmByte, + ImplicitOps | SrcImmByte, ImplicitOps | SrcImmByte,/* 0x78 - 0x7F */ ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps,
@@ -153,7 +156,8 @@ static u32 opcode_table[256] = {/* 0x90 - 0x97 */ DstReg, DstReg, DstReg, DstReg, DstReg, DstReg, DstReg, DstReg,/* 0x98 - 0x9F */ -0 ,0 ,0 ,0 , ImplicitOps | Stack, ImplicitOps | Stack,0 ,0 , +0 ,0 , SrcImm | Src2Imm16,0 , ImplicitOps | Stack, ImplicitOps | Stack, +0 ,0 ,/* 0xA0 - 0xA7 */ ByteOp | DstReg | SrcMem | Mov | MemAbs, DstReg | SrcMem | Mov | MemAbs, ByteOp | DstMem | SrcReg | Mov | MemAbs, DstMem | SrcReg | Mov | MemAbs,
@@ -178,7 +182,8 @@ static u32 opcode_table[256] = {0 , ImplicitOps | Stack,0 ,0 , ByteOp | DstMem | SrcImm | ModRM | Mov, DstMem | SrcImm | ModRM | Mov,/* 0xC8 - 0xCF */ -0 ,0 ,0 , ImplicitOps | Stack,0 ,0 ,0 ,0 , +0 ,0 ,0 , ImplicitOps | Stack, ImplicitOps, SrcImmByte, ImplicitOps, + ImplicitOps,/* 0xD0 - 0xD7 */ ByteOp | DstMem | SrcImplicit | ModRM, DstMem | SrcImplicit | ModRM, ByteOp | DstMem | SrcImplicit | ModRM, DstMem | SrcImplicit | ModRM,
@@ -187,11 +192,13 @@ static u32 opcode_table[256] = {0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,/* 0xE0 - 0xE7 */ 0 ,0 ,0 ,0 , - SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps, - SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps, + SrcNone | ByteOp | SrcImmByte | ImplicitOps, + SrcNone | SrcImmByte | ImplicitOps, + SrcNone | ByteOp | SrcImmByte | ImplicitOps, + SrcNone | SrcImmByte | ImplicitOps,/* 0xE8 - 0xEF */ - ImplicitOps | Stack, SrcImm | ImplicitOps, - ImplicitOps, SrcImmByte | ImplicitOps, + SrcImm | ImplicitOps | Stack, SrcImm | ImplicitOps, + SrcImm | Src2Imm16 | ImplicitOps, SrcImmByte | ImplicitOps, SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps, SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps, /* 0xF0 - 0xF7 */
@@ -230,10 +237,12 @@ static u32 twobyte_table[256] = {/* 0x70 - 0x7F */ 0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,/* 0x80 - 0x8F */ - ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, - ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, - ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, - ImplicitOps, ImplicitOps, ImplicitOps, ImplicitOps, + SrcImm | ImplicitOps, SrcImm | ImplicitOps, SrcImm | ImplicitOps, + SrcImm | ImplicitOps, SrcImm | ImplicitOps, SrcImm | ImplicitOps, + SrcImm | ImplicitOps, SrcImm | ImplicitOps, SrcImm | ImplicitOps, + SrcImm | ImplicitOps, SrcImm | ImplicitOps, SrcImm | ImplicitOps, + SrcImm | ImplicitOps, SrcImm | ImplicitOps, SrcImm | ImplicitOps, + SrcImm | ImplicitOps,/* 0x90 - 0x9F */ 0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 ,0 , /* 0xA0 - 0xA7 */
@@ -1072,6 +1081,12 @@ done_prefixes: c->src2.bytes =1 ; c->src2.val =insn_fetch (u8,1 , c->eip);break ; +case Src2Imm16: + c->src2.type =OP_IMM ; + c->src2.ptr = (unsigned long *)c->eip; + c->src2.bytes =2 ; + c->src2.val =insn_fetch (u16,2 , c->eip); +break ;case Src2One: c->src2.bytes =1 ; c->src2.val =1 ;
@@ -1531,13 +1546,10 @@ special_insn:return -1 ; }return 0 ; - case 0x70 ... 0x7f: /* jcc (short) */ { -int rel =insn_fetch (s8,1 , c->eip); - + case 0x70 ... 0x7f: /* jcc (short) */if (test_cc (c->b, ctxt->eflags)) -jmp_rel (c, rel); +jmp_rel (c, c->src.val);break ; - } case 0x80 ... 0x83: /* Grp1 */switch (c->modrm_reg) {case 0 :
@@ -1769,27 +1781,16 @@ special_insn:break ;case 0xe4 :/* inb */ case 0xe5 :/* in */ - port =insn_fetch (u8,1 , c->eip); + port = c->src.val; io_dir_in =1 ; goto do_io;case 0xe6 :/* outb */ case 0xe7 :/* out */ - port =insn_fetch (u8,1 , c->eip); + port = c->src.val; io_dir_in =0 ; goto do_io;case 0xe8 :/* call (near) */ { -long int rel; -switch (c->op_bytes) { -case 2 : - rel =insn_fetch (s16,2 , c->eip); -break ; -case 4 : - rel =insn_fetch (s32,4 , c->eip); -break ; -default : -DPRINTF ("Call: Invalid op_bytes\n" ); - goto cannot_emulate; - } +long int rel = c->src.val; c->src.val = (unsigned long ) c->eip;jmp_rel (c, rel);emulate_push (ctxt);
@@ -1797,30 +1798,15 @@ special_insn: }case 0xe9 :/* jmp rel */ goto jmp; -case 0xea :/* jmp far */ { -uint32_t eip; -uint16_t sel; - -switch (c->op_bytes) { -case 2 : - eip =insn_fetch (u16,2 , c->eip); -break ; -case 4 : - eip =insn_fetch (u32,4 , c->eip); -break ; -default : -DPRINTF ("jmp far: Invalid op_bytes\n" ); - goto cannot_emulate; - } - sel =insn_fetch (u16,2 , c->eip); -if (kvm_load_segment_descriptor (ctxt->vcpu, sel,9 ,VCPU_SREG_CS ) <0 ) { +case 0xea :/* jmp far */ +if (kvm_load_segment_descriptor (ctxt->vcpu, c->src2.val,9 , +VCPU_SREG_CS ) <0 ) {DPRINTF ("jmp far: Failed to load CS descriptor\n" ); goto cannot_emulate; } - c->eip = eip; + c->eip = c->src.val;break ; - }case 0xeb : jmp:/* jmp rel short */ jmp_rel (c, c->src.val);
@@ -2038,28 +2024,11 @@ twobyte_insn:if (!test_cc (c->b, ctxt->eflags)) c->dst.type =OP_NONE ;/* no writeback */ break ; - case 0x80 ... 0x8f: /* jnz rel, etc*/ { -long int rel; - -switch (c->op_bytes) { -case 2 : - rel =insn_fetch (s16,2 , c->eip); -break ; -case 4 : - rel =insn_fetch (s32,4 , c->eip); -break ; -case 8 : - rel =insn_fetch (s64,8 , c->eip); -break ; -default : -DPRINTF ("jnz: Invalid op_bytes\n" ); - goto cannot_emulate; - } + case 0x80 ... 0x8f: /* jnz rel, etc*/if (test_cc (c->b, ctxt->eflags)) -jmp_rel (c, rel); +jmp_rel (c, c->src.val); c->dst.type =OP_NONE ;break ; - }case 0xa3 : bt:/* bt */ c->dst.type =OP_NONE ;
PATCH 2/3 Add new mode of instruction emulation: skip.
In the new mode instruction is decoded, but not executed. The EIP is moved to point after the instruction.
Signed-off-by Gleb Natapov <[email protected]>
---
arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/x86.c | 5 +++++ 2 files changed, 6 insertions(+), 0 deletions(-)
arch/x86/include/asm/kvm_host.h +1 -0
@@ -565,6 +565,7 @@ enum emulation_result {#define EMULTYPE_NO_DECODE (1 << 0)#define EMULTYPE_TRAP_UD (1 << 1) +#define EMULTYPE_SKIP (1 << 2)int emulate_instruction (struct kvm_vcpu *vcpu,struct kvm_run *run,unsigned long cr2,u16 error_code,int emulation_type);void kvm_report_emulation_failure (struct kvm_vcpu *cvpu,const char *context);
arch/x86/kvm/x86.c +5 -0
@@ -2411,6 +2411,11 @@ int emulate_instruction(struct kvm_vcpu *vcpu, } } +if (emulation_type &EMULTYPE_SKIP ) { +kvm_rip_write (vcpu, vcpu->arch.emulate_ctxt.decode.eip); +return EMULATE_DONE ; + } + r =x86_emulate_insn (&vcpu->arch.emulate_ctxt, &emulate_ops);if (vcpu->arch.pio.string)
PATCH 3/3 Skip instruction on a task switch only when appropriate.
In reply to Gleb NatapovIf a task switch was initiated because off a task gate in IDT and IDT was accessed because of an external even the instruction should not be skipped.
Signed-off-by Gleb Natapov <[email protected]>
---
arch/x86/kvm/svm.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-)
arch/x86/kvm/svm.c +9 -2
@@ -1826,6 +1826,7 @@ static int task_switch_interception(struct vcpu_svm *svm,int reason;int int_type = svm->vmcb->control.exit_int_info &SVM_EXITINTINFO_TYPE_MASK ; +int int_vec = svm->vmcb->control.exit_int_info &SVM_EVTINJ_VEC_MASK ; tss_selector = (u16 )svm->vmcb->control.exit_info_1;
@@ -1841,8 +1842,14 @@ static int task_switch_interception(struct vcpu_svm *svm, reason =TASK_SWITCH_CALL ; -if (reason !=TASK_SWITCH_GATE || int_type ==SVM_EXITINTINFO_TYPE_SOFT ) -skip_emulated_instruction (&svm->vcpu); +if (reason !=TASK_SWITCH_GATE || + int_type ==SVM_EXITINTINFO_TYPE_SOFT || + (int_type ==SVM_EXITINTINFO_TYPE_EXEPT && + (int_vec ==OF_VECTOR || int_vec ==BP_VECTOR ))) { +if (emulate_instruction (&svm->vcpu, kvm_run,0 ,0 , +EMULTYPE_SKIP ) !=EMULATE_DONE ) +return 0 ; + }return kvm_task_switch (&svm->vcpu, tss_selector, reason); }