Skip to contentSkip to conversation

Convert CONFIG_SMP=y powerpc defconfigs to TREE_RCU.

PATCH Josh Boyer 4 participants 12 messages Apr 4, 2009 – Apr 8, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 3181463559098978317@unknownmsgid

Josh Boyer

author
#1 lore raw
Quoted 2 lines · Paul E. McKenney

From: Paul E. McKenney <[email protected]>

Why would one want to do this? The commit log doesn't explain the switch and why it's great. Mostly because the commit log doesn't exist. (I'll stop channeling Andrew now)

It also might be a good idea to CC the linuxppc-dev list for this patch. Or at least Kumar for the mpc86xx changes.

josh

#2 lore raw
Quoted 7 lines · Josh Boyer
Quoted 1 line · Paul E. McKenney

From: Paul E. McKenney <[email protected]>

Why would one want to do this? The commit log doesn't explain the switch and why it's great. Mostly because the commit log doesn't exist. (I'll stop channeling Andrew now)

Indeed, I am sure that I will get the hang the relevant git commands at some point, but clearly am not yet there.

The thing that is great about this patch is that it is a step on the way to retiring Classic RCU entirely.

Quoted 2 lines

It also might be a good idea to CC the linuxppc-dev list for this patch. Or at least Kumar for the mpc86xx changes.

Good point -- I will do so on the next version.

Thanx, Paul

#3 lore raw
Quoted 9 lines · Paul E. McKenney
Quoted 7 lines · Josh Boyer
Quoted 1 line · Paul E. McKenney

From: Paul E. McKenney <[email protected]>

Why would one want to do this? The commit log doesn't explain the switch and why it's great. Mostly because the commit log doesn't exist. (I'll stop channeling Andrew now)

Quoted 5 lines

Indeed, I am sure that I will get the hang the relevant git commands at some point, but clearly am not yet there.

The thing that is great about this patch is that it is a step on the way to retiring Classic RCU entirely.

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

Ingo

#4 lore raw
Quoted 3 lines

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

AFAIK they don't. There's no make updatemyconfigwithdefaultstatementsconfig

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only.
#5 lore raw
Quoted 5 lines · Andi Kleen
Quoted 3 lines

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

AFAIK they don't. There's no make updatemyconfigwithdefaultstatementsconfig

My guess is that I would in fact have to send a few patches. But I suppose that the real question is "how long should we wait to drop Classic RCU once the last arch has changed its defconfig?" I have been assuming that we would wait one release cycle.

Thanx, Paul

#6 lore raw
Quoted 11 lines · Paul E. McKenney
Quoted 5 lines · Andi Kleen
Quoted 3 lines

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

AFAIK they don't. There's no make updatemyconfigwithdefaultstatementsconfig

My guess is that I would in fact have to send a few patches. But I suppose that the real question is "how long should we wait to drop Classic RCU once the last arch has changed its defconfig?" I have been assuming that we would wait one release cycle.

I don't think you have to wait, stale entries in defconfigs happen all the time and Kconfig just asks then.

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only.
#7 lore raw
Quoted 8 lines · Andi Kleen
Quoted 7 lines · Paul E. McKenney
Quoted 5 lines · Andi Kleen
Quoted 3 lines

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

AFAIK they don't. There's no make updatemyconfigwithdefaultstatementsconfig

Quoted 7 lines
Quoted 4 lines

My guess is that I would in fact have to send a few patches. But I suppose that the real question is "how long should we wait to drop Classic RCU once the last arch has changed its defconfig?" I have been assuming that we would wait one release cycle.

I don't think you have to wait, stale entries in defconfigs happen all the time and Kconfig just asks then.

Good point!

Thanx, Paul

#8 lore raw
In reply to Ingo Molnar
Quoted 15 lines · Ingo Molnar
Quoted 12 lines · Paul E. McKenney
Quoted 7 lines · Josh Boyer
Quoted 1 line · Paul E. McKenney

From: Paul E. McKenney <[email protected]>

Why would one want to do this? The commit log doesn't explain the switch and why it's great. Mostly because the commit log doesn't exist. (I'll stop channeling Andrew now)

Indeed, I am sure that I will get the hang the relevant git commands at some point, but clearly am not yet there.

Quoted 6 lines
Quoted 2 lines

The thing that is great about this patch is that it is a step on the way to retiring Classic RCU entirely.

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

I am of course personally quite happy with this approach in the short term, as I would only need to worry about one patch.

My one concern would be that we cannot retire Classic RCU until all the arch maintainers remove CONFIG_CLASSIC_RCU=y from their defconfig files. However, given that the attached script suffices, I am not too worried about that.

Of course, none of this matters unless people agree that Tree RCU has proven reliable enough to be made default. So, any objections to such a change at this point?

Thanx, Paul

#9 lore raw
Quoted 23 lines · Paul E. McKenney
Quoted 15 lines · Ingo Molnar
Quoted 12 lines · Paul E. McKenney
Quoted 7 lines · Josh Boyer
Quoted 1 line · Paul E. McKenney

From: Paul E. McKenney <[email protected]>

Why would one want to do this? The commit log doesn't explain the switch and why it's great. Mostly because the commit log doesn't exist. (I'll stop channeling Andrew now)

Indeed, I am sure that I will get the hang the relevant git commands at some point, but clearly am not yet there.

Quoted 6 lines
Quoted 2 lines

The thing that is great about this patch is that it is a step on the way to retiring Classic RCU entirely.

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

Quoted 7 lines

I am of course personally quite happy with this approach in the short term, as I would only need to worry about one patch.

My one concern would be that we cannot retire Classic RCU until all the arch maintainers remove CONFIG_CLASSIC_RCU=y from their defconfig files. However, given that the attached script suffices, I am not too worried about that.

ah, that's not a real concern. Most defconfigs are stale all the time, and arch maintainers typically refresh them at around rc7. (if at all) Kconfig will warn about (and ignore) stale entries.

So no, there's no requirement to touch defconfigs - to the contrary:
it has way too wide of a cross section with other trees to be really practical to carry in the RCU tree.

Ingo

#10 lore raw
Quoted 34 lines · Ingo Molnar
Quoted 23 lines · Paul E. McKenney
Quoted 15 lines · Ingo Molnar
Quoted 12 lines · Paul E. McKenney
Quoted 7 lines · Josh Boyer
Quoted 1 line · Paul E. McKenney

From: Paul E. McKenney <[email protected]>

Why would one want to do this? The commit log doesn't explain the switch and why it's great. Mostly because the commit log doesn't exist. (I'll stop channeling Andrew now)

Indeed, I am sure that I will get the hang the relevant git commands at some point, but clearly am not yet there.

Quoted 6 lines
Quoted 2 lines

The thing that is great about this patch is that it is a step on the way to retiring Classic RCU entirely.

I'd suggest you dont do these dozens of defconfig updates at all - arch maintainers can do this themselves, once the core kernel default has been flipped.

Quoted 7 lines

I am of course personally quite happy with this approach in the short term, as I would only need to worry about one patch.

My one concern would be that we cannot retire Classic RCU until all the arch maintainers remove CONFIG_CLASSIC_RCU=y from their defconfig files. However, given that the attached script suffices, I am not too worried about that.

Quoted 7 lines

ah, that's not a real concern. Most defconfigs are stale all the time, and arch maintainers typically refresh them at around rc7. (if at all) Kconfig will warn about (and ignore) stale entries.

So no, there's no requirement to touch defconfigs - to the contrary:
it has way too wide of a cross section with other trees to be really practical to carry in the RCU tree.

Sounds good to me!!! So, is http://lkml.org/lkml/2009/4/3/561
sufficient, or should I repost?

Thanx, Paul

#11 lore raw
Quoted 6 lines · Paul E. McKenney
Quoted 3 lines

So no, there's no requirement to touch defconfigs - to the
contrary: it has way too wide of a cross section with other trees to be really practical to carry in the RCU tree.

Sounds good to me!!! So, is http://lkml.org/lkml/2009/4/3/561
sufficient, or should I repost?

I have queued up your patch:

31c9a24: RCU: make treercu be default

... a week ago :-)

Ingo

#12 lore raw
Quoted 7 lines · Ingo Molnar
Quoted 4 lines · Paul E. McKenney
Quoted 3 lines

So no, there's no requirement to touch defconfigs - to the
contrary: it has way too wide of a cross section with other trees to be really practical to carry in the RCU tree.

Quoted 8 lines
Quoted 2 lines

Sounds good to me!!! So, is http://lkml.org/lkml/2009/4/3/561
sufficient, or should I repost?

I have queued up your patch:

31c9a24: RCU: make treercu be default

... a week ago :-)

Color me slow, stupid, and oblivious! ;-)

Thank you for applying it!

Thanx, Paul