Skip to contentSkip to conversation

omap_hsmmc: Flush posted write to IRQ

PATCH In review Adrian Hunter 3 participants 4 messages Apr 6, 2009 – Apr 8, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap_hsmmc: Flush posted write to IRQ

From: Kevin Hilman <[email protected]>

Spurious IRQs seen on MMC after 2.6.29. Flush posted write in IRQ handler.

The interrupt line is released by clearing the error status bits in the MMCHS_STAT register, which must occur before the interrupt handler returns to avoid unwanted irqs. Hence the need to flush the posted write.

---

This patch is slightly modified from Kevin's original, which is here:

	http://marc.info/?l=linux-omap&m=123862814815052&w=2

drivers/mmc/host/omap_hsmmc.c | 4 ++++

1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mmc/host/omap_hsmmc.c +0 -0
index 04e5a0c..2ae6049 100644
@@ -452,6 +452,8 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
	if (host->mrq == NULL) {
		OMAP_HSMMC_WRITE(host->base, STAT,
			OMAP_HSMMC_READ(host->base, STAT));
+		/* Flush posted write */
+		OMAP_HSMMC_READ(host->base, STAT);
		return IRQ_HANDLED;
	}

@@ -523,6 +525,8 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)

	}

	OMAP_HSMMC_WRITE(host->base, STAT, status);

+ /* Flush posted write */
+ OMAP_HSMMC_READ(host->base, STAT);

	if (end_cmd || (status & CC))
		mmc_omap_cmd_done(host, host->cmd);
Signature · 1 line
1.5.6.3
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Adrian Hunter

From: Kevin Hilman <[email protected]>

Spurious IRQs seen on MMC after 2.6.29. Flush posted write in IRQ handler.

Quoted 7 lines

The interrupt line is released by clearing the error status bits in the MMCHS_STAT register, which must occur before the interrupt handler returns to avoid unwanted irqs. Hence the need to flush the posted write.

Quoted 39 lines

---

This patch is slightly modified from Kevin's original, which is here:

	http://marc.info/?l=linux-omap&m=123862814815052&w=2

drivers/mmc/host/omap_hsmmc.c | 4 ++++

1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mmc/host/omap_hsmmc.c +4 -0
index 04e5a0c..2ae6049 100644
@@ -452,6 +452,8 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
 	if (host->mrq == NULL) {
 		OMAP_HSMMC_WRITE(host->base, STAT,
 			OMAP_HSMMC_READ(host->base, STAT));
+		/* Flush posted write */
+		OMAP_HSMMC_READ(host->base, STAT);
 		return IRQ_HANDLED;
 	}
 
@@ -523,6 +525,8 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
 	}
 
 	OMAP_HSMMC_WRITE(host->base, STAT, status);
+	/* Flush posted write */
+	OMAP_HSMMC_READ(host->base, STAT);
 
 	if (end_cmd || (status & CC))
 		mmc_omap_cmd_done(host, host->cmd);
Signature · 1 line
1.5.6.3
#2 lore raw
Quoted 11 lines · On Mon, 6 Apr 2009 09:49:18 -0700 Tony Lindgren <[email protected]> wrote:
Quoted 10 lines · Adrian Hunter

From: Kevin Hilman <[email protected]>

Spurious IRQs seen on MMC after 2.6.29. Flush posted write in IRQ handler.

The interrupt line is released by clearing the error status bits in the MMCHS_STAT register, which must occur before the interrupt handler returns to avoid unwanted irqs. Hence the need to flush the posted write.

Quoted 5 lines
Quoted 2 lines

Queued.

Signature · 6 lines
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.