Skip to contentSkip to conversation

Add support to Colibri PXA-270 board

PATCH New Alon Bar-Lev 2 participants 6 messages Apr 7, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add support to Colibri PXA-270 board

This configuration is based on the trizepsiv board, and the work Daniel Mack did in the past [1].

The following files were taken as-is from trizepsiv board:
- lowlevel_init.S
- pxavoltage.S
- u-boot.lds

The main module is the same except it does not use multi serial and does not have usb support.

The configuration is based on Daniel Mack work, with zeros when trizepsiv required configuration while Daniel did not provide any.

After modification, u-boot is running, can access the on-board flash, can access network using Ethernet and can boot Linux kernel.

Although there are few colibri boards, the name "colibri" for the board is the same as the name the linux kernel has for the Colibri PXA-270 board.

[1] http://www.mail-archive.com/u-boot-users%40lists.sourceforge.net/msg01498.html

---

Makefile +3 -0
index 49b83c0..4e5e290 100644
@@ -3039,6 +3039,9 @@ pxa255_idp_config:	unconfig
 trizepsiv_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm pxa trizepsiv
 
+colibri_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm pxa colibri
+
 wepep250_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm pxa wepep250
 
board/colibri/Makefile new file +51 -0

51 lines not on this page · raw message

board/colibri/colibri.c new file +74 -0

74 lines not on this page · raw message

board/colibri/config.mk new file +3 -0
new file mode 100644
index 0000000..4486f6b
@@ -0,0 +1,3 @@
+TEXT_BASE =0xa1f00000
+# 0xa1700000
+#TEXT_BASE = 0
board/colibri/lowlevel_init.S new file +503 -0

503 lines not on this page · raw message

board/colibri/pxavoltage.S new file +29 -0
new file mode 100644
index 0000000..9659c2b
@@ -0,0 +1,29 @@
+/*
+ * (C) Copyright 2007
+ * Stefano Babic, DENX Gmbh, sbabic at denx.de
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <asm/arch/pxa-regs.h>
+
+		.global	initPXAvoltage
+
+initPXAvoltage:
+		mov	pc, lr
board/colibri/u-boot.lds new file +56 -0

56 lines not on this page · raw message

include/configs/colibri.h new file +280 -0

280 lines not on this page · raw message

#1 lore raw

PATCH 1/1 Add support to Colibri PXA-270 board

Hi Alon,

a new board port without a single (C)opyright by your name - must have been a hard day copying ;)

Quoted 7 lines

This configuration is based on the trizepsiv board, and the work Daniel Mack did in the past [1].

The following files were taken as-is from trizepsiv board:
- lowlevel_init.S
- pxavoltage.S
- u-boot.lds

Isn't this a clear sign to try and find a way to reuse the code for both boards? Simply copying a file verbatim is always a mistake. Who will copy the bugfixes in the future?

I added Stefano on CC, maybe he has some good input on how to share code here.

Cheers
Detlev

Signature · 7 lines
Today people don't go to rock concerts to listen to the music, because
you can't. They go there to be part of the environment.
                                       -- Peter Eisenman
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#2 lore raw

PATCH 1/1 Add support to Colibri PXA-270 board

Hello,

It was not my intention to add publicity my name, but provide a solution for users, as it took a lot of work to make it work without many changes from other implementation.

Any way to do it using a reuse would be super, although this is not the only duplication in u-boot board tree...

Alon.

Quoted 32 lines · Detlev Zundel

Hi Alon,

a new board port without a single (C)opyright by your name - must have been a hard day copying ;)

Quoted 7 lines

This configuration is based on the trizepsiv board, and the work Daniel Mack did in the past [1].

The following files were taken as-is from trizepsiv board:
?- lowlevel_init.S
?- pxavoltage.S
?- u-boot.lds

Isn't this a clear sign to try and find a way to reuse the code for both boards? ?Simply copying a file verbatim is always a mistake. ?Who will copy the bugfixes in the future?

I added Stefano on CC, maybe he has some good input on how to share code here.

Cheers
?Detlev

--
Today people don't go to rock concerts to listen to the music, because you can't. They go there to be part of the environment.
? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? -- Peter Eisenman
--
DENX Software Engineering GmbH, ? ? ?MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, ?Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

#3 lore raw

PATCH 1/1 Add support to Colibri PXA-270 board

Hi Alon,

Quoted 3 lines

It was not my intention to add publicity my name, but provide a solution for users, as it took a lot of work to make it work without many changes from other implementation.

Adding someones name to code that one has written is primarily not for publicity reasons but for somple tracking reasons. Who do you think people will turn to if they see problems in the code? What would you say if someone mailed you about a problem in "your" code which you have never seen before?

Quoted 2 lines

Any way to do it using a reuse would be super, although this is not the only duplication in u-boot board tree...

Yes, and maybe you realize how *damn* (sorry) some of us work to eliminate this. I never tire of stating that the cost of fixing a problem in software is exponential to the time of its discovery.

Translated into U-Boot context this means, that we do *not* allow simple code duplication. If such a case slips through the review process, this is nowhere near a reason to allow it the next time.

So please, reconsider adding to the mess instead of decreasing it or even keeping the mess-level constant ;)

Cheers
Detlev

Signature · 7 lines
The 82558 B-step and later generation devices do not maintain a link
in D3 if PME is disabled or if the device does not have power.
                                        -- Intel documentation
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#4 lore raw

PATCH 1/1 Add support to Colibri PXA-270 board

I don't understand why you are so angry...
There is no simple implementation of code reuse within the boards. You know the code much better than I do.
Please free to drop this implementation.

Alon.

Quoted 38 lines · Detlev Zundel

Hi Alon,

Quoted 3 lines

It was not my intention to add publicity my name, but provide a solution for users, as it took a lot of work to make it work without many changes from other implementation.

Adding someones name to code that one has written is primarily not for publicity reasons but for somple tracking reasons. ?Who do you think people will turn to if they see problems in the code? ?What would you say if someone mailed you about a problem in "your" code which you have never seen before?

Quoted 2 lines

Any way to do it using a reuse would be super, although this is not the only duplication in u-boot board tree...

Yes, and maybe you realize how *damn* (sorry) some of us work to eliminate this. ?I never tire of stating that the cost of fixing a problem in software is exponential to the time of its discovery.

Translated into U-Boot context this means, that we do *not* allow simple code duplication. ?If such a case slips through the review process, this is nowhere near a reason to allow it the next time.

So please, reconsider adding to the mess instead of decreasing it or even keeping the mess-level constant ;)

Cheers
?Detlev

--
The 82558 B-step and later generation devices do not maintain a link in D3 if PME is disabled or if the device does not have power. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?-- Intel documentation --
DENX Software Engineering GmbH, ? ? ?MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, ?Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

#5 lore raw

PATCH 1/1 Add support to Colibri PXA-270 board

Hi Alon,

Quoted 1 line

I don't understand why you are so angry...

Maybe because you misunderstood me. Let me assure you, that I'm not angry. I only wanted to make a clear statement that there are people on this list who spend really lots of time in the "unsexy job" of cleaning up code.

This usually takes way longer than writing new code and of course this is also completely invisible to the casual reader of the sorce code. One also never gets any return from it, because one "does not add any new shiny features".

Because of this, not many people attend to this type of work, so what I try to do is to ensure that we *need as few cleanup as possible* right upfront.

Quoted 1 line

There is no simple implementation of code reuse within the boards.

Are you sure? You did not look very hard then. In a strict sense it may be true that "board directories" do not share much code (although even that is done by some), but this is missing the point.

If something proves to be board-independent, it usually means it is only architecture specific, so it can go there and be reused by *all* boards of that architecture.

Quoted 2 lines

You know the code much better than I do.
Please free to drop this implementation.

Oh please, we really value all contributions, but if we were to accept everything unconditionally, the code would explode in no time.

Please reconsider and try to reuse the code instead of copying it. Maybe put it into pxa270 specific places. Maybe Stefano has some good ideas?

Cheers
Detlev

Signature · 5 lines
Markov does it in chains.
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de