Skip to contentSkip to conversation

net: netif_device_attach/detach should start/stop all queues

PATCH Applied Jeff Kirsher 2 participants 2 messages Apr 9, 2009 – Apr 11, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: netif_device_attach/detach should start/stop all queues

From: Alexander Duyck <[email protected]>

Currently netif_device_attach/detach are only stopping one queue. They should be starting and stopping all the queues on a given device.

---

 net/core/dev.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
net/core/dev.c +2 -2
index 91d792d..ea8eb22 100644
@@ -1430,7 +1430,7 @@ void netif_device_detach(struct net_device *dev)
 {
 	if (test_and_clear_bit(__LINK_STATE_PRESENT, &dev->state) &&
 	    netif_running(dev)) {
-		netif_stop_queue(dev);
+		netif_tx_stop_all_queues(dev);
 	}
 }
 EXPORT_SYMBOL(netif_device_detach);
@@ -1445,7 +1445,7 @@ void netif_device_attach(struct net_device *dev)
 {
 	if (!test_and_set_bit(__LINK_STATE_PRESENT, &dev->state) &&
 	    netif_running(dev)) {
-		netif_wake_queue(dev);
+		netif_tx_wake_all_queues(dev);
 		__netdev_watchdog_up(dev);
 	}
 }