Skip to contentSkip to conversation

reiserfs: fix printk format warning

PATCH In review Alexander Beregalov 2 participants 2 messages Apr 3, 2009 – Apr 9, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reiserfs: fix printk format warning

Fix following warning message
fs/reiserfs/procfs.c:393: warning: format '%u' expects type 'unsigned int', but argument 22 has type 'long unsigned int' introduced in 600ed4167
(reiserfs: audit transaction ids to always be unsigned ints)

---

 include/linux/reiserfs_fs_sb.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/reiserfs_fs_sb.h +1 -1
index 5621d87..1d1594a 100644
@@ -193,7 +193,7 @@ struct reiserfs_journal {
 	atomic_t j_wcount;	/* count of writers for current commit */
 	unsigned long j_bcount;	/* batch count. allows turning X transactions into 1 */
 	unsigned long j_first_unflushed_offset;	/* first unflushed transactions offset */
-	unsigned long j_last_flush_trans_id;	/* last fully flushed journal timestamp */
+	unsigned int j_last_flush_trans_id;	/* last fully flushed journal timestamp */
 	struct buffer_head *j_header_bh;
 
 	time_t j_trans_start_time;	/* time this transaction started */
#1 lore raw
Quoted 16 lines · On Fri, 3 Apr 2009 05:34:37 +0400 Alexander Beregalov <[email protected]>…

Fix following warning message
fs/reiserfs/procfs.c:393: warning: format '%u' expects type 'unsigned int', but argument 22 has type 'long unsigned int' introduced in 600ed4167
(reiserfs: audit transaction ids to always be unsigned ints)

---

 include/linux/reiserfs_fs_sb.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/reiserfs_fs_sb.h +0 -0
index 5621d87..1d1594a 100644

include/linux/reiserfs_fs_sb.h struct reiserfs_journal { · line 199

Quoted 8 lines
include/linux/reiserfs_fs_sb.h +1 -1
@@ -193,7 +193,7 @@ struct reiserfs_journal {
 	atomic_t j_wcount;	/* count of writers for current commit */
 	unsigned long j_bcount;	/* batch count. allows turning X transactions into 1 */
 	unsigned long j_first_unflushed_offset;	/* first unflushed transactions offset */
-	unsigned long j_last_flush_trans_id;	/* last fully flushed journal timestamp */
+	unsigned int j_last_flush_trans_id;	/* last fully flushed journal timestamp */
 	struct buffer_head *j_header_bh;
 
 	time_t j_trans_start_time;	/* time this transaction started */

Yes, looking at the code I think it does want to be a u32.