Skip to contentSkip to conversation

dell-wmi: support additional keys

PATCH NAK [email protected] 3 participants 3 messages Apr 11, 2009 – Apr 15, 2009

Subsystems (2)
ACPI x86 platform drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 4/4 dell-wmi: support additional keys

From: Rafi Rubin <[email protected]>

Added key codes generated by screen rotation on the Latitude XT. 0xe046 is sent when changing to tablet mode, and 0xe047 when it returns to desktop mode.

Signed-off-by Rafi Rubin <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Len Brown <[email protected]>
Cc Eric Piel <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/platform/x86/dell-wmi.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/platform/x86/dell-wmi.c renamed from drivers/platform/x86/dell-wmi.c~dell-wmi-support-additional-keys +2 -0
diff -puN drivers/platform/x86/dell-wmi.c~dell-wmi-support-additional-keys drivers/platform/x86/dell-wmi.c
@@ -50,6 +50,8 @@ enum { KE_KEY, KE_SW, KE_END };
 
 static struct key_entry dell_wmi_keymap[] = {
 	{KE_KEY, 0xe045, KEY_PROG1},
+	{KE_KEY, 0xe046, KEY_PROG2},
+	{KE_KEY, 0xe047, KEY_PROG3},
 	{KE_END, 0}
 };

_

#1 lore raw
Quoted 11 lines · On Fri, Apr 10, 2009 at 11:16:32PM -0700, [email protected] wrote:

From: Rafi Rubin <[email protected]>

Added key codes generated by screen rotation on the Latitude XT. 0xe046 is sent when changing to tablet mode, and 0xe047 when it returns to desktop mode.

Signed-off-by Rafi Rubin <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Len Brown <[email protected]>
Cc Eric Piel <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

I don't like this - it should really be using the switch event, not sending random programmable buttons.

Signature · 1 line
Matthew Garrett | [email protected]
reviewer
#2 lore raw
Quoted 7 lines
Quoted 4 lines

Added key codes generated by screen rotation on the Latitude XT. 0xe046 is sent when changing to tablet mode, and 0xe047 when it returns to desktop mode.

I don't like this - it should really be using the switch event, not sending random programmable buttons.

http://patchwork.kernel.org/patch/17707/
is now set to "rejected".

thanks,
Len Brown, Intel Open Source Technology Center