Skip to contentSkip to conversation

listcontrol.c

DISCUSSION Pavel Kolář 2 participants 2 messages Apr 11, 2009

lore
Share & tools
lore
#0 lore raw

The line 719 in listcontrol.c (version 1.2.16) contains strcmp. Is it really the author intention (security?)? Otherwise, I would suggest to use strcasecmp instead. (i.e. to allow the mixed case in the owner addresss for the message to listname+list@...)

Regards

Signature · 1 line
Pavel Kolar
#1 lore raw
Quoted 4 lines · Pavel Kolář

The line 719 in listcontrol.c (version 1.2.16) contains strcmp. Is it really the author intention (security?)? Otherwise, I would suggest to use strcasecmp instead. (i.e. to allow the mixed case in the owner addresss for the message to listname+list@...)

It's a safe strcmp, yes.

fromemails->emaillist[0] cannot not exist if we get this far, and owners->strs was just populated right before the for-loop:

owners = ctrlvalues(listdir, "owner");

So it's ok to use strcasecmp instead, and I've just done so and com- mitted to CVS. Thanks for spotting!

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
  and totally illogical, with just a little bit more effort?"
                                  -- A. P. J.