Skip to contentSkip to conversation

Simple glibc-based external toolchain support

Buildroot Thomas Petazzoni 2 participants 5 messages Apr 13, 2009 – Apr 15, 2009

lore
Share & tools
lore
#0 lore raw

xSimple glibc-based external toolchain support

The current Buildroot works just well with sysrootable glibc toolchains, using the external toolchain feature. The only thing that needs to be customized is the set of libraries that must be compiled to the target.

The following patch takes a simple approach to making it easier for users to use glibc toolchains. It just adds a uClibc/glibc choice in the external toolchain menu. Then, depending on that selection, the configuration system will choose a sane default value for the library files list.

The other advantage of having a uClibc/glibc choice is that in the future, we'll be able to add checks verifying that the external toolchain configuration matches the features selected in Buildroot (in terms of IPv6, RPC, locales or large file support).

---
 toolchain/external-toolchain/Config.in |   22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)
toolchain/external-toolchain/Config.in +20 -2
Index: buildroot/toolchain/external-toolchain/Config.in
===================================================================
@@ -1,9 +1,24 @@
 #
 
 if BR2_TOOLCHAIN_EXTERNAL
+choice
+	prompt "External toolchain C library"
+	default BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+
+config BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+	bool "uClibc"
+
+config BR2_TOOLCHAIN_EXTERNAL_GLIBC
+	bool "glibc"
+
+endchoice
+
+menu "Library files"
+
 config BR2_TOOLCHAIN_EXTERNAL_LIB_C
 	string "The core C library from the external toolchain"
-	default "libc.so.0"
+	default "libc.so.0" if BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+	default "libc.so.6" if BR2_TOOLCHAIN_EXTERNAL_GLIBC
 	help
 	  Specify the core C shared library found in the external
 	  toolchain. This is required in addition to any other
@@ -11,13 +26,16 @@
 
 config BR2_TOOLCHAIN_EXTERNAL_LIBS
 	string "Libraries to copy from the external toolchain"
-	default "ld-uClibc.so.0 libcrypt.so.0 libdl.so.0 libgcc_s.so libm.so.0 libnsl.so.0 libpthread.so.0 libresolv.so.0 librt.so.0 libutil.so.0"
+	default "ld-uClibc.so.0 libcrypt.so.0 libdl.so.0 libgcc_s.so libm.so.0 libnsl.so.0 libpthread.so.0 libresolv.so.0 librt.so.0 libutil.so.0" if BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+	default "ld-linux.so.3 libcrypt.so.1 libdl.so.2 libgcc_s.so.1 libm.so.6 libnsl.so.1 libpthread.so.0 libresolv.so.2 librt.so.1 libutil.so.1 libnss_files.so.2" if BR2_TOOLCHAIN_EXTERNAL_GLIBC
 	help
 	  A space separated list of the shared libraries to be copied
 	  from the external toolchain into the root filesystem. Only
 	  the top-level name is needed, i.e. libc.so, libpthread.so as
 	  the actual shared library symlinked to will be copied also.
 
+endmenu
+
 config BR2_TOOLCHAIN_EXTERNAL_STRIP
         bool
         default y
Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
#1 lore raw

Hi,

Any opinion on this ? I'm adding Grant Likely to the Cc: list because he showed interest in having support for external Glibc toolchains in Buildroot.

Sincerly,

Thomas

Le Mon, 13 Apr 2009 22:12:19 +0200,
Thomas Petazzoni <[email protected]> a ?crit :

Quoted 77 lines

xSimple glibc-based external toolchain support

The current Buildroot works just well with sysrootable glibc toolchains, using the external toolchain feature. The only thing that needs to be customized is the set of libraries that must be compiled to the target.

The following patch takes a simple approach to making it easier for users to use glibc toolchains. It just adds a uClibc/glibc choice in the external toolchain menu. Then, depending on that selection, the configuration system will choose a sane default value for the library files list.

The other advantage of having a uClibc/glibc choice is that in the future, we'll be able to add checks verifying that the external toolchain configuration matches the features selected in Buildroot (in terms of IPv6, RPC, locales or large file support).

---
 toolchain/external-toolchain/Config.in |   22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

Index: buildroot/toolchain/external-toolchain/Config.in
===================================================================

toolchain/external-toolchain/Config.in +16 -2
@@ -1,9 +1,24 @@
 #
 
 if BR2_TOOLCHAIN_EXTERNAL
+choice
+	prompt "External toolchain C library"
+	default BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+
+config BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+	bool "uClibc"
+
+config BR2_TOOLCHAIN_EXTERNAL_GLIBC
+	bool "glibc"
+
+endchoice
+
+menu "Library files"
+
 config BR2_TOOLCHAIN_EXTERNAL_LIB_C
 	string "The core C library from the external toolchain"
-	default "libc.so.0"
+	default "libc.so.0" if BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+	default "libc.so.6" if BR2_TOOLCHAIN_EXTERNAL_GLIBC
 	help
 	  Specify the core C shared library found in the external
 	  toolchain. This is required in addition to any other
@@ -11,13 +26,16 @@
 
 config BR2_TOOLCHAIN_EXTERNAL_LIBS
 	string "Libraries to copy from the external toolchain"
-	default "ld-uClibc.so.0 libcrypt.so.0 libdl.so.0 libgcc_s.so

libm.so.0 libnsl.so.0 libpthread.so.0 libresolv.so.0 librt.so.0 libutil.so.0"

toolchain/external-toolchain/Config.in +1 -0
+	default "ld-uClibc.so.0 libcrypt.so.0 libdl.so.0 libgcc_s.so

libm.so.0 libnsl.so.0 libpthread.so.0 libresolv.so.0 librt.so.0 libutil.so.0" if BR2_TOOLCHAIN_EXTERNAL_UCLIBC

toolchain/external-toolchain/Config.in +1 -0
+	default "ld-linux.so.3 libcrypt.so.1 libdl.so.2

libgcc_s.so.1 libm.so.6 libnsl.so.1 libpthread.so.0 libresolv.so.2 librt.so.1 libutil.so.1 libnss_files.so.2" if BR2_TOOLCHAIN_EXTERNAL_GLIBC help A space separated list of the shared libraries to be copied from the external toolchain into the root filesystem. Only the top-level name is needed, i.e. libc.so, libpthread.so as the actual shared library symlinked to will be copied also. +endmenu
+
config BR2_TOOLCHAIN_EXTERNAL_STRIP
bool
default y

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
#2 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Hi,

Thomas> Any opinion on this ? I'm adding Grant Likely to the Cc: list Thomas> because he showed interest in having support for external Thomas> Glibc toolchains in Buildroot.

I don't have a use for it myself, but I don't have a problem with it getting added (as long as someone is willing to supports its users).

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

Le Wed, 15 Apr 2009 16:13:53 +0200,
Peter Korsgaard <[email protected]> a ?crit :

Quoted 3 lines

I don't have a use for it myself, but I don't have a problem with it getting added (as long as someone is willing to supports its users).

Ok, thanks. My approach has one drawback: when one selects uClibc, the Kconfig system picks up the default uClibc values for BR2_TOOLCHAIN_EXTERNAL_LIB_C and BR2_TOOLCHAIN_EXTERNAL_LIBS. If the user then later changes to glibc, then Kconfig doesn't change the BR2_TOOLCHAIN_EXTERNAL_LIB_C and BR2_TOOLCHAIN_EXTERNAL_LIBS : they are kept to their uClibc defaults. That may confuse users.

This raises the following point: do we need these options at all ? Can't we just hardcode in ext-took.mk the list of libraries that have to be imported in the target, depending on the choosen C library ?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
#4 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> This raises the following point: do we need these options at Thomas> all ? Can't we just hardcode in ext-took.mk the list of Thomas> libraries that have to be imported in the target, depending Thomas> on the choosen C library ?

Sure, if the value is the same for all library versions, with/without tls/ntpl, endianness, abi, ..

Alternatively we could add 3 options: uclibc, glibc and custom, and then only display the setting for custom.

Signature · 1 line
Bye, Peter Korsgaard