ext2: fix missing mutex_unlock in error path
PATCH 1/1 ext2: fix missing mutex_unlock in error path
Add missing mutex_unlock in error path in ext2_quota_write()
---
fs/ext2/super.c +3 -1
@@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type, blk++; } out: -if (len == towrite) +if (len == towrite) { +mutex_unlock (&inode->i_mutex);return err; + }if (inode->i_size < off+len-towrite)i_size_write (inode, off+len-towrite); inode->i_version++;
Hello,
Quoted 11 lines · Akinobu Mita
Add missing
mutex_unlockin error path inext2_quota_write()Cc Jan Kara <[email protected]>Signed-off-by Akinobu Mita <[email protected]>---
fs/ext2/super.c +0
-0@@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type, blk++;
fs/ext2/super.c static ssize_t ext2_quota_write(struct super_block *sb, int type, · line 1404
Quoted 10 lines
fs/ext2/super.c +3
-1} out: -if (len == towrite) +if (len == towrite) { +mutex_unlock (&inode->i_mutex);return err; + }if (inode->i_size < off+len-towrite)i_size_write (inode, off+len-towrite); inode->i_version++;
Thanks for the patch but I already have this patch in my quota tree from
Dan Carpenter...
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 2 lines · Jan Kara
Thanks for the patch but I already have this patch in my quota tree from
Dan Carpenter...
Oh, I should have checked your tree.
BTW, JFS still have same problem in jfs_quota_write()
Quoted 6 lines · Akinobu Mita
Quoted 2 lines · Jan Kara
Thanks for the patch but I already have this patch in my quota tree from
Dan Carpenter...Oh, I should have checked your tree.
BTW, JFS still have same problem injfs_quota_write()
It's already fixed in JFS tree...
Quoted 1 line · Akinobu Mita
Add missing
mutex_unlockin error path inext2_quota_write()
This has already been taken I think.
http://patchwork.ozlabs.org/patch/25661/
Thanks -
Manish
Quoted 25 lines
Cc Jan Kara <[email protected]>Signed-off-by Akinobu Mita <[email protected]>---
fs/ext2/super.c +0
-0@@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type, blk++; }out:
- if (len == towrite)
+ if (len == towrite) {
+mutex_unlock(&inode->i_mutex);
return err;
+ }
if (inode->i_size< off+len-towrite)i_size_write(inode, off+len-towrite); inode->i_version++;
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 6 lines
Thanks - Manish -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html