Skip to contentSkip to conversation

Add vt6656 driver to drivers/staging.

PATCH In review Forest Bond 9 participants 38 messages Apr 14, 2009 – Jun 8, 2009 1 message not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add vt6656 driver to drivers/staging.

This patch adds the vt6656 driver to drivers/staging. This code was literally copied from the upstream source archive, available here:

http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip

Copyright: VIA Networking Technologies, Inc.
License: GPL
Authors: Jerry Chen, Kyle Hsu, Lucas Lin, Lyndon Chen, Tevin Chen, Warren Hsu,
Yiching Chen

Patch: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz
Signature: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz.sig

Thanks,
Forest
--
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

#1 lore raw
Quoted 5 lines · Forest Bond

This patch adds the vt6656 driver to drivers/staging. This code was literally copied from the upstream source archive, available here:

http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip

Quoted 8 lines

Copyright: VIA Networking Technologies, Inc.
License: GPL
Authors: Jerry Chen, Kyle Hsu, Lucas Lin, Lyndon Chen, Tevin Chen, Warren Hsu,
Yiching Chen

Patch: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz
Signature: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz.sig

Can we also please add files here saying to not bother the linux-wireless list about this crap?

Thanks,
Johannes

#2 lore raw

Hi,

Quoted 12 lines · Johannes Berg
Quoted 11 lines · Forest Bond

This patch adds the vt6656 driver to drivers/staging. This code was literally copied from the upstream source archive, available here:

http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip

Copyright: VIA Networking Technologies, Inc.
License: GPL
Authors: Jerry Chen, Kyle Hsu, Lucas Lin, Lyndon Chen, Tevin Chen, Warren Hsu,
Yiching Chen

Quoted 5 lines
Quoted 2 lines

Patch: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz
Signature: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz.sig

Can we also please add files here saying to not bother the linux-wireless list about this crap?

I would assume this is somewhat implied for any code in drivers/staging. Is that not the case?

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#3 lore raw
Quoted 5 lines · Forest Bond
Quoted 2 lines

Can we also please add files here saying to not bother the linux-wireless list about this crap?

I would assume this is somewhat implied for any code in drivers/staging. Is that not the case?

It seems to be on a per case basis -- and there's one driver at least (agnx) that we actually do care about because it is there only because it's incomplete not because the code is in some way problematic (like using its own 802.11 stack)

johannes

#4 lore raw

Hi Johannes,

Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

Can we also please add files here saying to not bother the linux-wireless list about this crap?

I would assume this is somewhat implied for any code in drivers/staging. Is that not the case?

It seems to be on a per case basis -- and there's one driver at least (agnx) that we actually do care about because it is there only because it's incomplete not because the code is in some way problematic (like using its own 802.11 stack)

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Not to mention the regulatory database I found in this specific driver.

At some point I like to see some proper future development/cleanup planning for drivers in the staging area. Dumping stuff in there doesn't help at all and personally I don't see anybody cleaning up this mess.

Do we have an option to taint the kernel when a staging driver is used. Similar to what we do with binary drivers or ndiswrapper?

Regards

Marcel

#5 lore raw

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

:)

Actually, last I counted it was already 7 or 8 stacks in staging _only_. This (and the other patch) will add two more. Not to mention that of course we already have something like two and a half stacks in the kernel tree (mac80211, in hostapd, and libipw [former ieee80211]).

Quoted 3 lines

At some point I like to see some proper future development/cleanup planning for drivers in the staging area. Dumping stuff in there doesn't help at all and personally I don't see anybody cleaning up this mess.

Which is why, for all wireless "drivers" but agnx and stlc45xx in staging I have requested that the linux-wireless list not be copied on any of the "patches" for those drivers. All of these other drivers are, in my opinion, entirely pointless and need to be rewritten from scratch using the current infrastructure. No amount of cleanup will help -- there is a _fundamental_ design difference. Compare ar9170 (rewritten) with otus (vendor) for an example.

Mind you, there don't seem to be many developers capable of doing that, and therefore all these drivers will never "make it". All wireless patches in staging, that haven't been proposed by people very familiar with the wireless code, have so far been in the "brain-dead cleanup" category.

Quoted 2 lines

Do we have an option to taint the kernel when a staging driver is used. Similar to what we do with binary drivers or ndiswrapper?

It's already doing that. FWIW, I trust many of those staging drivers a lot _less_ than, for instance, Broadcom's binary-only wl.ko driver.

johannes

#6 lore raw
Quoted 6 lines · Johannes Berg

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Quoted 6 lines

:)

Actually, last I counted it was already 7 or 8 stacks in staging _only_. This (and the other patch) will add two more. Not to mention that of course we already have something like two and a half stacks in the kernel tree (mac80211, in hostapd, and libipw [former ieee80211]).

FWIW I had started trying to consolidate some code between those three. I stalled-out a bit and got distracted with the rndis_wlan cfg80211 bits, but I hope to get back to it. Of course, hostap seems mighty complex internally -- it might just have to lay there. And libipw and mac80211 target different types of designs, but I hope they can eventually share some infrastructure in lib80211.

None of the above is meant to disagree about the staging crap. Having that stuff around is at best an optimistic attempt to help a few stray users... :-)

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#7 lore raw

Hi,

[My mail server appears to be having issues. I apologize if anyone receives more than one copy of this message.]

Quoted 21 lines · John W. Linville
Quoted 6 lines · Johannes Berg

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Quoted 6 lines

:)

Actually, last I counted it was already 7 or 8 stacks in staging _only_. This (and the other patch) will add two more. Not to mention that of course we already have something like two and a half stacks in the kernel tree (mac80211, in hostapd, and libipw [former ieee80211]).

FWIW I had started trying to consolidate some code between those three. I stalled-out a bit and got distracted with the rndis_wlan cfg80211 bits, but I hope to get back to it. Of course, hostap seems mighty complex internally -- it might just have to lay there. And libipw and mac80211 target different types of designs, but I hope they can eventually share some infrastructure in lib80211.

Quoted 3 lines

None of the above is meant to disagree about the staging crap. Having that stuff around is at best an optimistic attempt to help a few stray users... :-)

Well, gosh, I understand the criticism here and if I were a kernel developer I imagine my perspective would be much the same. But I can't help but feel that there's some amount of hypocrisy when we hammer on a manufacturer to properly license their driver and then let it drop dead when they do.

I understand that the problem would be solved if they manufacturers would suddenly "get it," but the scale of social problem preventing that is likely too large to change anytime soon.

If kernel developers are too busy to support the hardware, why do the manufacturers take so much criticism for releasing binary-only drivers or badly licensed drivers, or for neglecting to release technical specifications? If what I'm sensing is correct and there's no practical likelihood of these devices getting in-kernel support even with those issues resolved, the criticism almost seems unjustified.

I appreciate what the kernel developers do, of course, and my intention is not to ruffle feathers. But when a manufacturer that has taken a lot of criticism for its approach to the Linux community shows some good will, it seems like we ought to be able to turn that into something productive. If we can't, what have we been complaining about?

My apologies if I'm way off on this. I haven't been around all that long so it is certainly possible.

Respectfully,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw
Quoted 9 lines · Sujith
Quoted 5 lines · John W. Linville

John

Signature · 3 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
--

I knew it.
My mom always told me I was special.

Of course you are special...just like everybody else!! :-)

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#10 lore raw
In reply to John W. Linville

Hi,

Quoted 21 lines · John W. Linville
Quoted 6 lines · Johannes Berg

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Quoted 6 lines

:)

Actually, last I counted it was already 7 or 8 stacks in staging _only_. This (and the other patch) will add two more. Not to mention that of course we already have something like two and a half stacks in the kernel tree (mac80211, in hostapd, and libipw [former ieee80211]).

FWIW I had started trying to consolidate some code between those three. I stalled-out a bit and got distracted with the rndis_wlan cfg80211 bits, but I hope to get back to it. Of course, hostap seems mighty complex internally -- it might just have to lay there. And libipw and mac80211 target different types of designs, but I hope they can eventually share some infrastructure in lib80211.

Quoted 3 lines

None of the above is meant to disagree about the staging crap. Having that stuff around is at best an optimistic attempt to help a few stray users... :-)

Well, gosh, I understand the criticism here and if I were a kernel developer I imagine my perspective would be much the same. But I can't help but feel that there's some amount of hypocrisy when we hammer on a manufacturer to properly license their driver and then let it drop dead when they do.

I understand that the problem would be solved if they manufacturers would suddenly "get it," but the scale of social problem preventing that is likely too large to change anytime soon.

If kernel developers are too busy to support the hardware, why do the manufacturers take so much criticism for releasing binary-only drivers or badly licensed drivers, or for neglecting to release technical specifications? If what I'm sensing is correct and there's no practical likelihood of these devices getting in-kernel support even with those issues resolved, the criticism almost seems unjustified.

I appreciate what the kernel developers do, of course, and my intention is not to ruffle feathers. But when a manufacturer that has taken a lot of criticism for its approach to the Linux community shows some good will, it seems like we ought to be able to turn that into something productive. If we can't, what have we been complaining about?

My apologies if I'm way off on this. I haven't been around all that long so it is certainly possible.

Respectfully,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#11 lore raw
Quoted 9 lines · Forest Bond

Hi,

Quoted 6 lines · John W. Linville
Quoted 5 lines · Johannes Berg

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Yes we are. But we are doing it correctly :)

Turns out that people actually want to use their hardware, and no one else was working on merging these drivers, so that is what staging is for.

Quoted 4 lines

Well, gosh, I understand the criticism here and if I were a kernel developer I imagine my perspective would be much the same. But I can't help but feel that there's some amount of hypocrisy when we hammer on a manufacturer to properly license their driver and then let it drop dead when they do.

I agree.

Quoted 3 lines

I understand that the problem would be solved if they manufacturers would suddenly "get it," but the scale of social problem preventing that is likely too large to change anytime soon.

Agreed.

Quoted 7 lines

If kernel developers are too busy to support the hardware, why do the manufacturers take so much criticism for releasing binary-only drivers or badly licensed drivers, or for neglecting to release technical specifications? If what I'm sensing is correct and there's no practical likelihood of these devices getting in-kernel support even with those issues resolved, the criticism almost seems unjustified.

Quoted 8 lines

I appreciate what the kernel developers do, of course, and my intention is not to ruffle feathers. But when a manufacturer that has taken a lot of criticism for its approach to the Linux community shows some good will, it seems like we ought to be able to turn that into something productive. If we can't, what have we been complaining about?

My apologies if I'm way off on this. I haven't been around all that long so it is certainly possible.

You aren't way off at all.

Thanks for the patches, I'll get to them in a few days when my "real job" calms down a bit. They're now in my queue, and will not get lost.

thanks,

greg k-h

#12 lore raw

Hi,

Quoted 43 lines · Greg KH
Quoted 9 lines · Forest Bond

Hi,

Quoted 6 lines · John W. Linville
Quoted 5 lines · Johannes Berg

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Yes we are. But we are doing it correctly :)

Turns out that people actually want to use their hardware, and no one else was working on merging these drivers, so that is what staging is for.

Quoted 4 lines

Well, gosh, I understand the criticism here and if I were a kernel developer I imagine my perspective would be much the same. But I can't help but feel that there's some amount of hypocrisy when we hammer on a manufacturer to properly license their driver and then let it drop dead when they do.

I agree.

Quoted 3 lines

I understand that the problem would be solved if they manufacturers would suddenly "get it," but the scale of social problem preventing that is likely too large to change anytime soon.

Agreed.

Quoted 13 lines

If kernel developers are too busy to support the hardware, why do the manufacturers take so much criticism for releasing binary-only drivers or badly licensed drivers, or for neglecting to release technical specifications? If what I'm sensing is correct and there's no practical likelihood of these devices getting in-kernel support even with those issues resolved, the criticism almost seems unjustified.

I appreciate what the kernel developers do, of course, and my intention is not to ruffle feathers. But when a manufacturer that has taken a lot of criticism for its approach to the Linux community shows some good will, it seems like we ought to be able to turn that into something productive. If we can't, what have we been complaining about?

Quoted 7 lines
Quoted 2 lines

My apologies if I'm way off on this. I haven't been around all that long so it is certainly possible.

You aren't way off at all.

Thanks for the patches, I'll get to them in a few days when my "real job" calms down a bit. They're now in my queue, and will not get lost.

Thanks, Greg. Your reputation is well-deserved, to say the least.

I need to get you some new patches, anyway, as the upstream sources depend on header files that I failed to provide as they sit in a separate includes directory. I'll get this sent as soon as time permits (probably today or tomorrow).

-Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#13 lore raw

Hi,

Quoted 4 lines · Forest Bond

I need to get you some new patches, anyway, as the upstream sources depend on header files that I failed to provide as they sit in a separate includes directory. I'll get this sent as soon as time permits (probably today or tomorrow).

I have some new patches almost ready, including Kconfig files and Makefiles. I am in the process of resolving a few build failures.

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#14 lore raw
Quoted 6 lines · Forest Bond

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Of course Greg has the final say, but I vote to keep the directories with the vt6656 name and change the name of the driver, which is defined in the line #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver.

Larry

#15 lore raw

Hi Larry,

Quoted 11 lines · Larry Finger
Quoted 6 lines · Forest Bond

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Of course Greg has the final say, but I vote to keep the directories with the vt6656 name and change the name of the driver, which is defined in the line #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver.

This makes sense to me. I'll proceed this way for now. Greg, let me know if you'd prefer I didn't do this.

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#16 lore raw
Quoted 11 lines · Forest Bond

Hi Larry,

Quoted 8 lines · Larry Finger
Quoted 6 lines · Forest Bond

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Quoted 6 lines
Quoted 3 lines

Of course Greg has the final say, but I vote to keep the directories with the vt6656 name and change the name of the driver, which is defined in the line #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver.

This makes sense to me. I'll proceed this way for now. Greg, let me know if you'd prefer I didn't do this.

No objection from me.

thanks,

greg k-h

#17 lore raw

Hi Greg,

Quoted 10 lines · Greg KH
Quoted 9 lines · Forest Bond
Quoted 8 lines · Larry Finger
Quoted 6 lines · Forest Bond

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Of course Greg has the final say, but I vote to keep the directories with the vt6656 name and change the name of the driver, which is defined in the line #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver.

This makes sense to me. I'll proceed this way for now. Greg, let me know if you'd prefer I didn't do this.

No objection from me.

The following git repository has a vt6655 branch and a vt6656 branch:

http://www.alittletooquiet.net/media/code/vt665x.git

The vt6655 branch contains pretty much all of the work I'll likely be able to do for that driver. The vt6656 branch needs more work. I've not gone farther than build-testing either, at this point.

As I've mentioned before, some of this kind of work is really a bit outside my usual domain, so if you do look at it, I'd appreciate feedback.

Feel free to make requests.

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#18 lore raw
Quoted 6 lines · =46orest Bond wrote:

=20
The following git repository has a vt6655 branch and a vt6656 branch:
=20
http://www.alittletooquiet.net/media/code/vt665x.git
=20
The vt6655 branch contains pretty much all of the work I'll likely be=

able to do

Quoted 1 line

for that driver. The vt6656 branch needs more work. I've not gone f=

arther than

Quoted 1 line

build-testing either, at this point.

It would be a little easier for looking at the code if both vt6655 and = vt6656
directories were in the same branch of the git repo, but it's not a big=
deal.

Quoted 1 line

As I've mentioned before, some of this kind of work is really a bit o=

utside my

Quoted 1 line

usual domain, so if you do look at it, I'd appreciate feedback.

There are a number of warnings when compiling the vt6655 driver on x86_= 64
architecture that arise from pointers having 64 bits while integers hav= e 32
bits. I think the warnings will not cause any problems. There is, howev= er, one
error, namely:

CC [M] drivers/staging/vt6655/device_main.o
drivers/staging/vt6655/device_main.c:347: error: initializer element is=
not constant
drivers/staging/vt6655/device_main.c:347: error: (near initialization f= or
=E2=80=98device_id_table[0].driver_data=E2=80=99)

The following patch fixes the compilation by removing the integer cast = on
chip_info_table:

Index: vt665x/drivers/staging/vt6655/device_main.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

drivers/staging/vt6655/device_main.c +0 -1
@@ -344,7 +344,7 @@ static CHIP_INFO chip_info_table[]=3D {
 };
 
 static struct pci_device_id device_id_table[] __devinitdata =3D {
-{ 0x1106, 0x3253, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (int)&chip_info_table[=

0]},
+{ 0x1106, 0x3253, PCI_ANY_ID, PCI_ANY_ID, 0, 0, &chip_info_table[0]},
{ 0, }
};
#endif

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D

Driver vt6656 also does not build, but that does not seem to be 64-bit = related.
If it builds on your system, let me know and I'll send you the error me= ssages.

I didn't look that thoroughly at the code, but I did notice one thing. = The
constructions like "#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)" ar= e in the
code so that it can build on a number of different kernels. Once it is = in
staging, it only has to build on the current kernel and you can trim ou= t those
conditionals.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#19 lore raw

Hi,

Quoted 13 lines · Larry Finger
Quoted 8 lines · Forest Bond

The following git repository has a vt6655 branch and a vt6656 branch:

http://www.alittletooquiet.net/media/code/vt665x.git

The vt6655 branch contains pretty much all of the work I'll likely be able to do for that driver. The vt6656 branch needs more work. I've not gone farther than build-testing either, at this point.

It would be a little easier for looking at the code if both vt6655 and vt6656 directories were in the same branch of the git repo, but it's not a big deal.

Quoted 6 lines
Quoted 2 lines

As I've mentioned before, some of this kind of work is really a bit outside my usual domain, so if you do look at it, I'd appreciate feedback.

There are a number of warnings when compiling the vt6655 driver on x86_64 architecture that arise from pointers having 64 bits while integers have 32 bits. I think the warnings will not cause any problems.

I'll have a closer look at the warnings.

Quoted 6 lines

There is, however, one error, namely:

CC [M] drivers/staging/vt6655/device_main.o
drivers/staging/vt6655/device_main.c:347: error: initializer element is not constant drivers/staging/vt6655/device_main.c:347: error: (near initialization for ‘device_id_table[0].driver_data’)

Hm, didn't see this on my system. Not sure why. Thanks for the patch.

Quoted 2 lines

Driver vt6656 also does not build, but that does not seem to be 64-bit related. If it builds on your system, let me know and I'll send you the error messages.

No, I haven't gotten that in a good state yet.

Quoted 5 lines

I didn't look that thoroughly at the code, but I did notice one thing. The constructions like "#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)" are in the code so that it can build on a number of different kernels. Once it is in staging, it only has to build on the current kernel and you can trim out those conditionals.

Right, my intention was to look at those once the major build issues were sorted out.

Were you able to look over my changes for net device private data accesses in the vt6655 driver? That is what I'm most concerned about.

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#20 lore raw
In reply to Forest Bond
Quoted 26 lines · Forest Bond

Hi Greg,

Quoted 10 lines · Greg KH
Quoted 9 lines · Forest Bond
Quoted 8 lines · Larry Finger
Quoted 6 lines · Forest Bond

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Of course Greg has the final say, but I vote to keep the directories with the vt6656 name and change the name of the driver, which is defined in the line #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver.

This makes sense to me. I'll proceed this way for now. Greg, let me know if you'd prefer I didn't do this.

No objection from me.

The following git repository has a vt6655 branch and a vt6656 branch:

http://www.alittletooquiet.net/media/code/vt665x.git

Quoted 8 lines

The vt6655 branch contains pretty much all of the work I'll likely be able to do for that driver. The vt6656 branch needs more work. I've not gone farther than build-testing either, at this point.

As I've mentioned before, some of this kind of work is really a bit outside my usual domain, so if you do look at it, I'd appreciate feedback.

Feel free to make requests.

Could you send it out as patches so it's easier to review?

thanks,

greg k-h

#21 lore raw

Hi,

Quoted 31 lines · Greg KH
Quoted 30 lines · Forest Bond

Hi Greg,

Quoted 10 lines · Greg KH
Quoted 9 lines · Forest Bond
Quoted 8 lines · Larry Finger
Quoted 6 lines · Forest Bond

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Of course Greg has the final say, but I vote to keep the directories with the vt6656 name and change the name of the driver, which is defined in the line #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver.

This makes sense to me. I'll proceed this way for now. Greg, let me know if you'd prefer I didn't do this.

No objection from me.

The following git repository has a vt6655 branch and a vt6656 branch:

http://www.alittletooquiet.net/media/code/vt665x.git

The vt6655 branch contains pretty much all of the work I'll likely be able to do for that driver. The vt6656 branch needs more work. I've not gone farther than build-testing either, at this point.

Quoted 6 lines
Quoted 4 lines

As I've mentioned before, some of this kind of work is really a bit outside my usual domain, so if you do look at it, I'd appreciate feedback.

Feel free to make requests.

Could you send it out as patches so it's easier to review?

Yes, I would've preferred that but the first patch is >1MB, so I figured it might be more useful to point you to a git repository, rather than send out a compressed patch. I can send it out uncompressed if you prefer, or I can just send all but the first patch (which only copies files from the upstream archive, anyway).

-Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#22 lore raw
Quoted 39 lines · Forest Bond

Hi,

Quoted 36 lines · Greg KH
Quoted 34 lines · Forest Bond

Hi Greg,

Quoted 10 lines · Greg KH
Quoted 9 lines · Forest Bond
Quoted 8 lines · Larry Finger
Quoted 6 lines · Forest Bond

However, I did have a question:

The vt6655 driver builds viawget.ko, and the vt6656 driver builds vntwusb.ko. Should the directories be named "viawget" and "vntwusb," respectively, or is it appropriate for them to be named "vt6655" and "vt6656"?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Of course Greg has the final say, but I vote to keep the directories with the vt6656 name and change the name of the driver, which is defined in the line #define DEVICE_NAME "vntwusb" in file include/device_cfg.h in the vendor driver.

This makes sense to me. I'll proceed this way for now. Greg, let me know if you'd prefer I didn't do this.

No objection from me.

The following git repository has a vt6655 branch and a vt6656 branch:

http://www.alittletooquiet.net/media/code/vt665x.git

The vt6655 branch contains pretty much all of the work I'll likely be able to do for that driver. The vt6656 branch needs more work. I've not gone farther than build-testing either, at this point.

As I've mentioned before, some of this kind of work is really a bit outside my usual domain, so if you do look at it, I'd appreciate feedback.

Feel free to make requests.

Quoted 7 lines
Quoted 1 line

Could you send it out as patches so it's easier to review?

Yes, I would've preferred that but the first patch is >1MB, so I figured it might be more useful to point you to a git repository, rather than send out a compressed patch. I can send it out uncompressed if you prefer, or I can just send all but the first patch (which only copies files from the upstream archive, anyway).

Well, I'll need all of them, including the first patch, if I'm going to ever apply them to the tree, so I don't mind :)

Everyone else might not care, so you can just send that one to me...

thanks,

greg k-h

#23 lore raw

PATCH 2/8 Add includes to drivers/staging/vt6655.

Add includes to drivers/staging/vt6655. These came from the includes directory in the upstream source archive.

---
 drivers/staging/vt6655/device_cfg.h |  142 ++++++++++
 drivers/staging/vt6655/iocmd.h      |  481 +++++++++++++++++++++++++++++++++++
 drivers/staging/vt6655/iowpa.h      |  159 ++++++++++++
 drivers/staging/vt6655/ttype.h      |  386 ++++++++++++++++++++++++++++
 4 files changed, 1168 insertions(+), 0 deletions(-)
 create mode 100644 drivers/staging/vt6655/device_cfg.h
 create mode 100644 drivers/staging/vt6655/iocmd.h
 create mode 100644 drivers/staging/vt6655/iowpa.h
 create mode 100644 drivers/staging/vt6655/ttype.h
drivers/staging/vt6655/device_cfg.h new file +142 -0
new file mode 100644
index 0000000..9e18f7c
@@ -0,0 +1,142 @@
+/*
+ * Copyright (c) 1996, 2003 VIA Networking, Inc. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ * 
+ *
+ * File: device_cfg.h
+ *
+ * Purpose: Driver configuration header
+ * Author: Lyndon Chen
+ *
+ * Date: Dec 17, 2002
+ *
+ */  
+#ifndef __DEVICE_CONFIG_H
+#define __DEVICE_CONFIG_H
+
+//#include <linux/config.h>
+#include <linux/types.h>
+
+#if !defined(__TTYPE_H__)
+#include "ttype.h"
+#endif
+
+
+
+typedef __u8    UINT8,   *PUINT8;
+typedef __u16   UINT16,  *PUINT16;
+typedef __u32   UINT32,  *PUINT32;
+
+
+#ifndef VOID
+#define VOID            void
+#endif
+
+#ifndef CONST
+#define CONST           const
+#endif
+
+#ifndef STATIC
+#define STATIC          static
+#endif
+
+#ifndef DEF
+#define DEF
+#endif
+
+#ifndef IN
+#define IN
+#endif
+
+#ifndef OUT
+#define OUT
+#endif
+
+typedef
+struct _version {
+    UINT8   major;
+    UINT8   minor;
+    UINT8   build;
+} version_t, *pversion_t;
+
+#ifndef FALSE
+#define FALSE   (0)
+#endif
+
+#ifndef TRUE
+#define TRUE    (!(FALSE))
+#endif
+
+#define VID_TABLE_SIZE      64
+#define MCAST_TABLE_SIZE    64
+#define MCAM_SIZE           32
+#define VCAM_SIZE           32
+#define TX_QUEUE_NO         8
+
+#define DEVICE_NAME         "viawget"
+#define DEVICE_FULL_DRV_NAM "VIA Networking Solomon-A/B/G Wireless LAN Adapter Driver"
+
+#ifndef MAJOR_VERSION
+#define MAJOR_VERSION       1
+#endif
+
+#ifndef MINOR_VERSION
+#define MINOR_VERSION       17
+#endif
+
+#ifndef DEVICE_VERSION
+#define DEVICE_VERSION       "1.19.12"
+#endif
+//config file 
+#include <linux/fs.h>
+#include <linux/fcntl.h>
+#ifndef CONFIG_PATH
+#define CONFIG_PATH            "/etc/vntconfiguration.dat"
+#endif
+
+//Max: 2378=2312Payload + 30HD +4CRC + 2Padding + 4Len + 8TSF + 4RSR
+#define PKT_BUF_SZ          2390
+
+
+#define MALLOC(x,y)         kmalloc((x),(y))
+#define FREE(x)             kfree((x))
+#define MAX_UINTS           8
+#define OPTION_DEFAULT      { [0 ... MAX_UINTS-1] = -1}
+
+
+
+typedef enum  _chip_type{
+    VT3253=1    
+} CHIP_TYPE, *PCHIP_TYPE;
+
+
+ 
+#ifdef VIAWET_DEBUG
+#define ASSERT(x) { \
+    if (!(x)) { \
+        printk(KERN_ERR "assertion %s failed: file %s line %d\n", #x,\
+        __FUNCTION__, __LINE__);\
+        *(int*) 0=0;\
+    }\
+}
+#define DBG_PORT80(value)                   outb(value, 0x80)
+#else
+#define ASSERT(x)
+#define DBG_PORT80(value)                   
+#endif
+
+
+#endif
drivers/staging/vt6655/iocmd.h new file +481 -0

481 lines not on this page · raw message

drivers/staging/vt6655/iowpa.h new file +159 -0

159 lines not on this page · raw message

drivers/staging/vt6655/ttype.h new file +386 -0

386 lines not on this page · raw message

Signature · 7 lines
1.5.4.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#24 lore raw

PATCH 3/8 Integrate drivers/staging/vt6655 into build system.

In reply to Greg KH

Integrate drivers/staging/vt6655 into build system.

---
 drivers/staging/Kconfig         |    2 +
 drivers/staging/Makefile        |    1 +
 drivers/staging/vt6655/Kconfig  |    5 +
 drivers/staging/vt6655/Makefile |  252 +++++---------------------------------
 4 files changed, 42 insertions(+), 218 deletions(-)
 create mode 100644 drivers/staging/vt6655/Kconfig
drivers/staging/Kconfig +2 -0
index 0dcf9ca..3a95633 100644
@@ -115,5 +115,7 @@ source "drivers/staging/line6/Kconfig"
 
 source "drivers/staging/serqt_usb/Kconfig"
 
+source "drivers/staging/vt6655/Kconfig"
+
 endif # !STAGING_EXCLUDE_BUILD
 endif # STAGING
drivers/staging/Makefile +1 -0
index 47dfd5b..2a56a60 100644
@@ -40,3 +40,4 @@ obj-$(CONFIG_PLAN9AUTH)		+= p9auth/
 obj-$(CONFIG_HECI)		+= heci/
 obj-$(CONFIG_LINE6_USB)		+= line6/
 obj-$(CONFIG_USB_SERIAL_QUATECH_ESU100)	+= serqt_usb/
+obj-$(CONFIG_VT6655)	+= vt6655/
drivers/staging/vt6655/Kconfig new file +5 -0
new file mode 100644
index 0000000..d9bfc81
@@ -0,0 +1,5 @@
+config VT6655
+   tristate "VIA Technologies VT6655 support"
+   ---help---
+   This is a vendor-written driver for VIA VT6655.
+
drivers/staging/vt6655/Makefile +34 -218

252 lines not on this page · raw message

Signature · 7 lines
1.5.4.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#25 lore raw

PATCH 4/8 Add necessary EXTRA_CFLAGS to drivers/staging/vt6655/Makefile.

In reply to Greg KH

Add necessary EXTRA_CFLAGS to drivers/staging/vt6655/Makefile.

---
 drivers/staging/vt6655/Makefile |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/staging/vt6655/Makefile +4 -0
index c9e0936..7d76e7e 100644
@@ -1,3 +1,7 @@
+# TODO: all of these should be removed
+EXTRA_CFLAGS += -DLINUX -D__KERNEL__ -DMODULE  -DEXPORT_SYMTAB -D__NO_VERSION__
+EXTRA_CFLAGS += -DHOSTAP
+
 vt6655-y +=	device_main.o \
 	card.o \
 	mac.o \
Signature · 7 lines
1.5.4.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#26 lore raw

PATCH 5/8 Build vt6655.ko, not viawget.ko.

In reply to Greg KH

Build vt6655.ko, not viawget.ko.

---
 drivers/staging/vt6655/device_cfg.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/vt6655/device_cfg.h +1 -1
index 9e18f7c..6af9067 100644
@@ -86,7 +86,7 @@ struct _version {
 #define VCAM_SIZE           32
 #define TX_QUEUE_NO         8
 
-#define DEVICE_NAME         "viawget"
+#define DEVICE_NAME         "vt6655"
 #define DEVICE_FULL_DRV_NAM "VIA Networking Solomon-A/B/G Wireless LAN Adapter Driver"
 
 #ifndef MAJOR_VERSION
Signature · 7 lines
1.5.4.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#27 lore raw

PATCH 6/8 drivers/staging/vt6655/device_main.c: Drop obsolete fsuid/fsgid accesses.

In reply to Greg KH

drivers/staging/vt6655/device_main.c: Drop obsolete fsuid/fsgid accesses.

---
 drivers/staging/vt6655/device_main.c |   22 ++++++++++++++--------
 1 files changed, 14 insertions(+), 8 deletions(-)
drivers/staging/vt6655/device_main.c +14 -8
index 0d6aec9..126ecef 100644
@@ -3278,15 +3278,18 @@ int Config_FileOperation(PSDevice pDevice,BOOL fwrite,unsigned char *Parameter)
     UCHAR      tmpbuffer[20];
     struct file   *filp=NULL;
     mm_segment_t old_fs = get_fs();
-    int oldfsuid=0,oldfsgid=0;
+    //int oldfsuid=0,oldfsgid=0;
     int result=0;
 
     set_fs (KERNEL_DS);
-//Make sure a caller can read or write power as root
-   oldfsuid=current->fsuid;
-   oldfsgid=current->fsgid;
-    current->fsuid = 0;
-    current->fsgid = 0;
+
+    /* Can't do this anymore, so we rely on correct filesystem permissions:
+    //Make sure a caller can read or write power as root
+    oldfsuid=current->cred->fsuid;
+    oldfsgid=current->cred->fsgid;
+    current->cred->fsuid = 0;
+    current->cred->fsgid = 0;
+    */
 	
     //open file 
       filp = filp_open(config_path, O_RDWR, 0);
@@ -3344,8 +3347,11 @@ error1:
 
 error2:
   set_fs (old_fs);
-  current->fsuid=oldfsuid;
-  current->fsgid=oldfsgid;
+
+  /*
+  current->cred->fsuid=oldfsuid;
+  current->cred->fsgid=oldfsgid;
+  */
   
   return result;
 }
Signature · 7 lines
1.5.4.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#28 lore raw

PATCH 7/8 vt6655: Replace net_device->priv accesses with netdev_priv calls.

In reply to Greg KH

vt6655: Replace net_device->priv accesses with netdev_priv calls.

---
 drivers/staging/vt6655/device_main.c |   29 ++++++---------
 drivers/staging/vt6655/hostap.c      |    8 +++--
 drivers/staging/vt6655/iwctl.c       |   62 +++++++++++++++++-----------------
 drivers/staging/vt6655/wpactl.c      |    7 +++-
 4 files changed, 53 insertions(+), 53 deletions(-)
drivers/staging/vt6655/device_main.c +12 -17
index 126ecef..ca198a2 100644
@@ -995,12 +995,14 @@ device_found1(struct pci_dev *pcid, const struct pci_device_id *ent)
         return -ENODEV;
     }
     
-    
+
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
-    dev = alloc_etherdev(0);
+    dev = alloc_etherdev(sizeof(DEVICE_INFO));
 #else
     dev = init_etherdev(dev, 0);
 #endif    
+
+    pDevice = (PSDevice) netdev_priv(dev);
     
     if (dev == NULL) {
         printk(KERN_ERR DEVICE_NAME ": allocate net device failed \n");
@@ -1025,7 +1027,6 @@ device_found1(struct pci_dev *pcid, const struct pci_device_id *ent)
     pDevice->dev = dev;
     pDevice->next_module = root_device_dev;
     root_device_dev = dev;
-    dev->priv = pDevice;
     dev->irq = pcid->irq;
     
     if (pci_enable_device(pcid)) {
@@ -1226,11 +1227,6 @@ static BOOL device_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
 
     PSDevice p;
     
-    *ppDevice = kmalloc(sizeof(DEVICE_INFO),GFP_ATOMIC);
-    
-    if (*ppDevice == NULL)
-        return FALSE;
-        
     memset(*ppDevice,0,sizeof(DEVICE_INFO));
     
     if (pDevice_Infos == NULL) {
@@ -2059,7 +2055,7 @@ int __device_open(HANDLE pExDevice) {
 #else 
 
 static int  device_open(struct net_device *dev) {
-    PSDevice    pDevice=(PSDevice) dev->priv;    
+    PSDevice    pDevice=(PSDevice) netdev_priv(dev);    
     int i;
 #endif
     pDevice->rx_buf_sz = PKT_BUF_SZ;
@@ -2212,7 +2208,7 @@ int  __device_close(HANDLE pExDevice) {
 
 #else 
 static int  device_close(struct net_device *dev) {
-    PSDevice  pDevice=(PSDevice) dev->priv;  
+    PSDevice  pDevice=(PSDevice) netdev_priv(dev);  
 #endif            
     PSMgmtObject     pMgmt = pDevice->pMgmt;
  //PLICE_DEBUG->
@@ -2282,7 +2278,7 @@ int  __device_dma0_tx_80211(HANDLE pExDevice, struct sk_buff *skb) {
 
 
 static int device_dma0_tx_80211(struct sk_buff *skb, struct net_device *dev) {
-    PSDevice        pDevice=dev->priv;
+    PSDevice        pDevice=netdev_priv(dev);
 #endif    
     PBYTE           pbMPDU;
     UINT            cbMPDULen = 0;
@@ -2494,7 +2490,7 @@ int  __device_xmit(HANDLE pExDevice, struct sk_buff *skb) {
     
 #else 
 static int  device_xmit(struct sk_buff *skb, struct net_device *dev) {
-    PSDevice pDevice=dev->priv;
+    PSDevice pDevice=netdev_priv(dev);
 
 #endif
     PSMgmtObject    pMgmt = pDevice->pMgmt;
@@ -2950,7 +2946,7 @@ int __device_intr(int irq, HANDLE pExDevice, struct pt_regs *regs) {
 #else    
 static  irqreturn_t  device_intr(int irq,  void *dev_instance) {
     struct net_device* dev=dev_instance;
-    PSDevice     pDevice=(PSDevice) dev->priv;
+    PSDevice     pDevice=(PSDevice) netdev_priv(dev);
 #endif
 
     int             max_count=0;
@@ -3367,7 +3363,7 @@ void __device_set_multi(HANDLE pExDevice) {
 #else        
  
 static void device_set_multi(struct net_device *dev) {
-    PSDevice         pDevice = (PSDevice) dev->priv;
+    PSDevice         pDevice = (PSDevice) netdev_priv(dev);
 #endif                                                                            
 
     PSMgmtObject     pMgmt = pDevice->pMgmt;    
@@ -3441,7 +3437,7 @@ struct net_device_stats *__device_get_stats(HANDLE pExDevice) {
 
 #else
 static struct net_device_stats *device_get_stats(struct net_device *dev) {
-    PSDevice pDevice=(PSDevice) dev->priv;  
+    PSDevice pDevice=(PSDevice) netdev_priv(dev);  
 #endif    
 
     return &pDevice->stats;
@@ -3458,7 +3454,7 @@ int __device_ioctl(HANDLE pExDevice, struct ifreq *rq, int cmd) {
 #else 
 
 static int  device_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) {
-	PSDevice	        pDevice = (PSDevice)dev->priv;
+	PSDevice	        pDevice = (PSDevice)netdev_priv(dev);
 #endif            
 
 #ifdef WIRELESS_EXT    
@@ -4116,7 +4112,6 @@ int __device_hw_init(HANDLE pExDevice){
     PSDevice_info pDevice_info = (PSDevice_info)pExDevice;
     PSDevice    pDevice;
 
-
     pDevice = (PSDevice)kmalloc(sizeof(DEVICE_INFO), (int)GFP_ATOMIC);
     if (pDevice == NULL) 
         return FALSE;
drivers/staging/vt6655/hostap.c +5 -3
index 7c47f5d..8c52625 100644
@@ -100,6 +100,7 @@ static int          msglevel                =MSG_LEVEL_INFO;
  
 static int hostap_enable_hostapd(PSDevice pDevice, int rtnl_locked)
 {
+    PSDevice apdev_priv;
 	struct net_device *dev = pDevice->dev;
 	int ret;
 
@@ -124,12 +125,13 @@ static int hostap_enable_hostapd(PSDevice pDevice, int rtnl_locked)
 	       dev->name, pDevice->apdev->name);	
     
 #else
-	pDevice->apdev = (struct net_device *)kmalloc(sizeof(struct net_device), GFP_KERNEL);
+    pDevice->apdev = (struct net_device *)kmalloc(sizeof(struct net_device), GFP_KERNEL);
 	if (pDevice->apdev == NULL)
 		return -ENOMEM;
 	memset(pDevice->apdev, 0, sizeof(struct net_device));
-	
-	pDevice->apdev->priv = pDevice;
+
+    apdev_priv = netdev_priv(pDevice->apdev);
+    *apdev_priv = *pDevice;
 	memcpy(pDevice->apdev->dev_addr, dev->dev_addr, ETH_ALEN);
 	pDevice->apdev->hard_start_xmit = pDevice->tx_80211;
 	pDevice->apdev->type = ARPHRD_IEEE80211;
drivers/staging/vt6655/iwctl.c +31 -31

248 lines not on this page · raw message

drivers/staging/vt6655/wpactl.c +5 -2
index b4eadb8..a83f950 100644
@@ -112,14 +112,17 @@ static void wpadev_setup(struct net_device *dev)
  
 static int wpa_init_wpadev(PSDevice pDevice)
 {
+    PSDevice wpadev_priv;
 	struct net_device *dev = pDevice->dev;
          int ret=0;
 		 
-	pDevice->wpadev = alloc_netdev(0, "vntwpa", wpadev_setup);	 
+	pDevice->wpadev = alloc_netdev(sizeof(PSDevice), "vntwpa", wpadev_setup);
 	if (pDevice->wpadev == NULL)
 		return -ENOMEM;
 
-	pDevice->wpadev->priv = pDevice;
+    wpadev_priv = netdev_priv(pDevice->wpadev);
+    *wpadev_priv = *pDevice;
+
 	memcpy(pDevice->wpadev->dev_addr, dev->dev_addr, U_ETHER_ADDR_LEN);
          pDevice->wpadev->base_addr = dev->base_addr;
 	pDevice->wpadev->irq = dev->irq;
Signature · 7 lines
1.5.4.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#29 lore raw

Re: [PATCH 7/8] vt6655: Replace net_device->priv accesses with netdev_priv calls.

Hi,

I haven't had a chance to test this on real hardware yet. Sorry, I will try to do this soon.

drivers/staging/vt6655/device_main.c static BOOL device_init_info(struct pci_dev* pcid, PSDevice* ppDevice, · line 1232

Quoted 12 lines · Forest Bond
drivers/staging/vt6655/device_main.c +0 -5
@@ -1226,11 +1227,6 @@ static BOOL device_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
 
     PSDevice p;
 
-    *ppDevice = kmalloc(sizeof(DEVICE_INFO),GFP_ATOMIC);
-    
-    if (*ppDevice == NULL)
-        return FALSE;
-        
     memset(*ppDevice,0,sizeof(DEVICE_INFO));
 
     if (pDevice_Infos == NULL) {

I realized that I did not remove the corresponding kfree calls for this removed kmalloc. Should I resend, or is it better to send an additional patch to be applied on top of the original patches?

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#30 lore raw

PATCH 8/8 vt6655: Remove LINUX_VERSION_CODE preprocessor conditionals.

In reply to Greg KH

vt6655: Remove LINUX_VERSION_CODE preprocessor conditionals.

---
 drivers/staging/vt6655/bssdb.c       |    5 -
 drivers/staging/vt6655/device_main.c |   84 +-------------
 drivers/staging/vt6655/dpc.c         |   24 +----
 drivers/staging/vt6655/iwctl.c       |   78 ++-----------
 drivers/staging/vt6655/kcompat.h     |  218 ----------------------------------
 drivers/staging/vt6655/wmgr.c        |   16 +--
 6 files changed, 16 insertions(+), 409 deletions(-)
drivers/staging/vt6655/bssdb.c +0 -5
index 27b46d7..841e161 100644
@@ -1335,12 +1335,7 @@ start:
              wpahdr->req_ie_len = 0;
              skb_put(pDevice->skb, sizeof(viawget_wpa_header));
              pDevice->skb->dev = pDevice->wpadev;
-//2008-4-3 modify by Chester for wpa 
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,22)  
              pDevice->skb->mac_header = pDevice->skb->data;
-#else
-            pDevice->skb->mac.raw = pDevice->skb->data;
-#endif
              pDevice->skb->pkt_type = PACKET_HOST;
              pDevice->skb->protocol = htons(ETH_P_802_2);
              memset(pDevice->skb->cb, 0, sizeof(pDevice->skb->cb));
drivers/staging/vt6655/device_main.c +1 -83

248 lines not on this page · raw message

drivers/staging/vt6655/dpc.c +2 -22
index f8424bd..75496a7 100644
@@ -709,11 +709,7 @@ device_receive_frame (
                 ref_skb_add_offset(skb->skb, 4);
                 ref_skb_set_dev(pDevice->apdev, skb->skb);
                 skb_put(skb->skb, FrameSize);
-#if	LINUX_VERSION_CODE	> KERNEL_VERSION(2,6,21)
 	            skb->mac_header = skb->data;
-#else
-			skb->mac.raw = skb->data;
-#endif
 	            *(skb->pkt_type) = PACKET_OTHERHOST;
     	        *(skb->protocol) = htons(ETH_P_802_2);
 	            memset(skb->cb, 0, sizeof(skb->cb));
@@ -722,11 +718,7 @@ device_receive_frame (
 	            skb->data += 4;
 	            skb->tail += 4;
                      skb_put(skb, FrameSize);
-#if	LINUX_VERSION_CODE > KERNEL_VERSION (2,6,21)
 	            skb->mac_header = skb->data;
-#else
-		skb->mac.raw = skb->data;
-#endif
 	            skb->pkt_type = PACKET_OTHERHOST;
     	        skb->protocol = htons(ETH_P_802_2);
 	            memset(skb->cb, 0, sizeof(skb->cb));
@@ -858,11 +850,7 @@ device_receive_frame (
             ref_skb_add_offset(skb->skb, (cbIVOffset + 4));
             ref_skb_set_dev(pDevice->apdev, skb->skb);
             skb_put(skb->skb, FrameSize);
-#if	LINUX_VERSION_CODE	> KERNEL_VERSION(2,6,21)
 			skb->mac_header = skb->data;
-#else
-			skb->mac.raw = skb->data;
-#endif
             *(skb->pkt_type) = PACKET_OTHERHOST;
 	        *(skb->protocol) = htons(ETH_P_802_2);
             memset(skb->cb, 0, sizeof(skb->cb));
@@ -871,11 +859,7 @@ device_receive_frame (
             skb->data +=  (cbIVOffset + 4);
             skb->tail +=  (cbIVOffset + 4);
             skb_put(skb, FrameSize);
-#if	LINUX_VERSION_CODE	> KERNEL_VERSION(2,6,21)
            skb->mac_header = skb->data;
-#else
-	skb->mac.raw = skb->data;
-#endif
 
 	skb->pkt_type = PACKET_OTHERHOST;
             skb->protocol = htons(ETH_P_802_2);
@@ -998,12 +982,8 @@ device_receive_frame (
                      wpahdr->req_ie_len = 0;
                      skb_put(pDevice->skb, sizeof(viawget_wpa_header));
                      pDevice->skb->dev = pDevice->wpadev;
-#if	LINUX_VERSION_CODE	> KERNEL_VERSION(2,6,21)
-		pDevice->skb->mac_header = pDevice->skb->data;
-#else
-		pDevice->skb->mac.raw=pDevice->skb->data;
-#endif
-			pDevice->skb->pkt_type = PACKET_HOST;
+                     pDevice->skb->mac_header = pDevice->skb->data;
+                     pDevice->skb->pkt_type = PACKET_HOST;
                      pDevice->skb->protocol = htons(ETH_P_802_2);
                      memset(pDevice->skb->cb, 0, sizeof(pDevice->skb->cb));
                      netif_rx(pDevice->skb);
drivers/staging/vt6655/iwctl.c +11 -67

165 lines not on this page · raw message

drivers/staging/vt6655/kcompat.h +0 -218

229 lines not on this page · raw message

drivers/staging/vt6655/wmgr.c +2 -14
index 3b253b0..29fd0f2 100644
@@ -1125,11 +1125,7 @@ s_vMgrRxAssocResponse(
                        );                
                 skb_put(pDevice->skb, sizeof(viawget_wpa_header) + wpahdr->resp_ie_len + wpahdr->req_ie_len);
                 pDevice->skb->dev = pDevice->wpadev;
-#if	LINUX_VERSION_CODE	> KERNEL_VERSION(2,6,21)
-		pDevice->skb->mac_header = pDevice->skb->data;
-#else
-		pDevice->skb->mac.raw = pDevice->skb->data;
-#endif
+                pDevice->skb->mac_header = pDevice->skb->data;
                 pDevice->skb->pkt_type = PACKET_HOST;
                 pDevice->skb->protocol = htons(ETH_P_802_2);
                 memset(pDevice->skb->cb, 0, sizeof(pDevice->skb->cb));
@@ -1765,11 +1761,7 @@ s_vMgrRxDisassociation(
              wpahdr->req_ie_len = 0;
              skb_put(pDevice->skb, sizeof(viawget_wpa_header));
              pDevice->skb->dev = pDevice->wpadev;
-#if	LINUX_VERSION_CODE	> KERNEL_VERSION(2,6,21)
 	         pDevice->skb->mac_header = pDevice->skb->data;
-#else
-		pDevice->skb->mac.raw = pDevice->skb->data;
-#endif
 
              pDevice->skb->pkt_type = PACKET_HOST;
              pDevice->skb->protocol = htons(ETH_P_802_2);
@@ -1857,11 +1849,7 @@ s_vMgrRxDeauthentication(
                  wpahdr->req_ie_len = 0;
                  skb_put(pDevice->skb, sizeof(viawget_wpa_header));
                  pDevice->skb->dev = pDevice->wpadev;
-#if	LINUX_VERSION_CODE	> KERNEL_VERSION(2,6,21)
-	        pDevice->skb->mac_header = pDevice->skb->data;
-#else
-		pDevice->skb->mac.raw = pDevice->skb->data;
-#endif
+                 pDevice->skb->mac_header = pDevice->skb->data;
                  pDevice->skb->pkt_type = PACKET_HOST;
                  pDevice->skb->protocol = htons(ETH_P_802_2);
                  memset(pDevice->skb->cb, 0, sizeof(pDevice->skb->cb));
Signature · 7 lines
1.5.4.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#31 lore raw
In reply to Greg KH
Quoted 11 lines · Greg KH
Quoted 9 lines · Forest Bond

Hi,

Quoted 6 lines · John W. Linville
Quoted 5 lines · Johannes Berg

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Quoted 5 lines

Yes we are. But we are doing it correctly :)

Turns out that people actually want to use their hardware, and no one else was working on merging these drivers, so that is what staging is for.

If nobody else was working on merging them, then adding them to staging isn't magically going to make people step up and rewrite the drivers into a state where they *can* actually be merged.

The solution isn't to drag crap drivers that have no hope of getting merged without a major rewrite into the kernel, the solution is to get manufacturers to write drivers that don't suck. And staging doesn't help that at all; it doesn't encourage manufacturers to stop pushing out crap.

The only fixes that drivers are getting in staging now are netdev_ops, whitespace cleanups, and trivial fixes. Nobody is actually rewriting the Ralink or Via staging drivers to use mac80211, which is what's needed for them to be merged. Given that they are going nowhere, are you going to drop them after 6 months of no substantial contributions that advance their mergability? Or are they going to sit around in staging forever, sapping away focus and resources that could be better spent moving wireless forward instead of fixing up a dead-end?

(yes, some wireless drivers in staging are getting attention, but they are 95% NOT vendor drivers; they are community-originated drivers like at76_usb or stlc45xx that were written to use mac80211 in the first place)

Dan

Quoted 37 lines
Quoted 4 lines

Well, gosh, I understand the criticism here and if I were a kernel developer I imagine my perspective would be much the same. But I can't help but feel that there's some amount of hypocrisy when we hammer on a manufacturer to properly license their driver and then let it drop dead when they do.

I agree.

Quoted 3 lines

I understand that the problem would be solved if they manufacturers would suddenly "get it," but the scale of social problem preventing that is likely too large to change anytime soon.

Agreed.

Quoted 7 lines

If kernel developers are too busy to support the hardware, why do the manufacturers take so much criticism for releasing binary-only drivers or badly licensed drivers, or for neglecting to release technical specifications? If what I'm sensing is correct and there's no practical likelihood of these devices getting in-kernel support even with those issues resolved, the criticism almost seems unjustified.

Quoted 8 lines

I appreciate what the kernel developers do, of course, and my intention is not to ruffle feathers. But when a manufacturer that has taken a lot of criticism for its approach to the Linux community shows some good will, it seems like we ought to be able to turn that into something productive. If we can't, what have we been complaining about?

My apologies if I'm way off on this. I haven't been around all that long so it is certainly possible.

You aren't way off at all.

Thanks for the patches, I'll get to them in a few days when my "real job" calms down a bit. They're now in my queue, and will not get lost.

thanks,

greg k-h

#32 lore raw
Quoted 28 lines · Dan Williams
Quoted 11 lines · Greg KH
Quoted 9 lines · Forest Bond

Hi,

Quoted 6 lines · John W. Linville
Quoted 5 lines · Johannes Berg

Hi Marcel,

Quoted 3 lines

just to document the irony here. Two or three years ago at OLS, Kyle and Greg were making fun of Ubuntu merging its 5th wireless stack into their kernel. Now the staging crap is doing exactly the same.

Quoted 5 lines

Yes we are. But we are doing it correctly :)

Turns out that people actually want to use their hardware, and no one else was working on merging these drivers, so that is what staging is for.

If nobody else was working on merging them, then adding them to staging isn't magically going to make people step up and rewrite the drivers into a state where they *can* actually be merged.

The solution isn't to drag crap drivers that have no hope of getting merged without a major rewrite into the kernel, the solution is to get manufacturers to write drivers that don't suck. And staging doesn't help that at all; it doesn't encourage manufacturers to stop pushing out crap.

Quoted 8 lines

The only fixes that drivers are getting in staging now are netdev_ops, whitespace cleanups, and trivial fixes. Nobody is actually rewriting the Ralink or Via staging drivers to use mac80211, which is what's needed for them to be merged. Given that they are going nowhere, are you going to drop them after 6 months of no substantial contributions that advance their mergability? Or are they going to sit around in staging forever, sapping away focus and resources that could be better spent moving wireless forward instead of fixing up a dead-end?

I've been pointing people at the community-based ralink drivers, that is why there is only minor cleanups for those drivers. That is what the linux-wireless developers wanted me to do, so to claim that people are not cleaning them up is totally unfair.

Quoted 4 lines

(yes, some wireless drivers in staging are getting attention, but they are 95% NOT vendor drivers; they are community-originated drivers like at76_usb or stlc45xx that were written to use mac80211 in the first place)

I had patches that added mac80211 to one driver in staging that a wireless developer asked me to revert. So it is happening.

Again, it seems that if there is a community driver, people will help out with it and let the staging one lie for a while, until it gets dropped. Which is what I was told the wireless developers _wanted_ to have happen. So don't complain if exactly what you all wanted to happen is now happening...

As for the via driver, if there is no community driver, and people can find the hardware, let's see what happens.

thanks,

greg k-h

#33 lore raw
In reply to Forest Bond
Quoted 10 lines · Forest Bond
Quoted 3 lines · John W. Linville

None of the above is meant to disagree about the staging crap. Having that stuff around is at best an optimistic attempt to help a few stray users... :-)

Well, gosh, I understand the criticism here and if I were a kernel developer I imagine my perspective would be much the same. But I can't help but feel that there's some amount of hypocrisy when we hammer on a manufacturer to properly license their driver and then let it drop dead when they do.

Proper licensing is a prerequisite, not the final objective.

Quoted 10 lines

I understand that the problem would be solved if they manufacturers would suddenly "get it," but the scale of social problem preventing that is likely too large to change anytime soon.

If kernel developers are too busy to support the hardware, why do the manufacturers take so much criticism for releasing binary-only drivers or badly licensed drivers, or for neglecting to release technical specifications? If what I'm sensing is correct and there's no practical likelihood of these devices getting in-kernel support even with those issues resolved, the criticism almost seems unjustified.

Swimming with the red fishes..."next to no support" may be infinitely greater than "no support", but it still is only a first step. It amounts to throwing something over the wall and walking away.

Most kernel developers have neither financial nor personal interest in supporting hardware they don't have in their possession. Some may still lack both of those for random hardware in their collection. A vendor choosing to take a minimal step towards the community does not obligate us to take great leaps in their direction, especially not at our own expense of time or money.

Quoted 5 lines

I appreciate what the kernel developers do, of course, and my intention is not to ruffle feathers. But when a manufacturer that has taken a lot of criticism for its approach to the Linux community shows some good will, it seems like we ought to be able to turn that into something productive. If we can't, what have we been complaining about?

I would love to see this hardware properly supported in the kernel. I sincerely hope someone finds the time to do something positive with it. But as it stands neither I nor any of the other known wireless developers have infinite time to support a driver for hardware that none of us has -- especially not simply out of the goodness of our hearts. I'm sorry, but that is just the way it is.

Quoted 2 lines

My apologies if I'm way off on this. I haven't been around all that long so it is certainly possible.

Greg has provided drivers/staging as a compromise. I'm sorry if some of the comments seem too harsh, but I think there is room for both positive and negative opinions about drivers/staging. If anything, I'm a bit neutral about it -- I think it helps some users but is probably a net demotivator for development of proper drivers.

Hth...

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
#34 lore raw
In reply to Forest Bond
Quoted 21 lines · Forest Bond

This patch adds the vt6656 driver to drivers/staging.  This code was literally copied from the upstream source archive, available here:

 http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip

Copyright: VIA Networking Technologies, Inc.
License: GPL
Authors: Jerry Chen, Kyle Hsu, Lucas Lin, Lyndon Chen, Tevin Chen, Warren Hsu, Yiching Chen

Patch: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz
Signature: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz.sig

Thanks,
Forest
--
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

Quoted 9 lines

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJ5GrQRO4fQQdv5AwRAjRIAKDb73oGJyViwov/yvUomOTKCeQC7wCeJ1Tr Sq8Nqu8rIJI/wL7AlIyyRv0=
=cloX
-----END PGP SIGNATURE-----

Did this patch (along with the vt6655 one) somehow get lost? I can't see it in drivers/staging.

Signature · 1 line
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
#35 lore raw

Hi,

Quoted 13 lines · Gábor Stefanik
Quoted 11 lines · Forest Bond

This patch adds the vt6656 driver to drivers/staging.  This code was literally copied from the upstream source archive, available here:

 http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip

Copyright: VIA Networking Technologies, Inc.
License: GPL
Authors: Jerry Chen, Kyle Hsu, Lucas Lin, Lyndon Chen, Tevin Chen, Warren Hsu, Yiching Chen

Quoted 5 lines
Quoted 2 lines

Patch: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz
Signature: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz.sig

Did this patch (along with the vt6655 one) somehow get lost? I can't see it in drivers/staging.

vt6655 is in drivers/staging on linux-next, although I have three more patches that I'll be sending to Greg sometime tonight. He has been applying them for me.

vt6656 is currently delayed a bit. I may be able to get a start on that tonight, as well, but there is likelihood of further delay.

Hope this is helpful.

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#36 lore raw
Quoted 22 lines · Forest Bond

Hi,

Quoted 13 lines · Gábor Stefanik
Quoted 11 lines · Forest Bond

This patch adds the vt6656 driver to drivers/staging.  This code was literally copied from the upstream source archive, available here:

 http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip

Copyright: VIA Networking Technologies, Inc.
License: GPL
Authors: Jerry Chen, Kyle Hsu, Lucas Lin, Lyndon Chen, Tevin Chen, Warren Hsu, Yiching Chen

Quoted 5 lines
Quoted 2 lines

Patch: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz
Signature: http://www.alittletooquiet.net/media/code/0002-Add-vt6656-driver-to-drivers-staging.patch.gz.sig

Did this patch (along with the vt6655 one) somehow get lost? I can't see it in drivers/staging.

Quoted 6 lines

vt6655 is in drivers/staging on linux-next, although I have three more patches that I'll be sending to Greg sometime tonight. He has been applying them for me.

vt6656 is currently delayed a bit. I may be able to get a start on that tonight, as well, but there is likelihood of further delay.

By the way, are you sure about the hook below about wpactl.c in commit 8f2c32b86b3ac16ba4c93bf0c2b766089644d9d1 ?

If I do the same in vt6656, it is freezing the kernel, or causing random crashes. Removing the netdev priv assignation makes the driver ok. I don't think the wpa priv was really useful, but I fail to see where it was used, and why it caused the hang.

Don't you have the same issue with vt6655?

BTW, I have some patches to send for vt6656, what is the proper place to submit them since vt6656 is not in staging for now?

drivers/staging/vt6655/wpactl.c +5 -2
index ee7109d..cc4f0ad 100644 (file)
@@ -112,14 +112,17 @@ static void wpadev_setup(struct net_device *dev)
 
 static int wpa_init_wpadev(PSDevice pDevice)
 {
+    PSDevice wpadev_priv;
        struct net_device *dev = pDevice->dev;
          int ret=0;
 
-       pDevice->wpadev = alloc_netdev(0, "vntwpa", wpadev_setup);
+       pDevice->wpadev = alloc_netdev(sizeof(PSDevice), "vntwpa", wpadev_setup);
        if (pDevice->wpadev == NULL)
                return -ENOMEM;
 
-       pDevice->wpadev->priv = pDevice;
+    wpadev_priv = netdev_priv(pDevice->wpadev);
+    *wpadev_priv = *pDevice;
+
        memcpy(pDevice->wpadev->dev_addr, dev->dev_addr, U_ETHER_ADDR_LEN);
          pDevice->wpadev->base_addr = dev->base_addr;
        pDevice->wpadev->irq = dev->irq;
Signature · 1 line
Olivier Blin (blino) - Mandriva
#37 lore raw

Hi Olivier,

Quoted 9 lines · Olivier Blin

By the way, are you sure about the hook below about wpactl.c in commit 8f2c32b86b3ac16ba4c93bf0c2b766089644d9d1 ?

If I do the same in vt6656, it is freezing the kernel, or causing random crashes. Removing the netdev priv assignation makes the driver ok. I don't think the wpa priv was really useful, but I fail to see where it was used, and why it caused the hang.

Don't you have the same issue with vt6655?

I'm embarrassed to say that I haven't actually tested this change on real hardware yet. I've been trying to make changes that do not introduce any difference in functionality, but that fix the compile errors resulting from changing kernel APIs.

Let me restate that I'm not really a kernel hacker, so much of my work is best-effort material. TBH, I don't really understand the wpadev stuff, so it's not clear to me why wpadev->priv can be removed. If you have insight here that I lack, I'd love to hear it.

I should be able to get some real hardware to test on sometime this week.

Quoted 2 lines

BTW, I have some patches to send for vt6656, what is the proper place to submit them since vt6656 is not in staging for now?

I have a similar set of patches for vt6656 mostly prepared that I was going to submit to Greg. Hopefully I can do that soon. I suspect your patches are roughly the same; if they look anything like the vt6655 patches, they probably are.

Thanks,
Forest

Signature · 3 lines
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
#38 lore raw
Quoted 18 lines · Forest Bond

Hi Olivier,

Quoted 9 lines · Olivier Blin

By the way, are you sure about the hook below about wpactl.c in commit 8f2c32b86b3ac16ba4c93bf0c2b766089644d9d1 ?

If I do the same in vt6656, it is freezing the kernel, or causing random crashes. Removing the netdev priv assignation makes the driver ok. I don't think the wpa priv was really useful, but I fail to see where it was used, and why it caused the hang.

Don't you have the same issue with vt6655?

I'm embarrassed to say that I haven't actually tested this change on real hardware yet. I've been trying to make changes that do not introduce any difference in functionality, but that fix the compile errors resulting from changing kernel APIs.

Quoted 4 lines

Let me restate that I'm not really a kernel hacker, so much of my work is best-effort material. TBH, I don't really understand the wpadev stuff, so it's not clear to me why wpadev->priv can be removed. If you have insight here that I lack, I'd love to hear it.

Well, same here. My only insight is that I have tested the code on vt6656 hardware, and that duplicating the device in netdev_priv of wpadev makes the driver crash the system randomly.

Quoted 9 lines

I should be able to get some real hardware to test on sometime this week.

Quoted 2 lines

BTW, I have some patches to send for vt6656, what is the proper place to submit them since vt6656 is not in staging for now?

I have a similar set of patches for vt6656 mostly prepared that I was going to submit to Greg. Hopefully I can do that soon. I suspect your patches are roughly the same; if they look anything like the vt6655 patches, they probably are.

My first patches are the same, and I ended up reusing your tree. But I have a few more cleanups.

Signature · 1 line
Olivier Blin (blino) - Mandriva