vfs: check inode size on no_cached_page
Subsystems (5)
RFC PATCH 1/1 vfs: check inode size on no_cached_page
[This patch may not necessarily be merged, but at least we should
be aware of the problem.]
When user space requests past-EOF data, do_generic_file_read() will issue a bonus readpage call, which may be unfavorable.
do_generic_file_read:
-> find_page:
-> find_get_page() = NULL
-> page_cache_sync_readahead()
-> find_get_page() = NULL
-> no_cached_page:
-> readpage:
-> nfs_readpage() = error
-> readpage_error:--- mm/filemap.c | 5 +++++ 1 file changed, 5 insertions(+)
mm/filemap.c +5 -0
@@ -1269,6 +1269,11 @@ readpage_error: goto out; no_cached_page: + isize =i_size_read (inode); + end_index = (isize -1 ) >>PAGE_CACHE_SHIFT ; +if (unlikely (!isize || index > end_index)) + goto out; +/* * Ok, it wasn't cached, so we need to create a new * page..
Andrew Morton
maintainerQuoted 26 lines · On Sun, 12 Apr 2009 15:16:05 +0800 Wu Fengguang <[email protected]> wrote:
[This patch may not necessarily be merged, but at least we should
be aware of the problem.]When user space requests past-EOF data,
do_generic_file_read()will issue a bonus readpage call, which may be unfavorable.
do_generic_file_read:-> find_page: -> find_get_page() = NULL -> page_cache_sync_readahead() -> find_get_page() = NULL -> no_cached_page: -> readpage: -> nfs_readpage() = error -> readpage_error:Reported-by Xu Chenfeng <[email protected]>Signed-off-by Wu Fengguang <[email protected]>--- mm/filemap.c | 5 +++++ 1 file changed, 5 insertions(+)mm/filemap.c +0
-0@@ -1269,6 +1269,11 @@ readpage_error: goto out;
mm/filemap.c readpage_error: · line 1279
Quoted 10 lines
mm/filemap.c +5
-0no_cached_page: + isize =i_size_read (inode); + end_index = (isize -1 ) >>PAGE_CACHE_SHIFT ; +if (unlikely (!isize || index > end_index)) + goto out; +/* * Ok, it wasn't cached, so we need to create a new * page..
Is this a problem which needs to be solved? userspace does something silly and the kernel behaves a bit suboptimally?
If thats the only problem here then it's not worth adding fastpath cycles to fix it?
Quoted 43 lines · Andrew Morton
Quoted 26 lines · On Sun, 12 Apr 2009 15:16:05 +0800 Wu Fengguang <[email protected]> wrote:
[This patch may not necessarily be merged, but at least we should
be aware of the problem.]When user space requests past-EOF data,
do_generic_file_read()will issue a bonus readpage call, which may be unfavorable.
do_generic_file_read:-> find_page: -> find_get_page() = NULL -> page_cache_sync_readahead() -> find_get_page() = NULL -> no_cached_page: -> readpage: -> nfs_readpage() = error -> readpage_error:Reported-by Xu Chenfeng <[email protected]>Signed-off-by Wu Fengguang <[email protected]>--- mm/filemap.c | 5 +++++ 1 file changed, 5 insertions(+)mm/filemap.c +0
-0@@ -1269,6 +1269,11 @@ readpage_error: goto out;mm/filemap.c readpage_error: · line 1279
Quoted 10 lines
mm/filemap.c +5
-0no_cached_page: + isize =i_size_read (inode); + end_index = (isize -1 ) >>PAGE_CACHE_SHIFT ; +if (unlikely (!isize || index > end_index)) + goto out; +/* * Ok, it wasn't cached, so we need to create a new * page.. Is this a problem which needs to be solved? userspace does something silly and the kernel behaves a bit suboptimally?
Quoted 3 lines
If thats the only problem here then it's not worth adding fastpath cycles to fix it?
Currently, it is the only problem I have found. It is caused by 'dd' which tries to access the page > end_index. However, as linux-based operating systems have
many zero-size configure files, 'isize == 0' could be a more general
case. Without this fastpath, 'no_cached_page' will create many unusable pages.
I add the following lines and boot a small system in kvm.
if (unlikely(!isize || index > end_index))
+ {
+ printk(KERN_DEBUG "over read: %s %lu/%lu\n",
+ filp->f_path.dentry->d_name.name, index, end_index);
goto out;+ }
The 'over read' message in boot time:
Apr 6 23:57:43 kvm kernel: [ 4.334520] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 4.350895] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 4.365575] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 4.695195] over read: mtab 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 5.326886] over read: ifstate 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 5.326912] over read: ifstate 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 5.396599] over read: portmap_mapping 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.076429] over read: random-seed 1/0 Apr 6 23:57:43 kvm kernel: [ 6.152477] over read: utmp 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.152492] over read: utmp 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.367410] over read: etab 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.426226] over read: xtab.tmp 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.426229] over read: xtab 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.533658] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.550716] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.565761] over read: locale 0/18446744073709551615 Apr 6 23:57:47 kvm kernel: [ 10.122621] over read: environment 0/18446744073709551615 Apr 6 23:57:47 kvm kernel: [ 10.122751] over read: locale 0/18446744073709551615 Apr 6 23:58:49 kvm kernel: [ 72.388823] over read: etab.tmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 6.184260] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 6.221483] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 6.260493] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 7.185390] over read: mtab 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 8.960259] over read: ifstate 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 8.960322] over read: ifstate 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 9.155492] over read: portmap_mapping 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 10.922985] over read: random-seed 1/0 Apr 6 23:59:17 kvm kernel: [ 11.151462] over read: utmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.151497] over read: utmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.708856] over read: etab 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.810557] over read: xtab.tmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.810561] over read: xtab 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.954552] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.975360] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.994969] over read: locale 0/18446744073709551615 Apr 6 23:59:22 kvm kernel: [ 16.132338] over read: environment 0/18446744073709551615 Apr 6 23:59:22 kvm kernel: [ 16.132471] over read: locale 0/18446744073709551615
Quoted 43 lines · Andrew Morton
Quoted 26 lines · On Sun, 12 Apr 2009 15:16:05 +0800 Wu Fengguang <[email protected]> wrote:
[This patch may not necessarily be merged, but at least we should
be aware of the problem.]When user space requests past-EOF data,
do_generic_file_read()will issue a bonus readpage call, which may be unfavorable.
do_generic_file_read:-> find_page: -> find_get_page() = NULL -> page_cache_sync_readahead() -> find_get_page() = NULL -> no_cached_page: -> readpage: -> nfs_readpage() = error -> readpage_error:Reported-by Xu Chenfeng <[email protected]>Signed-off-by Wu Fengguang <[email protected]>--- mm/filemap.c | 5 +++++ 1 file changed, 5 insertions(+)mm/filemap.c +0
-0@@ -1269,6 +1269,11 @@ readpage_error: goto out;mm/filemap.c readpage_error: · line 1279
Quoted 10 lines
mm/filemap.c +5
-0no_cached_page: + isize =i_size_read (inode); + end_index = (isize -1 ) >>PAGE_CACHE_SHIFT ; +if (unlikely (!isize || index > end_index)) + goto out; +/* * Ok, it wasn't cached, so we need to create a new * page.. Is this a problem which needs to be solved? userspace does something silly and the kernel behaves a bit suboptimally?
Quoted 3 lines
If thats the only problem here then it's not worth adding fastpath cycles to fix it?
Currently, it is the only problem I have found. It is caused by 'dd' which tries to access the page > end_index. However, as linux-based operating systems have
many zero-size configure files, 'isize == 0' could be a more general
case. Without this fastpath, 'no_cached_page' will create many unusable pages.
I add the following lines and boot a small system in kvm.
if (unlikely(!isize || index > end_index))
+ {
+ printk(KERN_DEBUG "over read: %s %lu/%lu\n",
+ filp->f_path.dentry->d_name.name, index, end_index);
goto out;+ }
The 'over read' message in boot time:
Apr 6 23:57:43 kvm kernel: [ 4.334520] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 4.350895] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 4.365575] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 4.695195] over read: mtab 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 5.326886] over read: ifstate 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 5.326912] over read: ifstate 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 5.396599] over read: portmap_mapping 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.076429] over read: random-seed 1/0 Apr 6 23:57:43 kvm kernel: [ 6.152477] over read: utmp 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.152492] over read: utmp 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.367410] over read: etab 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.426226] over read: xtab.tmp 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.426229] over read: xtab 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.533658] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.550716] over read: locale 0/18446744073709551615 Apr 6 23:57:43 kvm kernel: [ 6.565761] over read: locale 0/18446744073709551615 Apr 6 23:57:47 kvm kernel: [ 10.122621] over read: environment 0/18446744073709551615 Apr 6 23:57:47 kvm kernel: [ 10.122751] over read: locale 0/18446744073709551615 Apr 6 23:58:49 kvm kernel: [ 72.388823] over read: etab.tmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 6.184260] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 6.221483] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 6.260493] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 7.185390] over read: mtab 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 8.960259] over read: ifstate 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 8.960322] over read: ifstate 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 9.155492] over read: portmap_mapping 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 10.922985] over read: random-seed 1/0 Apr 6 23:59:17 kvm kernel: [ 11.151462] over read: utmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.151497] over read: utmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.708856] over read: etab 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.810557] over read: xtab.tmp 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.810561] over read: xtab 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.954552] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.975360] over read: locale 0/18446744073709551615 Apr 6 23:59:17 kvm kernel: [ 11.994969] over read: locale 0/18446744073709551615 Apr 6 23:59:22 kvm kernel: [ 16.132338] over read: environment 0/18446744073709551615 Apr 6 23:59:22 kvm kernel: [ 16.132471] over read: locale 0/18446744073709551615
Quoted 17 lines · Andrew Morton
Quoted 13 lines · On Sun, 12 Apr 2009 15:16:05 +0800 Wu Fengguang…
[This patch may not necessarily be merged, but at least we should
be aware of the problem.]When user space requests past-EOF data,
do_generic_file_read()will issue a bonus readpage call, which may be unfavorable.
do_generic_file_read:-> find_page: -> find_get_page() = NULL -> page_cache_sync_readahead() -> find_get_page() = NULL -> no_cached_page: -> readpage:
Quoted 2 lines
Quoted 2 lines
-> nfs_readpage() = error -> readpage_error:
Sorry nfs_readpage() will actually return 0 now. See below.
Quoted 25 lines
Quoted 11 lines
Reported-by Xu Chenfeng <[email protected]>Signed-off-by Wu Fengguang <[email protected]>--- mm/filemap.c | 5 +++++ 1 file changed, 5 insertions(+)mm/filemap.c +0
-0@@ -1269,6 +1269,11 @@ readpage_error: goto out;mm/filemap.c readpage_error: · line 1279
Quoted 10 lines
mm/filemap.c +5
-0no_cached_page: + isize =i_size_read (inode); + end_index = (isize -1 ) >>PAGE_CACHE_SHIFT ; +if (unlikely (!isize || index > end_index)) + goto out; +/* * Ok, it wasn't cached, so we need to create a new * page.. Is this a problem which needs to be solved? userspace does something silly and the kernel behaves a bit suboptimally?
Quoted 2 lines
If thats the only problem here then it's not worth adding fastpath cycles to fix it?
Yeah just some inefficiency in theory, so no fixing is necessary.
The underlying fs code shall be able to do the right thing - just as if a concurrent truncate happened.
The NFS case goes like this:
nfs_readpage()
{
# some bonus accountings:
nfs_inc_stats(inode, NFSIOS_VFSREADPAGE);
nfs_add_stats(inode, NFSIOS_READPAGES, 1);
nfs_readpage_async(page)
nfs_return_empty_page(page)
zero_user(page) # will zero the page
return 0;
}After it returns 0, do_generic_file_read() will goto page_ok and check i_size there, and free the past-EOF page.
I wonder if NFS could be improved to:
- move the NFSIOS_READPAGES accounting _after_ a successful read
- return AOP_TRUNCATED_PAGE instead of zeroing the past-EOF page The following untested patch demonstrates the ideas.
Thanks,
Fengguang
---
fs/nfs/read.c +5 -12
@@ -76,15 +76,6 @@ void nfs_readdata_release(void *data)nfs_readdata_free (rdata); } -static -int nfs_return_empty_page (struct page *page) -{ -zero_user (page,0 ,PAGE_CACHE_SIZE ); -SetPageUptodate (page); -unlock_page (page); -return 0 ; -} -static void nfs_readpage_truncate_uninitialised_page (struct nfs_read_data *data) {unsigned int remainder = data->args.count - data->res.count;
@@ -123,7 +114,8 @@ int nfs_readpage_async(struct nfs_open_context *ctx, struct inode *inode, len =nfs_page_length (page);if (len ==0 ) -return nfs_return_empty_page (page); +return AOP_TRUNCATED_PAGE ; + new =nfs_create_request (ctx, inode, page,0 , len);if (IS_ERR (new)) {unlock_page (page);
@@ -516,7 +508,6 @@ int nfs_readpage(struct file *file, struct page *page)dprintk ("NFS: nfs_readpage (%p %ld@%lu)\n" , page,PAGE_CACHE_SIZE , page->index);nfs_inc_stats (inode,NFSIOS_VFSREADPAGE ); -nfs_add_stats (inode,NFSIOS_READPAGES ,1 );/* * Try to flush any pending writes to the file..
@@ -550,6 +541,8 @@ int nfs_readpage(struct file *file, struct page *page) } error =nfs_readpage_async (ctx, inode, page); +if (!error) +nfs_add_stats (inode,NFSIOS_READPAGES ,1 ); out:put_nfs_open_context (ctx);
@@ -575,7 +568,7 @@ readpage_async_filler(void *data, struct page *page) len =nfs_page_length (page);if (len ==0 ) -return nfs_return_empty_page (page); +return AOP_TRUNCATED_PAGE ; new =nfs_create_request (desc->ctx, inode, page,0 , len);if (IS_ERR (new))
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 71 lines · Wu Fengguang
Quoted 17 lines · Andrew Morton
Quoted 13 lines · On Sun, 12 Apr 2009 15:16:05 +0800 Wu Fengguang <[email protected]> wrote:
[This patch may not necessarily be merged, but at least we should
be aware of the problem.]When user space requests past-EOF data,
do_generic_file_read()will issue a bonus readpage call, which may be unfavorable.
do_generic_file_read:-> find_page: -> find_get_page() = NULL -> page_cache_sync_readahead() -> find_get_page() = NULL -> no_cached_page: -> readpage:Quoted 2 lines
Quoted 2 lines
-> nfs_readpage() = error -> readpage_error:Sorry
nfs_readpage()will actually return 0 now. See below.Quoted 25 lines
Quoted 11 lines
Reported-by Xu Chenfeng <[email protected]>Signed-off-by Wu Fengguang <[email protected]>--- mm/filemap.c | 5 +++++ 1 file changed, 5 insertions(+)mm/filemap.c +0
-0@@ -1269,6 +1269,11 @@ readpage_error: goto out;mm/filemap.c readpage_error: · line 1279
Quoted 10 lines
mm/filemap.c +5
-0no_cached_page: + isize =i_size_read (inode); + end_index = (isize -1 ) >>PAGE_CACHE_SHIFT ; +if (unlikely (!isize || index > end_index)) + goto out; +/* * Ok, it wasn't cached, so we need to create a new * page.. Is this a problem which needs to be solved? userspace does something silly and the kernel behaves a bit suboptimally?
Quoted 2 lines
If thats the only problem here then it's not worth adding fastpath cycles to fix it?
Yeah just some inefficiency in theory, so no fixing is necessary.
The underlying fs code shall be able to do the right thing - just as if a concurrent truncate happened.
The NFS case goes like this:
nfs_readpage() { # some bonus accountings: nfs_inc_stats(inode, NFSIOS_VFSREADPAGE); nfs_add_stats(inode, NFSIOS_READPAGES, 1); nfs_readpage_async(page) nfs_return_empty_page(page) zero_user(page) # will zero the page return 0; }
Quoted 6 lines
After it returns 0,
do_generic_file_read()will gotopage_okand checki_sizethere, and free the past-EOF page.I wonder if NFS could be improved to:
- move theNFSIOS_READPAGESaccounting _after_ a successful read
- returnAOP_TRUNCATED_PAGEinstead of zeroing the past-EOF page
Ah AOP_TRUNCATED_PAGE actually indicates to retry the read_page() call. Returning AOP_TRUNCATED_PAGE in nfs_read_page() in this case will create an infinite loop...
Thanks,
Fengguang
Quoted 62 lines
The following untested patch demonstrates the ideas.
Thanks,
Fengguang
---fs/nfs/read.c +5
-12@@ -76,15 +76,6 @@ void nfs_readdata_release(void *data)nfs_readdata_free (rdata); } -static -int nfs_return_empty_page (struct page *page) -{ -zero_user (page,0 ,PAGE_CACHE_SIZE ); -SetPageUptodate (page); -unlock_page (page); -return 0 ; -} -static void nfs_readpage_truncate_uninitialised_page (struct nfs_read_data *data) {unsigned int remainder = data->args.count - data->res.count;@@ -123,7 +114,8 @@ int nfs_readpage_async(struct nfs_open_context *ctx, struct inode *inode, len =nfs_page_length (page);if (len ==0 ) -return nfs_return_empty_page (page); +return AOP_TRUNCATED_PAGE ; + new =nfs_create_request (ctx, inode, page,0 , len);if (IS_ERR (new)) {unlock_page (page);@@ -516,7 +508,6 @@ int nfs_readpage(struct file *file, struct page *page)dprintk ("NFS: nfs_readpage (%p %ld@%lu)\n" , page,PAGE_CACHE_SIZE , page->index);nfs_inc_stats (inode,NFSIOS_VFSREADPAGE ); -nfs_add_stats (inode,NFSIOS_READPAGES ,1 );/* * Try to flush any pending writes to the file.. @@ -550,6 +541,8 @@ int nfs_readpage(struct file *file, struct page *page) } error =nfs_readpage_async (ctx, inode, page); +if (!error) +nfs_add_stats (inode,NFSIOS_READPAGES ,1 ); out:put_nfs_open_context (ctx);@@ -575,7 +568,7 @@ readpage_async_filler(void *data, struct page *page) len =nfs_page_length (page);if (len ==0 ) -return nfs_return_empty_page (page); +return AOP_TRUNCATED_PAGE ; new =nfs_create_request (desc->ctx, inode, page,0 , len);if (IS_ERR (new))