Skip to contentSkip to conversation

Cleanup code that think bio_alloc with __GFP_WAIT can fail

PATCH In review Nikanth Karthikesan 2 participants 2 messages Apr 15, 2009

lore
Share & tools
lore
#0 lore raw

cover Cleanup code that think bio_alloc with __GFP_WAIT can fail

bio_alloc will not fail when __GFP_WAIT is specified in the gfp_flags. See
http://lkml.org/lkml/2009/4/14/198 for the discussion. But this not documented and there are places where there is unwanted code to handle bio_alloc failure even when __GFP_WAIT is specified. This patch set documents this and cleans up various callers who assume bio_alloc can fail even with __GFP_WAIT.

Thanks
Nikanth

#1 lore raw
Quoted 6 lines · Nikanth Karthikesan

bio_alloc will not fail when __GFP_WAIT is specified in the gfp_flags. See http://lkml.org/lkml/2009/4/14/198 for the discussion. But this not documented and there are places where there is unwanted code to handle bio_alloc failure even when __GFP_WAIT is specified. This patch set documents this and cleans up various callers who assume bio_alloc can fail even with __GFP_WAIT.

I added your patches 2-7, I substituted 1/7 with one I did myself that uses proper kerneldoc annotation. Thanks!

Signature · 1 line
Jens Axboe