Skip to contentSkip to conversation

regulator: remove extraneous semicolon

PATCH In review Eugene Teo 3 participants 3 messages Apr 15, 2009 Voltage and current regulator framework

lore
Share & tools
lore

Eugene Teo

author
#0 lore raw

PATCH 1/1 regulator: remove extraneous semicolon

An extraneous ";" after the if statement is a bad idea.

---
 drivers/regulator/core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/core.c +2 -2
index 01f7702..47fc6e6 100644
@@ -540,8 +540,8 @@ static void drms_uA_update(struct regulator_dev *rdev)
 
 	err = regulator_check_drms(rdev);
 	if (err < 0 || !rdev->desc->ops->get_optimum_mode ||
-	    !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode);
-	return;
+	    !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode)
+		return;
 
 	/* get output voltage */
 	output_uV = rdev->desc->ops->get_voltage(rdev);
#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 3 lines · Eugene Teo

An extraneous ";" after the if statement is a bad idea.

Someone sent the same patch a couple of days ago so that one might end up getting merged instead but in any case

Thanks, I've just applied the earlier patch as it was first in my inbox.

Liam