i915: Register ACPI video even when not modesetting
Subsystems (3)
PATCH 1/1 i915: Register ACPI video even when not modesetting
The ACPI video driver defers registration to the i915 driver if the system supports opregion-mediated backlight control. This registration was only being performed in the KMS case. Ensure it's done even if we don't have modesetting enabled.
drivers/gpu/drm/i915/i915_opregion.c +5 -4
@@ -370,11 +370,8 @@ int intel_opregion_init(struct drm_device *dev, int resume)if (mboxes &MBOX_ACPI ) {DRM_DEBUG ("Public ACPI methods supported\n" ); opregion->acpi = base +OPREGION_ACPI_OFFSET ; -if (drm_core_check_feature (dev,DRIVER_MODESET )) { +if (drm_core_check_feature (dev,DRIVER_MODESET ))intel_didl_outputs (dev); -if (!resume) -acpi_video_register (); - } }else {DRM_DEBUG ("Public ACPI methods not supported\n" ); err = -ENOTSUPP ;
@@ -391,6 +388,10 @@ int intel_opregion_init(struct drm_device *dev, int resume) opregion->asle = base +OPREGION_ASLE_OFFSET ; } +if (!resume) +acpi_video_register (); + +/* Notify BIOS we are ready to handle ACPI video ext notifs. * Right now, all the events are handled by the ACPI video module. * We don't actually need to do anything with them. */
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 4 lines · Matthew Garrett
The ACPI video driver defers registration to the i915 driver if the system supports opregion-mediated backlight control. This registration was only being performed in the KMS case. Ensure it's done even if we don't have modesetting enabled.
Does this provide backlight control even without DRI enabled, or just without KMS enabled?
Regards,
Tino
Quoted 8 lines · Tino Keitel
Quoted 4 lines · Matthew Garrett
The ACPI video driver defers registration to the i915 driver if the system supports opregion-mediated backlight control. This registration was only being performed in the KMS case. Ensure it's done even if we don't have modesetting enabled.
Does this provide backlight control even without DRI enabled, or just without KMS enabled?
Just without KMS being enabled. If your backlight control doesn't work without dri, that's because your backlight control requires a kernel-level component to change the backlight registers in response to an IRQ (ie, DRI)
Signature · 1 line
Matthew Garrett | [email protected]
applied
(and acpi-devel fixed to linux-acpi on cc:-)
thanks,
Len Brown, Intel Open Source Technology Center
Quoted 44 lines · Matthew Garrett
The ACPI video driver defers registration to the i915 driver if the system supports opregion-mediated backlight control. This registration was only being performed in the KMS case. Ensure it's done even if we don't have modesetting enabled.
Signed-off-by Matthew Garrett <[email protected]>drivers/gpu/drm/i915/i915_opregion.c +5
-4@@ -370,11 +370,8 @@ int intel_opregion_init(struct drm_device *dev, int resume)if (mboxes &MBOX_ACPI ) {DRM_DEBUG ("Public ACPI methods supported\n" ); opregion->acpi = base +OPREGION_ACPI_OFFSET ; -if (drm_core_check_feature (dev,DRIVER_MODESET )) { +if (drm_core_check_feature (dev,DRIVER_MODESET ))intel_didl_outputs (dev); -if (!resume) -acpi_video_register (); - } }else {DRM_DEBUG ("Public ACPI methods not supported\n" ); err = -ENOTSUPP ;@@ -391,6 +388,10 @@ int intel_opregion_init(struct drm_device *dev, int resume) opregion->asle = base +OPREGION_ASLE_OFFSET ; } +if (!resume) +acpi_video_register (); + +/* Notify BIOS we are ready to handle ACPI video ext notifs. * Right now, all the events are handled by the ACPI video module. * We don't actually need to do anything with them. */ Signature · 7 lines
-- Matthew Garrett | [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/