fix DaVinci NS16550_REG_SIZE regression
PATCH 1/1 fix DaVinci NS16550_REG_SIZE regression
From: David Brownell <[email protected]>
Update the DaVinci DM6446 boards to use the new convention for CONFIG_SYS_NS16550_REG_SIZE ... the size hasn't changed from the original 4 bytes, but these chips are little-endian.
(Resolves a regression added recently by the include/ns16550.h patch to "Unify structure declaration for registers". The code previously worked just fine because the registers were accessed as host-endian words, not as bytes.)
--- include/configs/davinci_dvevm.h | 2 +- include/configs/davinci_schmoogie.h | 2 +- include/configs/davinci_sffsdr.h | 2 +- include/configs/davinci_sonata.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
include/configs/davinci_dvevm.h +1 -1
@@ -85,7 +85,7 @@/*====================*/ #define CONFIG_SYS_NS16550 #define CONFIG_SYS_NS16550_SERIAL -#define CONFIG_SYS_NS16550_REG_SIZE 4/* NS16550 register size */ +#define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ #define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */
include/configs/davinci_schmoogie.h +1 -1
@@ -52,7 +52,7 @@/*====================*/ #define CONFIG_SYS_NS16550 #define CONFIG_SYS_NS16550_SERIAL -#define CONFIG_SYS_NS16550_REG_SIZE 4/* NS16550 register size */ +#define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ #define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */
include/configs/davinci_sffsdr.h +1 -1
@@ -54,7 +54,7 @@/* Serial Driver info */ #define CONFIG_SYS_NS16550 #define CONFIG_SYS_NS16550_SERIAL -#define CONFIG_SYS_NS16550_REG_SIZE 4/* NS16550 register size */ +#define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ #define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */
include/configs/davinci_sonata.h +1 -1
@@ -85,7 +85,7 @@/*====================*/ #define CONFIG_SYS_NS16550 #define CONFIG_SYS_NS16550_SERIAL -#define CONFIG_SYS_NS16550_REG_SIZE 4/* NS16550 register size */ +#define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ #define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */
PATCH 1/1 fix DaVinci NS16550_REG_SIZE regression
Hi David,
Quoted 6 lines
From: David Brownell <[email protected]>
Update the DaVinci DM6446 boards to use the new convention for
CONFIG_SYS_NS16550_REG_SIZE... the size hasn't changed from the original 4 bytes, but these chips are little-endian.
Quoted 6 lines
(Resolves a regression added recently by the
include/ns16550.hpatch to "Unify structure declaration for registers". The code previously worked just fine because the registers were accessed as host-endian words, not as bytes.)Signed-off-by David Brownell <[email protected]>
Excellent, thanks. As noted, I was aware that such problems may pop up, but I think it is nice now to be on the safe side of explicitely expressing what we do and not obfuscate that with different c types.
Cheers
Detlev
Signature · 8 lines
Summary [of object-oriented programming in Perl 5] That's all about there is to it. Now you just need to go off and buy a book about object-oriented design methodology, and bang your forehead with it for the next six months or so. Larry Wall [Creator of Perl] -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
Wolfgang Denk
AppliedPATCH 1/1 fix DaVinci NS16550_REG_SIZE regression
In reply to David BrownellDear David Brownell,
Quoted 11 lines · In message <[email protected]> you wrote:
From: David Brownell <[email protected]>
Update the DaVinci DM6446 boards to use the new convention for
CONFIG_SYS_NS16550_REG_SIZE... the size hasn't changed from the original 4 bytes, but these chips are little-endian.(Resolves a regression added recently by the
include/ns16550.hpatch to "Unify structure declaration for registers". The code previously worked just fine because the registers were accessed as host-endian words, not as bytes.)
Quoted 7 lines
Signed-off-by David Brownell <[email protected]>--- include/configs/davinci_dvevm.h | 2 +- include/configs/davinci_schmoogie.h | 2 +- include/configs/davinci_sffsdr.h | 2 +- include/configs/davinci_sonata.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I'm frequently appalled by the low regard you Earthmen have for life. -- Spock, "The Galileo Seven", stardate 2822.3