Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
Subsystems (2)
PATCH 1/1 Be explict with what we are !'ing in ixgbe_sfp_config_module_task()
From: Tony Breeds <[email protected]>
GCC warns:drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around operand of '!' or change '&' to '&&' or '!' to '~'
Which I think is right. Bracket to remove ambiguity.
Signed-off-by Tony Breeds <[email protected]>
Signed-off-by Jeff Kirsher <[email protected]>
---
drivers/net/ixgbe/ixgbe_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +1 -1
@@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work) } hw->mac.ops.setup_sfp (hw); -if (!adapter->flags &IXGBE_FLAG_IN_SFP_LINK_TASK ) +if (!(adapter->flags &IXGBE_FLAG_IN_SFP_LINK_TASK ))/* This will also work for DA Twinax connections */ schedule_work (&adapter->multispeed_fiber_task); adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK ;
From: Jeff Kirsher <[email protected]>
Date: Thu, 16 Apr 2009 16:22:28 -0700
Quoted 9 lines
GCC warns:
drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around operand of '!' or change '&' to '&&' or '!' to '~'Which I think is right. Bracket to remove ambiguity.
Signed-off-by Tony Breeds <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied, thanks.