minor DaVinci clock cleanup
PATCH 1/1 minor DaVinci clock cleanup
From: David Brownell <[email protected]>
Minor cleanup to clock-related defines for DaVinci DM6446 boards:
- CONFIG_SYS_CLK_FREQ is unused; remove it.
- CONFIG_SYS_NS16550_CLK must be the same as CONFIG_SYS_HZ_CLOCK
On DM6446 both of those peripheral clocks actually come from the same source, the primary oscillator. Having them use the same symbol avoids bugs in the clone'n'modify development cycle.
--- include/configs/davinci_dvevm.h | 3 +-- include/configs/davinci_schmoogie.h | 3 +-- include/configs/davinci_sffsdr.h | 3 +-- include/configs/davinci_sonata.h | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-)
include/configs/davinci_dvevm.h +1 -2
@@ -56,7 +56,6 @@/* SoC Configuration */ /*===================*/ #define CONFIG_ARM926EJS /* arm926ejs CPU core */ -#define CONFIG_SYS_CLK_FREQ 297000000/* Arm Clock frequency */ #define CONFIG_SYS_TIMERBASE 0x01c21400/* use timer 0 */ #define CONFIG_SYS_HZ_CLOCK 27000000/* Timer Input clock freq */ #define CONFIG_SYS_HZ 1000
@@ -87,7 +86,7 @@#define CONFIG_SYS_NS16550_SERIAL #define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ -#define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ +#define CONFIG_SYS_NS16550_CLK CONFIG_SYS_HZ_CLOCK/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */ #define CONFIG_BAUDRATE 115200/* Default baud rate */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
include/configs/davinci_schmoogie.h +1 -2
@@ -31,7 +31,6 @@/* SoC Configuration */ /*===================*/ #define CONFIG_ARM926EJS /* arm926ejs CPU core */ -#define CONFIG_SYS_CLK_FREQ 297000000/* Arm Clock frequency */ #define CONFIG_SYS_TIMERBASE 0x01c21400/* use timer 0 */ #define CONFIG_SYS_HZ_CLOCK 27000000/* Timer Input clock freq */ #define CONFIG_SYS_HZ 1000
@@ -54,7 +53,7 @@#define CONFIG_SYS_NS16550_SERIAL #define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ -#define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ +#define CONFIG_SYS_NS16550_CLK CONFIG_SYS_HZ_CLOCK/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */ #define CONFIG_BAUDRATE 115200/* Default baud rate */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
include/configs/davinci_sffsdr.h +1 -2
@@ -32,7 +32,6 @@* powering ON the DSP. */ /* SoC Configuration */ #define CONFIG_ARM926EJS /* arm926ejs CPU core */ -#define CONFIG_SYS_CLK_FREQ 297000000/* Arm Clock frequency */ #define CONFIG_SYS_TIMERBASE 0x01c21400/* use timer 0 */ #define CONFIG_SYS_HZ_CLOCK 27000000/* Timer Input clock freq */ #define CONFIG_SYS_HZ 1000
@@ -56,7 +55,7 @@#define CONFIG_SYS_NS16550_SERIAL #define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ -#define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ +#define CONFIG_SYS_NS16550_CLK CONFIG_SYS_HZ_CLOCK/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */ #define CONFIG_BAUDRATE 115200/* Default baud rate */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
include/configs/davinci_sonata.h +1 -2
@@ -56,7 +56,6 @@/* SoC Configuration */ /*===================*/ #define CONFIG_ARM926EJS /* arm926ejs CPU core */ -#define CONFIG_SYS_CLK_FREQ 297000000/* Arm Clock frequency */ #define CONFIG_SYS_TIMERBASE 0x01c21400/* use timer 0 */ #define CONFIG_SYS_HZ_CLOCK 27000000/* Timer Input clock freq */ #define CONFIG_SYS_HZ 1000
@@ -87,7 +86,7 @@#define CONFIG_SYS_NS16550_SERIAL #define CONFIG_SYS_NS16550_REG_SIZE -4/* NS16550 register size, byteorder */ #define CONFIG_SYS_NS16550_COM1 0x01c20000/* Base address of UART0 */ -#define CONFIG_SYS_NS16550_CLK 27000000/* Input clock to NS16550 */ +#define CONFIG_SYS_NS16550_CLK CONFIG_SYS_HZ_CLOCK/* Input clock to NS16550 */ #define CONFIG_CONS_INDEX 1/* use UART0 for console */ #define CONFIG_BAUDRATE 115200/* Default baud rate */ #define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
Jean-Christophe PLAGNIOL-VILLARD
AppliedPATCH 1/1 minor DaVinci clock cleanup
Quoted 11 lines · David Brownell
From: David Brownell <[email protected]>
Minor cleanup to clock-related defines for DaVinci DM6446 boards:
-
CONFIG_SYS_CLK_FREQis unused; remove it.-
CONFIG_SYS_NS16550_CLKmust be the same asCONFIG_SYS_HZ_CLOCKOn DM6446 both of those peripheral clocks actually come from the same source, the primary oscillator. Having them use the same symbol avoids bugs in the clone'n'modify development cycle.
applied
Best Regards,
J.
PATCH 1/1 minor DaVinci clock cleanup
Dear Jean-Christophe PLAGNIOL-VILLARD,
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 4 lines · David Brownell
From: David Brownell <[email protected]>
Minor cleanup to clock-related defines for DaVinci DM6446 boards:
Quoted 8 lines
Quoted 7 lines
-
CONFIG_SYS_CLK_FREQis unused; remove it.-
CONFIG_SYS_NS16550_CLKmust be the same asCONFIG_SYS_HZ_CLOCKOn DM6446 both of those peripheral clocks actually come from the same source, the primary oscillator. Having them use the same symbol avoids bugs in the clone'n'modify development cycle.
applied
May I please have a pull request for this any time soon? Thanks.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de On my planet, to rest is to rest -- to cease using energy. To me, it is quite illogical to run up and down on green grass, using energy, instead of saving it. -- Spock, "Shore Leave", stardate 3025.2