Skip to contentSkip to conversation

AFS: Guard afs_file_readpage_read_complete() definition with CONFIG_AFS_FSCACHE

PATCH New David Howells 1 participant 1 message Apr 17, 2009 Afs filesystem

lore
Share & tools
lore

David Howells

author maintainer
#0 lore raw

PATCH 1/1 AFS: Guard afs_file_readpage_read_complete() definition with CONFIG_AFS_FSCACHE

From: Matt Kraai <[email protected]>

If CONFIG_AFS_FSCACHE is not defined, the following warning is displayed when fs/afs/file.c is compiled:

fs/afs/file.c:111: warning: ‘afs_file_readpage_read_complete’ defined but not used

This occurs because all calls to this function are guarded by CONFIG_AFS_FSCACHE. Thus, guard its definition as well.

---

 fs/afs/file.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/afs/file.c +2 -0
index 7a1d942..0149dab 100644
@@ -102,6 +102,7 @@ int afs_release(struct inode *inode, struct file *file)
 	return 0;
 }
 
+#ifdef CONFIG_AFS_FSCACHE
 /*
  * deal with notification that a page was read from the cache
  */
@@ -117,6 +118,7 @@ static void afs_file_readpage_read_complete(struct page *page,
 		SetPageUptodate(page);
 	unlock_page(page);
 }
+#endif
 
 /*
  * AFS read page from file, directory or symlink